parse error for trailing comma in tsconfig.json

[dominikg]

According to this issue on typescript repo, trailing commas in tsconfig are legal (like comments)
microsoft/TypeScript#20384 (comment)

Example:

{
  "extends": "@tsconfig/svelte/tsconfig.json",
  "include": ["src/**/*"],
  "exclude": ["node_modules"], // <- here
}

Comments are stripped here, but the comma is not, resulting in an error.

tsconfig/src/tsconfig.ts

Line 187 in 3d0586d

export function parse (contents: string, filename: string) {

[blakeembrey]

Makes sense, related to #28. Happy to accept a PR here, but would likely mean trying to implement a custom JSON parser. I'd recommend using typescript directly where possible.

[dominikg]

I see 2 possible implementations

1. after stripping comments with https://github.com/sindresorhus/strip-json-comments use a similar implementation to strip the dangling commas before passing it to JSON.parse
   2) get nasty and use eval, trying to safeguard against nefarious input
   edit: removed some code that looked like it could work but i don't want to leave it here as it is too dangerous

an optional peerdependency on typescript and using its native functions before resorting to a custom implementation would be better. In my case i ran into this in vite, which uses esbuild so there is no typescript by default.

[tmeindle]

Have you thought about using the jsonc-parser package to read the config files ?
https://www.npmjs.com/package/jsonc-parser

[DecimalTurn]

@blakeembrey did you ever get the chance to look at @dominikg's original PR (#31)?
If you think it has a good approach, I could always replicate it.

[dominikg]

as mentioned in that PR i am no longer interested in this. please do not tag me