From 728d2d6a230c8b92b65cd8ad83b8360b6be2b936 Mon Sep 17 00:00:00 2001 From: Trinh Ngoc Hung Date: Mon, 8 Dec 2025 07:11:55 +0700 Subject: [PATCH] [Fix] account: fix assing journal xmlids --- .../scripts/account/17.0.1.2/end-migration.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/openupgrade_scripts/scripts/account/17.0.1.2/end-migration.py b/openupgrade_scripts/scripts/account/17.0.1.2/end-migration.py index b8f1a1284d79..d575a4181105 100644 --- a/openupgrade_scripts/scripts/account/17.0.1.2/end-migration.py +++ b/openupgrade_scripts/scripts/account/17.0.1.2/end-migration.py @@ -21,10 +21,15 @@ def _assign_journal_xmlids(env): for xmlid, journal_data in list( template_data.get("account.journal", {}).items() ): - if not env.ref(xmlid, raise_if_not_found=False) and "type" in journal_data: + if ( + not env.ref(xmlid, raise_if_not_found=False) + and "type" in journal_data + and "code" in journal_data + ): journal = existing_journals.filtered( lambda j: j.type == journal_data["type"] # noqa: B023 - )[:1] + and j.code == journal_data["code"] # noqa: B023 + ) if journal: existing_journals -= journal env["ir.model.data"]._update_xmlids(