From 827b7e82dc2da0109c65e4e08ceab3ee0fd515b3 Mon Sep 17 00:00:00 2001 From: Alex Mercier Date: Fri, 18 Jan 2019 10:26:14 +0100 Subject: [PATCH 1/3] Added Travis CI config --- .travis.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 .travis.yml diff --git a/.travis.yml b/.travis.yml new file mode 100644 index 0000000..9ff450b --- /dev/null +++ b/.travis.yml @@ -0,0 +1,11 @@ +language: node_js +node_js: + - node # Current + - 10 # Latest LTS + - 8 + - 6 # Minimum supported +before_script: + npm run lint +cache: + directories: + - $HOME/.npm From 8a3967f8696162fb7017a8a03ce1646cddf08a9c Mon Sep 17 00:00:00 2001 From: Alex Mercier Date: Fri, 18 Jan 2019 10:31:32 +0100 Subject: [PATCH 2/3] Added "test" NPM script --- package.json | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 9e0c8ad..ba66f72 100644 --- a/package.json +++ b/package.json @@ -16,11 +16,12 @@ "type": "git", "url": "git@github.com:WebbyLab/eslint-plugin-more.git" }, - "engines" : { - "node" : ">=6.0.0" + "engines": { + "node": ">=6.0.0" }, "scripts": { - "lint": "eslint ./" + "lint": "eslint ./", + "test": "find tests -type f -exec echo -n ▸ {} \\; -exec node {} \\; -exec echo ' ✓' \\;" }, "devDependencies": { "babel-eslint": "^7.1.1", From 09c46b8c373950c4d5120ac8674fe3270ad27d28 Mon Sep 17 00:00:00 2001 From: Alex Mercier Date: Fri, 18 Jan 2019 10:31:43 +0100 Subject: [PATCH 3/3] Added Travis CI build status badge --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index bfa9bfa..ac0cecb 100644 --- a/README.md +++ b/README.md @@ -2,6 +2,8 @@ [![NPM](https://nodei.co/npm/eslint-plugin-more.png?compact=true)](https://npmjs.org/package/eslint-plugin-more) +[![Build Status](https://travis-ci.org/WebbyLab/eslint-plugin-more.svg?branch=master)](https://travis-ci.org/WebbyLab/eslint-plugin-more) + Eslint is a very great tool and it already has tons of rules. Eslint allows us to reduce amount of time required for code review. But, of course, eslint cannot cover all the issues. So, we do in the following way, if during code review we see, that we comment on thing that is possible to check automatically, then we create new eslint rule. Some of this rules will go to upstream after proving them in our codebase.