Build error

[jdiez17]

First: thank you for making this fork of Phoebus for Yamcs! I was just looking at the differences between Yamcs Studio and Phoebus and started to think how much effort would it be to write a connector for Phoebus.

I'm getting the following compilation error when running mvn install:

[ERROR] Building tree for all the packages and classes...
[ERROR] /home/jdiez/dev/phoebus/core/commander-core/src/main/java/com/windhoverlabs/pv/yamcs/YamcsSubscriptionService.java:49: error: reference not found
[ERROR]  * Keeps track of {@link IPV} registration state and takes care of establishing or re-establishing a
[ERROR]                          ^
[ERROR] /home/jdiez/dev/phoebus/core/commander-core/src/main/java/com/windhoverlabs/pv/yamcs/RemoteEntityHolder.java:12: error: reference not found
[ERROR]  * <p>This is intended as a convenience class for passing information from {@link YamcsConnector} to
[ERROR]                                                                                   ^
[ERROR] /home/jdiez/dev/phoebus/core/commander-core/src/main/java/com/windhoverlabs/yamcs/core/YamcsWebSocketClient.java:31: error: reference not found
[ERROR]  * io.netty.example.http.websocketx.server.WebSocketServer} or connect to an existing WebSocket
[...]
[ERROR] 4 errors
[ERROR] 100 warnings
[ERROR] 
[ERROR] Command line was: /usr/lib/jvm/jre-17-openjdk/bin/javadoc @options @packages
[ERROR] 
[ERROR] Refer to the generated Javadoc files in '/home/jdiez/dev/phoebus/core/commander-core/target/apidocs' dir.
[ERROR] 
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :commander-core

[jdiez17]

Worked around it by running mvn -DskipTests -Dmaven.javadoc.skip=true install. Now I'm getting this:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  20.333 s
[INFO] Finished at: 2025-02-21T21:35:47+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.coveo:fmt-maven-plugin:2.13:check (default) on project commander-core: Execution default of goal com.coveo:fmt-maven-plugin:2.13:check failed: An API incompatibility was encountered while executing com.coveo:fmt-maven-plugin:2.13:check: java.lang.IllegalAccessError: null
[ERROR] -----------------------------------------------------
[ERROR] realm =    plugin>com.coveo:fmt-maven-plugin:2.13
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = file:/home/jdiez/.m2/repository/com/coveo/fmt-maven-plugin/2.13/fmt-maven-plugin-2.13.jar
[ERROR] urls[1] = file:/home/jdiez/.m2/repository/org/apache/commons/commons-lang3/3.8.1/commons-lang3-3.8.1.jar
[ERROR] urls[2] = file:/home/jdiez/.m2/repository/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.5/org.eclipse.sisu.inject-0.3.5.jar
[ERROR] urls[3] = file:/home/jdiez/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
[ERROR] urls[4] = file:/home/jdiez/.m2/repository/org/codehaus/plexus/plexus-utils/3.3.0/plexus-utils-3.3.0.jar
[ERROR] urls[5] = file:/home/jdiez/.m2/repository/com/google/googlejavaformat/google-java-format/1.13.0/google-java-format-1.13.0.jar
[ERROR] urls[6] = file:/home/jdiez/.m2/repository/com/google/guava/guava/30.1.1-jre/guava-30.1.1-jre.jar
[ERROR] urls[7] = file:/home/jdiez/.m2/repository/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar
[ERROR] urls[8] = file:/home/jdiez/.m2/repository/com/google/guava/listenablefuture/9999.0-empty-to-avoid-conflict-with-guava/listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar
[ERROR] urls[9] = file:/home/jdiez/.m2/repository/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar
[ERROR] urls[10] = file:/home/jdiez/.m2/repository/org/checkerframework/checker-qual/3.8.0/checker-qual-3.8.0.jar
[ERROR] urls[11] = file:/home/jdiez/.m2/repository/com/google/errorprone/error_prone_annotations/2.5.1/error_prone_annotations-2.5.1.jar
[ERROR] urls[12] = file:/home/jdiez/.m2/repository/com/google/j2objc/j2objc-annotations/1.3/j2objc-annotations-1.3.jar
[ERROR] Number of foreign imports: 1
[ERROR] import: Entry[import  from realm ClassRealm[project>com.windhoverlabs:commander-core:0.3.1-SNAPSHOT, parent: ClassRealm[maven.api, parent: null]]]
[ERROR] 
[ERROR] -----------------------------------------------------
[ERROR] : class com.google.googlejavaformat.java.JavaInput (in unnamed module @0x194f7a83) cannot access class com.sun.tools.javac.parser.Tokens$TokenKind (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.parser to unnamed module @0x194f7a83

Java version:

openjdk version "21.0.5" 2024-10-15
OpenJDK Runtime Environment (Red_Hat-21.0.5.0.11-1) (build 21.0.5+11)
OpenJDK 64-Bit Server VM (Red_Hat-21.0.5.0.11-1) (build 21.0.5+11, mixed mode, sharing)

[lorenzo-gomez-windhover]

@jdiez17 Really cool to see people using this :) .

First of all I suspect that you really want to build it, which I understand. But, if all you want to do is use it, we do have nightly builds here:https://github.com/WindhoverLabs/phoebus/releases.

I know we need to move up to a newer version, but at the moment, are you able to get Java11 for your environment?

I'm currently able to build using Java11.

Also, despite having quite a few features implemented for it (Display, YAMCS PVs, YAMCS Connections, etc), we have very little documentation at the moment unfortunately. So please feel free to ask any questions on this thread about how to use it if you do.

[jdiez17]

Thanks! I was able to build with Java 21 with the this patch. I was also able to test with my Yamcs instance and have a couple of points of feedback:

• It would be good to see the command arguments and command verifiers (queued, released, sent, + custom verifiers)
• It would also be really useful to load command history and PV history.
  • For PVs, perhaps we could implement an ArchiveReader that pulls data from Yamc's Parameter Archive.
  • This would make the Data Browser app very useful/powerful!
• I found connecting to Yamcs a bit confusing, I had to click around until I found the connection tab. It should also auto-connect when possible

[lorenzo-gomez-windhover]

Glad you were able to build it. Thanks a lot for the patch! Will be sure to integrate that eventually.

Thanks a lot for the feedback. We have only implemented the things that our team uses (Displaying PVs from multiple YAMCS instances on the same display being one of the the main ones), but we'll for sure keep this feedback in mind during the next dev cycle.

We've thought about the auto-connect at some point, but we weren't sure whether we should implement it or not. I'll consult with my team about it again based on your feedback....

The ArchiveReader would of course require more work than the auto-connect so I'll have to consult with my team again during the next dev cycle and see when/if we can scope it. But no promises for now about that.

Not sure if you read this. If you haven't, that is how you can view multiple PVs at the same time on the same display.

[jdiez17]

Thank you! We are not using multiple yamcs instances, but the ability to create plots “on demand” is interesting for us. I also like the more modern UI!

I’ll keep an eye on this repo and may submit some patches in the future (also no promises :)).