From 768f3ba32a3719070d1376341243e4cdf2383436 Mon Sep 17 00:00:00 2001 From: Vladimir Morozov Date: Sat, 29 Nov 2025 02:40:39 -0800 Subject: [PATCH 1/2] test: fix embedtest in debug windows PR-URL: https://github.com/nodejs/node/pull/60806 Reviewed-By: Chengzhong Wu --- test/embedding/embedtest.cc | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/test/embedding/embedtest.cc b/test/embedding/embedtest.cc index f0651ad8a85fc0..982eed74f9540b 100644 --- a/test/embedding/embedtest.cc +++ b/test/embedding/embedtest.cc @@ -210,23 +210,23 @@ int RunNodeInstance(MultiIsolatePlatform* platform, return 1; exit_code = node::SpinEventLoop(env).FromMaybe(1); - } - - if (!snapshot_blob_path.empty() && is_building_snapshot) { - snapshot = setup->CreateSnapshot(); - assert(snapshot); - FILE* fp = fopen(snapshot_blob_path.c_str(), "wb"); - assert(fp != nullptr); - if (snapshot_as_file) { - snapshot->ToFile(fp); - } else { - const std::vector vec = snapshot->ToBlob(); - size_t written = fwrite(vec.data(), vec.size(), 1, fp); - assert(written == 1); + if (!snapshot_blob_path.empty() && is_building_snapshot) { + snapshot = setup->CreateSnapshot(); + assert(snapshot); + + FILE* fp = fopen(snapshot_blob_path.c_str(), "wb"); + assert(fp != nullptr); + if (snapshot_as_file) { + snapshot->ToFile(fp); + } else { + const std::vector vec = snapshot->ToBlob(); + size_t written = fwrite(vec.data(), vec.size(), 1, fp); + assert(written == 1); + } + int ret = fclose(fp); + assert(ret == 0); } - int ret = fclose(fp); - assert(ret == 0); } node::Stop(env); From e42c6c899d85b279832a7b72c3229b779ca31633 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 29 Nov 2025 09:57:55 -0800 Subject: [PATCH 2/2] doc: correct spelling in BUILDING.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/60875 Reviewed-By: Stewart X Addison Reviewed-By: Richard Lau Reviewed-By: Filip Skokan Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca Reviewed-By: Ulises Gascón Reviewed-By: Colin Ihrig --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index 0413efd37cc9e7..2ffb3410ae5a2d 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -443,7 +443,7 @@ tools/test.py parallel/test-stream-* # The test/ prefix can be omitted tools/test.py "test/parallel/test-stream-*" ``` -The whildcard `*` can be used in any part of the path. For example, to run all tests +The wildcard `*` can be used in any part of the path. For example, to run all tests with a name that starts with `test-inspector-`, regardless of the directory they are in: ```bash