From 4a13a62cf4e9fe9d961c8fd3d2df4994e37471e7 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Mon, 9 Feb 2026 15:11:04 +0100 Subject: [PATCH 1/2] crypto: always return certificate serial numbers as uppercase MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This hides a discrepancy between OpenSSL and BoringSSL, as the latter returns lowercase hex values. Refs: https://github.com/nodejs/node/pull/61459#discussion_r2713110952 PR-URL: https://github.com/nodejs/node/pull/61752 Reviewed-By: Shelley Vohr Reviewed-By: Colin Ihrig Reviewed-By: Tim Perry Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca --- src/crypto/crypto_x509.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/crypto/crypto_x509.cc b/src/crypto/crypto_x509.cc index 11622d823bbc0a..f40f6dd4f2bcaf 100644 --- a/src/crypto/crypto_x509.cc +++ b/src/crypto/crypto_x509.cc @@ -253,8 +253,8 @@ MaybeLocal GetSignatureAlgorithmOID(Environment* env, MaybeLocal GetSerialNumber(Environment* env, const X509View& view) { if (auto serial = view.getSerialNumber()) { - return OneByteString(env->isolate(), - static_cast(serial.get())); + return ToV8Value( + env, ToUpper(std::string_view(static_cast(serial.get())))); } return Undefined(env->isolate()); } From 27ec4315b1fbd5873c812a5852e37f17e07c73e7 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Thu, 12 Feb 2026 11:59:34 +0100 Subject: [PATCH 2/2] tools: use ubuntu-slim runner in GHA PR-URL: https://github.com/nodejs/node/pull/61759 Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca --- .github/workflows/codeql.yml | 2 +- .github/workflows/daily-wpt-fyi.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 3a218ce40fa946..d29e734a82fd8c 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -10,7 +10,7 @@ permissions: jobs: analyze: name: Analyze - runs-on: ubuntu-latest + runs-on: ubuntu-slim permissions: actions: read contents: read diff --git a/.github/workflows/daily-wpt-fyi.yml b/.github/workflows/daily-wpt-fyi.yml index a575c89ec468b1..2b386e527a5951 100644 --- a/.github/workflows/daily-wpt-fyi.yml +++ b/.github/workflows/daily-wpt-fyi.yml @@ -21,7 +21,7 @@ permissions: jobs: collect-versions: if: github.repository == 'nodejs/node' || github.event_name == 'workflow_dispatch' - runs-on: ubuntu-latest + runs-on: ubuntu-slim outputs: matrix: ${{ steps.query.outputs.matrix }} steps: