From aaf7126429128f33d4cc989922f441c1a17360f3 Mon Sep 17 00:00:00 2001 From: Desmond Kyeremeh Date: Fri, 21 May 2021 17:00:26 +0000 Subject: [PATCH 1/2] Fixed error in calculating display width and height --- lib/apis/utils/device.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/apis/utils/device.js b/lib/apis/utils/device.js index 5a6ee89..7beeabc 100644 --- a/lib/apis/utils/device.js +++ b/lib/apis/utils/device.js @@ -5,10 +5,10 @@ import { class Device { static pixelRatio = PixelRatio.get(); - static dpWidth = Math.min(Dimensions.get("window").width, Dimensions.get("window").height); - static dpHeight = Math.max(Dimensions.get("window").width, Dimensions.get("window").height); - static pxWidth = Math.min(Dimensions.get("window").width, Dimensions.get("window").height) * PixelRatio.get(); - static pxHeight = Math.max(Dimensions.get("window").width, Dimensions.get("window").height) * PixelRatio.get(); + static dpWidth = Math.min(Dimensions.get("window").width, Dimensions.get("window").width); + static dpHeight = Math.max(Dimensions.get("window").height, Dimensions.get("window").height); + static pxWidth = Math.min(Dimensions.get("window").width, Dimensions.get("window").width) * PixelRatio.get(); + static pxHeight = Math.max(Dimensions.get("window").height, Dimensions.get("window").height) * PixelRatio.get(); static get physicalWidth() { return Device.pxWidth; From fe53e459bfc7b4d0fdd73240aeb5afc4b2e645a7 Mon Sep 17 00:00:00 2001 From: Desmond Kyeremeh Date: Fri, 21 May 2021 17:45:19 +0000 Subject: [PATCH 2/2] Extra fix --- lib/apis/utils/device.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/apis/utils/device.js b/lib/apis/utils/device.js index 7beeabc..19a14d1 100644 --- a/lib/apis/utils/device.js +++ b/lib/apis/utils/device.js @@ -6,8 +6,8 @@ import { class Device { static pixelRatio = PixelRatio.get(); static dpWidth = Math.min(Dimensions.get("window").width, Dimensions.get("window").width); - static dpHeight = Math.max(Dimensions.get("window").height, Dimensions.get("window").height); - static pxWidth = Math.min(Dimensions.get("window").width, Dimensions.get("window").width) * PixelRatio.get(); + static dpHeight = Math.min(Dimensions.get("window").height, Dimensions.get("window").height); + static pxWidth = Math.max(Dimensions.get("window").width, Dimensions.get("window").width) * PixelRatio.get(); static pxHeight = Math.max(Dimensions.get("window").height, Dimensions.get("window").height) * PixelRatio.get(); static get physicalWidth() {