diff --git a/src/main/java/org/prebid/server/bidder/boldwinrapid/BoldwinRapidBidder.java b/src/main/java/org/prebid/server/bidder/boldwinrapid/BoldwinRapidBidder.java new file mode 100644 index 00000000000..ca6da3a8653 --- /dev/null +++ b/src/main/java/org/prebid/server/bidder/boldwinrapid/BoldwinRapidBidder.java @@ -0,0 +1,140 @@ +package org.prebid.server.bidder.boldwinrapid; + +import com.fasterxml.jackson.core.type.TypeReference; +import com.iab.openrtb.request.BidRequest; +import com.iab.openrtb.request.Device; +import com.iab.openrtb.request.Imp; +import com.iab.openrtb.response.Bid; +import com.iab.openrtb.response.BidResponse; +import com.iab.openrtb.response.SeatBid; +import io.vertx.core.MultiMap; +import org.apache.commons.collections4.CollectionUtils; +import org.apache.commons.lang3.StringUtils; +import org.prebid.server.bidder.Bidder; +import org.prebid.server.bidder.model.BidderBid; +import org.prebid.server.bidder.model.BidderCall; +import org.prebid.server.bidder.model.BidderError; +import org.prebid.server.bidder.model.HttpRequest; +import org.prebid.server.bidder.model.Result; +import org.prebid.server.exception.PreBidException; +import org.prebid.server.json.DecodeException; +import org.prebid.server.json.JacksonMapper; +import org.prebid.server.proto.openrtb.ext.ExtPrebid; +import org.prebid.server.proto.openrtb.ext.request.boldwinrapid.ExtImpBoldwinRapid; +import org.prebid.server.proto.openrtb.ext.response.BidType; +import org.prebid.server.util.BidderUtil; +import org.prebid.server.util.HttpUtil; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.List; +import java.util.Objects; + +public class BoldwinRapidBidder implements Bidder { + + private static final TypeReference> BOLDWIN_EXT_TYPE_REFERENCE = + new TypeReference<>() { + }; + private static final String PUBLISHER_ID_MACRO = "{{PublisherID}}"; + private static final String PLACEMENT_ID_MACRO = "{{PlacementID}}"; + private static final String HOST_HEADER_VALUE = "rtb.beardfleet.com"; + + private final String endpointUrl; + private final JacksonMapper mapper; + + public BoldwinRapidBidder(String endpointUrl, JacksonMapper mapper) { + this.endpointUrl = HttpUtil.validateUrl(Objects.requireNonNull(endpointUrl)); + this.mapper = Objects.requireNonNull(mapper); + } + + @Override + public Result>> makeHttpRequests(BidRequest request) { + final List> httpRequests = new ArrayList<>(); + final List errors = new ArrayList<>(); + final MultiMap headers = makeHeaders(request.getDevice()); + + for (Imp imp : request.getImp()) { + try { + final ExtImpBoldwinRapid extImp = parseImpExt(imp); + final String resolvedEndpoint = resolveEndpoint(extImp); + final BidRequest outgoingRequest = request.toBuilder() + .imp(Collections.singletonList(imp)) + .build(); + + httpRequests.add(BidderUtil.defaultRequest(outgoingRequest, headers, resolvedEndpoint, mapper)); + } catch (PreBidException e) { + errors.add(BidderError.badInput(e.getMessage())); + } + } + + return Result.of(httpRequests, errors); + } + + private ExtImpBoldwinRapid parseImpExt(Imp imp) { + try { + return mapper.mapper().convertValue(imp.getExt(), BOLDWIN_EXT_TYPE_REFERENCE).getBidder(); + } catch (IllegalArgumentException e) { + throw new PreBidException("Error parsing imp.ext: " + e.getMessage()); + } + } + + private String resolveEndpoint(ExtImpBoldwinRapid extImp) { + return endpointUrl + .replace(PUBLISHER_ID_MACRO, HttpUtil.encodeUrl(StringUtils.defaultString(extImp.getPid()))) + .replace(PLACEMENT_ID_MACRO, HttpUtil.encodeUrl(StringUtils.defaultString(extImp.getTid()))); + } + + private static MultiMap makeHeaders(Device device) { + final MultiMap headers = HttpUtil.headers() + .set(HttpUtil.X_OPENRTB_VERSION_HEADER, "2.5") + .set("Host", HOST_HEADER_VALUE); + + if (device != null) { + HttpUtil.addHeaderIfValueIsNotEmpty(headers, HttpUtil.USER_AGENT_HEADER, device.getUa()); + HttpUtil.addHeaderIfValueIsNotEmpty(headers, HttpUtil.X_FORWARDED_FOR_HEADER, device.getIp()); + HttpUtil.addHeaderIfValueIsNotEmpty(headers, HttpUtil.X_FORWARDED_FOR_HEADER, device.getIpv6()); + HttpUtil.addHeaderIfValueIsNotEmpty(headers, "IP", device.getIp()); + } + + return headers; + } + + @Override + public Result> makeBids(BidderCall httpCall, BidRequest bidRequest) { + try { + final BidResponse bidResponse = mapper.decodeValue(httpCall.getResponse().getBody(), BidResponse.class); + return Result.withValues(extractBids(bidResponse)); + } catch (DecodeException | PreBidException e) { + return Result.withError(BidderError.badServerResponse(e.getMessage())); + } + } + + private static List extractBids(BidResponse bidResponse) { + if (bidResponse == null || CollectionUtils.isEmpty(bidResponse.getSeatbid())) { + return Collections.emptyList(); + } + return bidsFromResponse(bidResponse); + } + + private static List bidsFromResponse(BidResponse bidResponse) { + return bidResponse.getSeatbid().stream() + .filter(Objects::nonNull) + .map(SeatBid::getBid) + .filter(Objects::nonNull) + .flatMap(Collection::stream) + .filter(Objects::nonNull) + .map(bid -> BidderBid.of(bid, getBidType(bid), bidResponse.getCur())) + .toList(); + } + + private static BidType getBidType(Bid bid) { + return switch (bid.getMtype()) { + case 1 -> BidType.banner; + case 2 -> BidType.video; + case 4 -> BidType.xNative; + case null, default -> throw new PreBidException( + "Unable to fetch mediaType in multi-format: " + bid.getImpid()); + }; + } +} diff --git a/src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java b/src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java new file mode 100644 index 00000000000..ef333e4d95c --- /dev/null +++ b/src/main/java/org/prebid/server/bidder/nativery/NativeryBidder.java @@ -0,0 +1,246 @@ +package org.prebid.server.bidder.nativery; + +import com.fasterxml.jackson.core.type.TypeReference; +import com.fasterxml.jackson.databind.JsonNode; +import com.fasterxml.jackson.databind.node.ObjectNode; +import com.iab.openrtb.request.BidRequest; +import com.iab.openrtb.request.Imp; +import com.iab.openrtb.response.Bid; +import com.iab.openrtb.response.BidResponse; +import com.iab.openrtb.response.SeatBid; +import org.apache.commons.collections4.CollectionUtils; +import org.apache.commons.collections4.ListUtils; +import org.apache.commons.lang3.StringUtils; +import org.prebid.server.auction.model.Endpoint; +import org.prebid.server.bidder.Bidder; +import org.prebid.server.bidder.model.BidderBid; +import org.prebid.server.bidder.model.BidderCall; +import org.prebid.server.bidder.model.BidderError; +import org.prebid.server.bidder.model.HttpRequest; +import org.prebid.server.bidder.model.HttpResponse; +import org.prebid.server.bidder.model.Result; +import org.prebid.server.exception.PreBidException; +import org.prebid.server.json.DecodeException; +import org.prebid.server.json.JacksonMapper; +import org.prebid.server.proto.openrtb.ext.ExtPrebid; +import org.prebid.server.proto.openrtb.ext.request.ExtRequest; +import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebid; +import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebidServer; +import org.prebid.server.proto.openrtb.ext.request.nativery.BidExtNativery; +import org.prebid.server.proto.openrtb.ext.request.nativery.ExtImpNativery; +import org.prebid.server.proto.openrtb.ext.response.BidType; +import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebid; +import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebidMeta; +import org.prebid.server.util.BidderUtil; +import org.prebid.server.util.HttpUtil; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.List; +import java.util.Objects; +import java.util.Optional; + +public class NativeryBidder implements Bidder { + + private static final TypeReference> NATIVERY_EXT_TYPE_REFERENCE = + new TypeReference<>() { + }; + + private static final TypeReference> EXT_PREBID_TYPE_REFERENCE = + new TypeReference<>() { + }; + + private static final String DEFAULT_CURRENCY = "EUR"; + + private final String endpointUrl; + private final JacksonMapper mapper; + + public NativeryBidder(String endpointUrl, JacksonMapper mapper) { + this.endpointUrl = HttpUtil.validateUrl(Objects.requireNonNull(endpointUrl)); + this.mapper = Objects.requireNonNull(mapper); + } + + @Override + public Result>> makeHttpRequests(BidRequest request) { + final List> httpRequests = new ArrayList<>(); + final List errors = new ArrayList<>(); + + final String requestEndpointName = extractEndpointName(request); + final boolean isAmp = StringUtils.equals(requestEndpointName, Endpoint.openrtb2_amp.value()); + + final List validImps = new ArrayList<>(); + String widgetId = null; + + for (Imp imp : request.getImp()) { + try { + final ExtImpNativery extImp = parseImpExt(imp); + if (widgetId == null && StringUtils.isNotBlank(extImp.getWidgetId())) { + widgetId = extImp.getWidgetId(); + } + validImps.add(imp); + } catch (PreBidException e) { + errors.add(BidderError.badInput(e.getMessage())); + } + } + + if (validImps.isEmpty()) { + return Result.withErrors(errors); + } + + final ExtRequest updatedExt = buildRequestExtWithNativery(request.getExt(), isAmp, widgetId); + + for (Imp imp : validImps) { + final BidRequest singleImpRequest = request.toBuilder() + .imp(Collections.singletonList(imp)) + .ext(updatedExt) + .build(); + + httpRequests.add(BidderUtil.defaultRequest(singleImpRequest, endpointUrl, mapper)); + } + + return Result.of(httpRequests, errors); + } + + private static String extractEndpointName(BidRequest bidRequest) { + return Optional.ofNullable(bidRequest) + .map(BidRequest::getExt) + .map(ExtRequest::getPrebid) + .map(ExtRequestPrebid::getServer) + .map(ExtRequestPrebidServer::getEndpoint) + .orElse(null); + } + + private ExtImpNativery parseImpExt(Imp imp) { + try { + return mapper.mapper().convertValue(imp.getExt(), NATIVERY_EXT_TYPE_REFERENCE).getBidder(); + } catch (IllegalArgumentException e) { + throw new PreBidException("Failed to deserialize Nativery extension: " + e.getMessage()); + } + } + + private ExtRequest buildRequestExtWithNativery(ExtRequest originalExt, boolean isAmp, String widgetId) { + final ExtRequest ext = originalExt != null ? originalExt : ExtRequest.empty(); + + final JsonNode existing = ext.getProperty("nativery"); + final ObjectNode nativeryNode = existing != null && existing.isObject() + ? (ObjectNode) existing + : mapper.mapper().createObjectNode(); + + nativeryNode.put("isAmp", isAmp); + if (StringUtils.isNotBlank(widgetId)) { + nativeryNode.put("widgetId", widgetId); + } + + ext.addProperty("nativery", nativeryNode); + return ext; + } + + @Override + public Result> makeBids(BidderCall httpCall, BidRequest bidRequest) { + final List errors = new ArrayList<>(); + + final HttpResponse response = httpCall.getResponse(); + + try { + final BidResponse bidResponse = mapper.decodeValue(response.getBody(), BidResponse.class); + final List bidderBids = extractBids(bidResponse, errors); + return Result.of(bidderBids, errors); + } catch (DecodeException e) { + return Result.withError(BidderError.badServerResponse(e.getMessage())); + } + } + + private List extractBids(BidResponse bidResponse, List errors) { + if (bidResponse == null || CollectionUtils.isEmpty(bidResponse.getSeatbid())) { + return Collections.emptyList(); + } + + final String currency = StringUtils.defaultIfBlank(bidResponse.getCur(), DEFAULT_CURRENCY); + + return bidResponse.getSeatbid().stream() + .filter(Objects::nonNull) + .map(SeatBid::getBid) + .filter(Objects::nonNull) + .flatMap(Collection::stream) + .filter(Objects::nonNull) + .map(bid -> resolveBidderBid(bid, currency, errors)) + .filter(Objects::nonNull) + .toList(); + } + + private BidderBid resolveBidderBid(Bid bid, String currency, List errors) { + try { + final BidExtNativery nativeryExt = parseNativeryExt(bid.getExt()); + + final BidType bidType = mapMediaType(nativeryExt.getBidAdMediaType()); + final List advDomains = ListUtils.emptyIfNull( + nativeryExt.getBidAdvDomains()); + + final Bid updatedBid = addBidMeta(bid, bidType.getName(), advDomains); + return BidderBid.of(updatedBid, bidType, currency); + } catch (PreBidException e) { + errors.add(BidderError.badInput(e.getMessage())); + return null; + } + } + + private BidExtNativery parseNativeryExt(ObjectNode bidExt) { + return Optional.ofNullable(bidExt) + .map(ext -> ext.get("nativery")) + .filter(JsonNode::isObject) + .map(this::toBidExtNativery) + .orElseThrow(() -> new PreBidException("missing bid.ext.nativery")); + } + + private BidExtNativery toBidExtNativery(JsonNode node) { + try { + return mapper.mapper().convertValue(node, BidExtNativery.class); + } catch (IllegalArgumentException e) { + throw new PreBidException("invalid bid.ext.nativery: " + e.getMessage()); + } + } + + private static BidType mapMediaType(String mediaType) { + final String mt = StringUtils.defaultString(mediaType).toLowerCase(); + return switch (mt) { + case "native" -> BidType.xNative; + case "display", "banner", "rich_media" -> BidType.banner; + case "video" -> BidType.video; + default -> throw new PreBidException( + "unrecognized bid_ad_media_type in response from nativery: " + mediaType); + }; + } + + private Bid addBidMeta(Bid bid, String mediaType, List advDomains) { + final ExtBidPrebid prebid = parseExtBidPrebid(bid); + + final ExtBidPrebidMeta modifiedMeta = Optional.ofNullable(prebid) + .map(ExtBidPrebid::getMeta) + .map(ExtBidPrebidMeta::toBuilder) + .orElseGet(ExtBidPrebidMeta::builder) + .mediaType(mediaType) + .advertiserDomains(advDomains) + .build(); + + final ExtBidPrebid modifiedPrebid = Optional.ofNullable(prebid) + .map(ExtBidPrebid::toBuilder) + .orElseGet(ExtBidPrebid::builder) + .meta(modifiedMeta) + .build(); + + return bid.toBuilder() + .ext(mapper.mapper().valueToTree(ExtPrebid.of(modifiedPrebid, null))) + .build(); + } + + private ExtBidPrebid parseExtBidPrebid(Bid bid) { + try { + return mapper.mapper() + .convertValue(bid.getExt(), EXT_PREBID_TYPE_REFERENCE) + .getPrebid(); + } catch (IllegalArgumentException e) { + throw new PreBidException("Failed to deserialize Prebid extension: " + e.getMessage()); + } + } +} diff --git a/src/main/java/org/prebid/server/bidder/sparteo/SparteoBidder.java b/src/main/java/org/prebid/server/bidder/sparteo/SparteoBidder.java index 6beba78b3dc..42c12a48d1c 100644 --- a/src/main/java/org/prebid/server/bidder/sparteo/SparteoBidder.java +++ b/src/main/java/org/prebid/server/bidder/sparteo/SparteoBidder.java @@ -4,6 +4,7 @@ import com.fasterxml.jackson.core.type.TypeReference; import com.fasterxml.jackson.databind.JsonNode; import com.fasterxml.jackson.databind.node.ObjectNode; +import com.iab.openrtb.request.App; import com.iab.openrtb.request.BidRequest; import com.iab.openrtb.request.Imp; import com.iab.openrtb.request.Publisher; @@ -12,12 +13,14 @@ import com.iab.openrtb.response.BidResponse; import com.iab.openrtb.response.SeatBid; import org.apache.commons.collections4.CollectionUtils; +import org.apache.commons.lang3.StringUtils; import org.prebid.server.bidder.Bidder; import org.prebid.server.bidder.model.BidderBid; import org.prebid.server.bidder.model.BidderCall; import org.prebid.server.bidder.model.BidderError; import org.prebid.server.bidder.model.HttpRequest; import org.prebid.server.bidder.model.Result; +import org.prebid.server.bidder.sparteo.util.SparteoUtil; import org.prebid.server.exception.PreBidException; import org.prebid.server.json.DecodeException; import org.prebid.server.json.JacksonMapper; @@ -28,7 +31,9 @@ import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebid; import org.prebid.server.util.BidderUtil; import org.prebid.server.util.HttpUtil; +import org.apache.http.client.utils.URIBuilder; +import java.net.URISyntaxException; import java.util.ArrayList; import java.util.Collection; import java.util.Collections; @@ -38,6 +43,8 @@ public class SparteoBidder implements Bidder { + private static final String UNKNOWN_VALUE = "unknown"; + private static final TypeReference> TYPE_REFERENCE = new TypeReference<>() { }; @@ -53,19 +60,18 @@ public SparteoBidder(String endpointUrl, JacksonMapper mapper) { public Result>> makeHttpRequests(BidRequest request) { final List errors = new ArrayList<>(); final List modifiedImps = new ArrayList<>(); - String siteNetworkId = null; + String networkId = null; for (Imp imp : request.getImp()) { - if (siteNetworkId == null) { + if (networkId == null) { try { - siteNetworkId = parseExtImp(imp).getNetworkId(); + networkId = parseExtImp(imp).getNetworkId(); } catch (PreBidException e) { errors.add(BidderError.badInput( "ignoring imp id=%s, error processing ext: %s".formatted( imp.getId(), e.getMessage()))); } } - final ObjectNode modifiedExt = modifyImpExt(imp); modifiedImps.add(imp.toBuilder().ext(modifiedExt).build()); } @@ -74,12 +80,17 @@ public Result>> makeHttpRequests(BidRequest request return Result.withErrors(errors); } + final Site site = request.getSite(); + final App app = request.getApp(); + final BidRequest outgoingRequest = request.toBuilder() .imp(modifiedImps) - .site(modifySite(request.getSite(), siteNetworkId, mapper)) + .site(modifySite(site, networkId)) + .app(modifyApp(app, networkId)) .build(); - final HttpRequest call = BidderUtil.defaultRequest(outgoingRequest, endpointUrl, mapper); + final String finalEndpointUrl = replaceMacros(site, app, networkId, errors); + final HttpRequest call = BidderUtil.defaultRequest(outgoingRequest, finalEndpointUrl, mapper); return Result.of(Collections.singletonList(call), errors); } @@ -97,45 +108,138 @@ private static ObjectNode modifyImpExt(Imp imp) { final ObjectNode sparteoNode = modifiedImpExt.putObject("sparteo"); final JsonNode bidderJsonNode = modifiedImpExt.remove("bidder"); sparteoNode.set("params", bidderJsonNode); - return modifiedImpExt; } - private Site modifySite(Site site, String siteNetworkId, JacksonMapper mapper) { - if (site == null || site.getPublisher() == null || siteNetworkId == null) { + private Site modifySite(Site site, String networkId) { + if (site == null) { return site; } - final Publisher originalPublisher = site.getPublisher(); - final ExtPublisher originalExt = originalPublisher.getExt(); + final Publisher originalPublisher = site.getPublisher() != null + ? site.getPublisher() + : Publisher.builder().build(); + + final Publisher modifiedPublisher = modifyPublisher(originalPublisher, networkId); - final ExtPublisher modifiedExt = originalExt != null - ? ExtPublisher.of(originalExt.getPrebid()) - : ExtPublisher.empty(); + return site.toBuilder().publisher(modifiedPublisher).build(); + } - if (originalExt != null) { - mapper.fillExtension(modifiedExt, originalExt); + private App modifyApp(App app, String networkId) { + if (app == null) { + return app; } - final JsonNode paramsProperty = modifiedExt.getProperty("params"); - final ObjectNode paramsNode; + final Publisher originalPublisher = app.getPublisher() != null + ? app.getPublisher() + : Publisher.builder().build(); - if (paramsProperty != null && paramsProperty.isObject()) { - paramsNode = (ObjectNode) paramsProperty; - } else { - paramsNode = mapper.mapper().createObjectNode(); - modifiedExt.addProperty("params", paramsNode); - } + final Publisher modifiedPublisher = modifyPublisher(originalPublisher, networkId); + + return app.toBuilder().publisher(modifiedPublisher).build(); + } + + private Publisher modifyPublisher(Publisher originalPublisher, String networkId) { + final ExtPublisher originalExt = originalPublisher.getExt(); + final ExtPublisher modifiedExt = originalExt == null + ? ExtPublisher.empty() + : mapper.mapper().convertValue(originalExt, ExtPublisher.class); - paramsNode.put("networkId", siteNetworkId); + final ObjectNode paramsNode = ensureParamsNode(modifiedExt); + paramsNode.put("networkId", networkId); - final Publisher modifiedPublisher = originalPublisher.toBuilder() + return originalPublisher.toBuilder() .ext(modifiedExt) .build(); + } - return site.toBuilder() - .publisher(modifiedPublisher) - .build(); + private ObjectNode ensureParamsNode(ExtPublisher extPublisher) { + final JsonNode paramsProperty = extPublisher.getProperty("params"); + if (paramsProperty != null && paramsProperty.isObject()) { + return (ObjectNode) paramsProperty; + } + final ObjectNode paramsNode = mapper.mapper().createObjectNode(); + extPublisher.addProperty("params", paramsNode); + + return paramsNode; + } + + private String replaceMacros(Site site, App app, String networkId, List errors) { + final String siteDomain = resolveSiteDomain(site); + final String appDomain = resolveAppDomain(app); + final String bundle = resolveBundle(app); + + if (UNKNOWN_VALUE.equals(siteDomain)) { + errors.add(BidderError.badInput( + "Domain not found. Missing the site.domain or the site.page field")); + } + + if (UNKNOWN_VALUE.equals(bundle)) { + errors.add(BidderError.badInput( + "Bundle not found. Missing the app.bundle field.")); + } + + return resolveEndpoint(siteDomain, appDomain, networkId, bundle); + } + + private String resolveSiteDomain(Site site) { + if (site == null) { + return null; + } + + return Optional.of(site) + .map(Site::getDomain) + .map(SparteoUtil::normalizeHostname) + .filter(StringUtils::isNotEmpty) + .or(() -> Optional.ofNullable(site.getPage()) + .map(SparteoUtil::normalizeHostname) + .filter(StringUtils::isNotEmpty)) + .orElse(UNKNOWN_VALUE); + } + + private String resolveAppDomain(App app) { + if (app == null) { + return null; + } + + return Optional.of(app) + .map(App::getDomain) + .map(SparteoUtil::normalizeHostname) + .filter(StringUtils::isNotEmpty) + .orElse(UNKNOWN_VALUE); + } + + private String resolveBundle(App app) { + if (app == null) { + return null; + } + + return Optional.ofNullable(app.getBundle()) + .filter(StringUtils::isNotBlank) + .map(String::trim) + .filter(bundle -> !"null".equalsIgnoreCase(bundle)) + .orElse(UNKNOWN_VALUE); + } + + private String resolveEndpoint(String siteDomain, String appDomain, String networkId, String bundle) { + try { + final URIBuilder uriBuilder = new URIBuilder(endpointUrl); + if (StringUtils.isNotBlank(networkId)) { + uriBuilder.addParameter("network_id", networkId); + } + if (StringUtils.isNotBlank(siteDomain)) { + uriBuilder.addParameter("site_domain", siteDomain); + } + if (StringUtils.isNotBlank(appDomain)) { + uriBuilder.addParameter("app_domain", appDomain); + } + if (StringUtils.isNotBlank(bundle)) { + uriBuilder.addParameter("bundle", bundle); + } + return uriBuilder.build().toString(); + } catch (URISyntaxException e) { + throw new PreBidException("Failed to build endpoint URL", e); + } } @Override diff --git a/src/main/java/org/prebid/server/bidder/sparteo/util/SparteoUtil.java b/src/main/java/org/prebid/server/bidder/sparteo/util/SparteoUtil.java new file mode 100644 index 00000000000..bcb098f687d --- /dev/null +++ b/src/main/java/org/prebid/server/bidder/sparteo/util/SparteoUtil.java @@ -0,0 +1,41 @@ +package org.prebid.server.bidder.sparteo.util; + +import org.apache.commons.lang3.StringUtils; + +import java.net.URI; +import java.net.URISyntaxException; + +public final class SparteoUtil { + + private SparteoUtil() { + } + + public static String normalizeHostname(String host) { + String h = StringUtils.trimToEmpty(host); + if (h.isEmpty()) { + return ""; + } + + String hostname = null; + try { + hostname = new URI(h).getHost(); + } catch (URISyntaxException e) { + } + + if (StringUtils.isNotEmpty(hostname)) { + h = hostname; + } else { + if (h.contains(":")) { + h = StringUtils.substringBefore(h, ":"); + } else { + h = StringUtils.substringBefore(h, "/"); + } + } + + h = h.toLowerCase(); + h = StringUtils.removeStart(h, "www."); + h = StringUtils.removeEnd(h, "."); + + return "null".equals(h) ? "" : h; + } +} diff --git a/src/main/java/org/prebid/server/proto/openrtb/ext/request/boldwinrapid/ExtImpBoldwinRapid.java b/src/main/java/org/prebid/server/proto/openrtb/ext/request/boldwinrapid/ExtImpBoldwinRapid.java new file mode 100644 index 00000000000..a546a4bd8bb --- /dev/null +++ b/src/main/java/org/prebid/server/proto/openrtb/ext/request/boldwinrapid/ExtImpBoldwinRapid.java @@ -0,0 +1,11 @@ +package org.prebid.server.proto.openrtb.ext.request.boldwinrapid; + +import lombok.Value; + +@Value(staticConstructor = "of") +public class ExtImpBoldwinRapid { + + String pid; + + String tid; +} diff --git a/src/main/java/org/prebid/server/proto/openrtb/ext/request/nativery/BidExtNativery.java b/src/main/java/org/prebid/server/proto/openrtb/ext/request/nativery/BidExtNativery.java new file mode 100644 index 00000000000..3c7ee391327 --- /dev/null +++ b/src/main/java/org/prebid/server/proto/openrtb/ext/request/nativery/BidExtNativery.java @@ -0,0 +1,13 @@ +package org.prebid.server.proto.openrtb.ext.request.nativery; + +import lombok.Value; + +import java.util.List; + +@Value(staticConstructor = "of") +public class BidExtNativery { + + String bidAdMediaType; + + List bidAdvDomains; +} diff --git a/src/main/java/org/prebid/server/proto/openrtb/ext/request/nativery/ExtImpNativery.java b/src/main/java/org/prebid/server/proto/openrtb/ext/request/nativery/ExtImpNativery.java new file mode 100644 index 00000000000..cd1554111e0 --- /dev/null +++ b/src/main/java/org/prebid/server/proto/openrtb/ext/request/nativery/ExtImpNativery.java @@ -0,0 +1,11 @@ +package org.prebid.server.proto.openrtb.ext.request.nativery; + +import com.fasterxml.jackson.annotation.JsonProperty; +import lombok.Value; + +@Value(staticConstructor = "of") +public class ExtImpNativery { + + @JsonProperty("widgetId") + String widgetId; +} diff --git a/src/main/java/org/prebid/server/spring/config/bidder/BoldwinRapidConfiguration.java b/src/main/java/org/prebid/server/spring/config/bidder/BoldwinRapidConfiguration.java new file mode 100644 index 00000000000..be498585d72 --- /dev/null +++ b/src/main/java/org/prebid/server/spring/config/bidder/BoldwinRapidConfiguration.java @@ -0,0 +1,41 @@ +package org.prebid.server.spring.config.bidder; + +import org.prebid.server.bidder.BidderDeps; +import org.prebid.server.bidder.boldwinrapid.BoldwinRapidBidder; +import org.prebid.server.json.JacksonMapper; +import org.prebid.server.spring.config.bidder.model.BidderConfigurationProperties; +import org.prebid.server.spring.config.bidder.util.BidderDepsAssembler; +import org.prebid.server.spring.config.bidder.util.UsersyncerCreator; +import org.prebid.server.spring.env.YamlPropertySourceFactory; +import org.springframework.beans.factory.annotation.Value; +import org.springframework.boot.context.properties.ConfigurationProperties; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; +import org.springframework.context.annotation.PropertySource; + +import jakarta.validation.constraints.NotBlank; + +@Configuration +@PropertySource(value = "classpath:/bidder-config/boldwinrapid.yaml", factory = YamlPropertySourceFactory.class) +public class BoldwinRapidConfiguration { + + private static final String BIDDER_NAME = "boldwin_rapid"; + + @Bean("boldwinRapidConfigurationProperties") + @ConfigurationProperties("adapters.boldwinrapid") + BidderConfigurationProperties configurationProperties() { + return new BidderConfigurationProperties(); + } + + @Bean + BidderDeps boldwinrapidBidderDeps(BidderConfigurationProperties boldwinRapidConfigurationProperties, + @NotBlank @Value("${external-url}") String externalUrl, + JacksonMapper mapper) { + + return BidderDepsAssembler.forBidder(BIDDER_NAME) + .withConfig(boldwinRapidConfigurationProperties) + .usersyncerCreator(UsersyncerCreator.create(externalUrl)) + .bidderCreator(config -> new BoldwinRapidBidder(config.getEndpoint(), mapper)) + .assemble(); + } +} diff --git a/src/main/java/org/prebid/server/spring/config/bidder/NativeryBidderConfiguration.java b/src/main/java/org/prebid/server/spring/config/bidder/NativeryBidderConfiguration.java new file mode 100644 index 00000000000..0dc07f48e94 --- /dev/null +++ b/src/main/java/org/prebid/server/spring/config/bidder/NativeryBidderConfiguration.java @@ -0,0 +1,41 @@ +package org.prebid.server.spring.config.bidder; + +import org.prebid.server.bidder.BidderDeps; +import org.prebid.server.bidder.nativery.NativeryBidder; +import org.prebid.server.json.JacksonMapper; +import org.prebid.server.spring.config.bidder.model.BidderConfigurationProperties; +import org.prebid.server.spring.config.bidder.util.BidderDepsAssembler; +import org.prebid.server.spring.config.bidder.util.UsersyncerCreator; +import org.prebid.server.spring.env.YamlPropertySourceFactory; +import org.springframework.beans.factory.annotation.Value; +import org.springframework.boot.context.properties.ConfigurationProperties; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; +import org.springframework.context.annotation.PropertySource; + +import jakarta.validation.constraints.NotBlank; + +@Configuration +@PropertySource(value = "classpath:/bidder-config/nativery.yaml", factory = YamlPropertySourceFactory.class) +public class NativeryBidderConfiguration { + + private static final String BIDDER_NAME = "nativery"; + + @Bean("nativeryConfigurationProperties") + @ConfigurationProperties("adapters.nativery") + BidderConfigurationProperties configurationProperties() { + return new BidderConfigurationProperties(); + } + + @Bean + BidderDeps nativeryBidderDeps(BidderConfigurationProperties nativeryConfigurationProperties, + @NotBlank @Value("${external-url}") String externalUrl, + JacksonMapper mapper) { + + return BidderDepsAssembler.forBidder(BIDDER_NAME) + .withConfig(nativeryConfigurationProperties) + .usersyncerCreator(UsersyncerCreator.create(externalUrl)) + .bidderCreator(config -> new NativeryBidder(config.getEndpoint(), mapper)) + .assemble(); + } +} diff --git a/src/main/resources/bidder-config/boldwinrapid.yaml b/src/main/resources/bidder-config/boldwinrapid.yaml new file mode 100644 index 00000000000..f9b40571ea5 --- /dev/null +++ b/src/main/resources/bidder-config/boldwinrapid.yaml @@ -0,0 +1,11 @@ +adapters: + boldwin_rapid: + endpoint: https://rtb.beardfleet.com/auction/bid?pid={{PublisherID}}&tid={{PlacementID}} + meta-info: + maintainer-email: info@bold-win.com + app-media-types: + - banner + - video + - native + supported-vendors: + vendor-id: 0 diff --git a/src/main/resources/bidder-config/nativery.yaml b/src/main/resources/bidder-config/nativery.yaml new file mode 100644 index 00000000000..e37bc8dcd4d --- /dev/null +++ b/src/main/resources/bidder-config/nativery.yaml @@ -0,0 +1,12 @@ +adapters: + nativery: + endpoint: "https://hb.nativery.com/openrtb2/auction" + ortb-version: "2.6" + meta-info: + maintainer-email: "developer@nativery.com" + site-media-types: + - banner + - video + - native + supported-vendors: + vendor-id: 1133 diff --git a/src/main/resources/bidder-config/sparteo.yaml b/src/main/resources/bidder-config/sparteo.yaml index 44cbe16bd86..5dd9dd19b1d 100644 --- a/src/main/resources/bidder-config/sparteo.yaml +++ b/src/main/resources/bidder-config/sparteo.yaml @@ -16,5 +16,5 @@ adapters: usersync: cookie-family-name: sparteo iframe: - url: "https://sync.sparteo.com/s2s_sync?gdpr={{gdpr}}&gdpr_consent={{gdpr_consent}}&us_privacy={{us_privacy}}&redirect_url={{redirect_url}}" + url: "https://sync.sparteo.com/s2s_sync?gdpr={{gdpr}}&gdpr_consent={{gdpr_consent}}&us_privacy={{us_privacy}}&gpp={{gpp}}&&gpp_sid={{gpp_sid}}&redirect_url={{redirect_url}}" support-cors: true diff --git a/src/main/resources/static/bidder-params/boldwin_rapid.json b/src/main/resources/static/bidder-params/boldwin_rapid.json new file mode 100644 index 00000000000..b9b83340b19 --- /dev/null +++ b/src/main/resources/static/bidder-params/boldwin_rapid.json @@ -0,0 +1,22 @@ +{ + "$schema": "http://json-schema.org/draft-04/schema#", + "title": "Boldwin-Rapid Adapter Params", + "description": "A schema which validates params accepted by the Boldwin-rapid adapter", + "type": "object", + "properties": { + "pid": { + "type": "string", + "minLength": 1, + "description": "Publisher ID" + }, + "tid": { + "type": "string", + "minLength": 1, + "description": "Placement ID" + } + }, + "required": [ + "pid", + "tid" + ] +} diff --git a/src/main/resources/static/bidder-params/nativery.json b/src/main/resources/static/bidder-params/nativery.json new file mode 100644 index 00000000000..9f8dc02c274 --- /dev/null +++ b/src/main/resources/static/bidder-params/nativery.json @@ -0,0 +1,15 @@ +{ + "$schema": "http://json-schema.org/draft-04/schema#", + "title": "Nativery Adapter Params", + "description": "A schema which validates params accepted by the Nativery adapter", + + "type": "object", + "properties": { + "widgetId": { + "type": "string", + "description": "An ID which identifies this Nativery widget" + } + }, + + "required": ["widgetId"] +} diff --git a/src/test/java/org/prebid/server/bidder/boldwinrapid/BoldwinRapidBidderTest.java b/src/test/java/org/prebid/server/bidder/boldwinrapid/BoldwinRapidBidderTest.java new file mode 100644 index 00000000000..511c7cb6697 --- /dev/null +++ b/src/test/java/org/prebid/server/bidder/boldwinrapid/BoldwinRapidBidderTest.java @@ -0,0 +1,310 @@ +package org.prebid.server.bidder.boldwinrapid; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.node.ObjectNode; +import com.iab.openrtb.request.BidRequest; +import com.iab.openrtb.request.Device; +import com.iab.openrtb.request.Imp; +import com.iab.openrtb.response.Bid; +import com.iab.openrtb.response.BidResponse; +import com.iab.openrtb.response.SeatBid; +import org.junit.jupiter.api.Test; +import org.prebid.server.VertxTest; +import org.prebid.server.bidder.model.BidderBid; +import org.prebid.server.bidder.model.BidderCall; +import org.prebid.server.bidder.model.BidderError; +import org.prebid.server.bidder.model.HttpRequest; +import org.prebid.server.bidder.model.HttpResponse; +import org.prebid.server.bidder.model.Result; +import org.prebid.server.proto.openrtb.ext.ExtPrebid; +import org.prebid.server.proto.openrtb.ext.request.boldwinrapid.ExtImpBoldwinRapid; +import org.prebid.server.proto.openrtb.ext.response.BidType; + +import java.math.BigDecimal; +import java.util.Arrays; +import java.util.List; +import java.util.function.UnaryOperator; + +import static java.util.Collections.singletonList; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException; +import static org.prebid.server.bidder.model.BidderError.badServerResponse; +import static org.prebid.server.util.HttpUtil.ACCEPT_HEADER; +import static org.prebid.server.util.HttpUtil.APPLICATION_JSON_CONTENT_TYPE; +import static org.prebid.server.util.HttpUtil.CONTENT_TYPE_HEADER; +import static org.prebid.server.util.HttpUtil.USER_AGENT_HEADER; +import static org.prebid.server.util.HttpUtil.X_FORWARDED_FOR_HEADER; +import static org.prebid.server.util.HttpUtil.X_OPENRTB_VERSION_HEADER; +import static org.springframework.util.MimeTypeUtils.APPLICATION_JSON_VALUE; + +public class BoldwinRapidBidderTest extends VertxTest { + + private static final String ENDPOINT_URL = "https://test.endpoint.com/?pub={{PublisherID}}&place={{PlacementID}}"; + + private final BoldwinRapidBidder target = new BoldwinRapidBidder(ENDPOINT_URL, jacksonMapper); + + @Test + public void creationShouldFailOnInvalidEndpointUrl() { + assertThatIllegalArgumentException().isThrownBy(() -> new BoldwinRapidBidder("invalid_url", jacksonMapper)); + } + + @Test + public void makeHttpRequestsShouldReturnErrorIfImpExtCouldNotBeParsed() { + // given + final BidRequest bidRequest = givenBidRequest( + imp -> imp.ext(mapper.valueToTree(ExtPrebid.of(null, mapper.createArrayNode())))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).hasSize(1) + .allSatisfy(error -> { + assertThat(error.getType()).isEqualTo(BidderError.Type.bad_input); + assertThat(error.getMessage()).startsWith("Error parsing imp.ext:"); + }); + assertThat(result.getValue()).isEmpty(); + } + + @Test + public void makeHttpRequestsShouldCreateSeparateRequestForEachImp() { + // given + final BidRequest bidRequest = givenBidRequest( + imp -> imp.id("imp1").ext(givenImpExt("p1", "t1")), + imp -> imp.id("imp2").ext(givenImpExt("p2", "t2"))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(2) + .extracting(HttpRequest::getPayload) + .flatExtracting(BidRequest::getImp) + .extracting(Imp::getId) + .containsExactly("imp1", "imp2"); + } + + @Test + public void makeHttpRequestsShouldResolveEndpointMacrosCorrectly() { + // given + final BidRequest bidRequest = givenBidRequest( + imp -> imp.ext(givenImpExt("pub123", "place456"))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1) + .extracting(HttpRequest::getUri) + .containsExactly("https://test.endpoint.com/?pub=pub123&place=place456"); + } + + @Test + public void makeHttpRequestsShouldSetCorrectHeaders() { + // given + final BidRequest bidRequest = givenBidRequest(imp -> imp.ext(givenImpExt("p", "t"))) + .toBuilder() + .device(Device.builder() + .ua("ua") + .ip("ip") + .ipv6("ipv6") + .build()) + .build(); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1).first() + .extracting(HttpRequest::getHeaders) + .satisfies(headers -> { + assertThat(headers.get(CONTENT_TYPE_HEADER)).isEqualTo(APPLICATION_JSON_CONTENT_TYPE); + assertThat(headers.get(ACCEPT_HEADER)).isEqualTo(APPLICATION_JSON_VALUE); + assertThat(headers.get(X_OPENRTB_VERSION_HEADER)).isEqualTo("2.5"); + assertThat(headers.get("Host")).isEqualTo("rtb.beardfleet.com"); + assertThat(headers.get(USER_AGENT_HEADER)).isEqualTo("ua"); + assertThat(headers.get(X_FORWARDED_FOR_HEADER)).isEqualTo("ip"); + assertThat(headers.get("IP")).isEqualTo("ip"); + }); + } + + @Test + public void makeHttpRequestsShouldSetCorrectIpv6XForwardedForHeaderWhenDeviceIpIsAbsent() { + // given + final BidRequest bidRequest = givenBidRequest(imp -> imp.ext(givenImpExt("p", "t"))) + .toBuilder() + .device(Device.builder() + .ua("ua") + .ipv6("ipv6") + .build()) + .build(); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1).first() + .extracting(HttpRequest::getHeaders) + .satisfies(headers -> { + assertThat(headers.get(CONTENT_TYPE_HEADER)).isEqualTo(APPLICATION_JSON_CONTENT_TYPE); + assertThat(headers.get(ACCEPT_HEADER)).isEqualTo(APPLICATION_JSON_VALUE); + assertThat(headers.get(X_OPENRTB_VERSION_HEADER)).isEqualTo("2.5"); + assertThat(headers.get("Host")).isEqualTo("rtb.beardfleet.com"); + assertThat(headers.get(USER_AGENT_HEADER)).isEqualTo("ua"); + assertThat(headers.get(X_FORWARDED_FOR_HEADER)).isEqualTo("ipv6"); + }); + } + + @Test + public void makeBidsShouldReturnErrorWhenResponseBodyCouldNotBeParsed() { + // given + final BidderCall httpCall = givenHttpCall("invalid_json"); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).hasSize(1) + .allSatisfy(error -> { + assertThat(error.getType()).isEqualTo(BidderError.Type.bad_server_response); + assertThat(error.getMessage()).startsWith("Failed to decode: Unrecognized token 'invalid_json'"); + }); + assertThat(result.getValue()).isEmpty(); + } + + @Test + public void makeBidsShouldReturnEmptyListWhenBidResponseIsNull() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall(mapper.writeValueAsString(null)); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).isEmpty(); + } + + @Test + public void makeBidsShouldReturnEmptyListWhenSeatBidIsEmpty() throws JsonProcessingException { + // given + final BidResponse bidResponse = BidResponse.builder().seatbid(null).build(); + final BidderCall httpCall = givenHttpCall(mapper.writeValueAsString(bidResponse)); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).isEmpty(); + } + + @Test + public void makeBidsShouldReturnBannerBid() throws JsonProcessingException { + // given + final Bid bannerBid = givenBid(1); + final BidderCall httpCall = givenHttpCall(givenBidResponse(bannerBid)); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).containsExactly(BidderBid.of(bannerBid, BidType.banner, "USD")); + } + + @Test + public void makeBidsShouldReturnVideoBid() throws JsonProcessingException { + // given + final Bid videoBid = givenBid(2); + final BidderCall httpCall = givenHttpCall(givenBidResponse(videoBid)); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).containsExactly(BidderBid.of(videoBid, BidType.video, "USD")); + } + + @Test + public void makeBidsShouldReturnNativeBid() throws JsonProcessingException { + // given + final Bid nativeBid = givenBid(4); + final BidderCall httpCall = givenHttpCall(givenBidResponse(nativeBid)); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).containsExactly(BidderBid.of(nativeBid, BidType.xNative, "USD")); + } + + @Test + public void makeBidsShouldReturnErrorWhenMtypeIsMissing() throws JsonProcessingException { + // given + final Bid invalidBid = givenBid(null); + final BidderCall httpCall = givenHttpCall(givenBidResponse(invalidBid)); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()).hasSize(1) + .containsExactly(badServerResponse("Unable to fetch mediaType in multi-format: impId")); + } + + @Test + public void makeBidsShouldReturnErrorWhenMtypeIsUnsupported() throws JsonProcessingException { + // given + final Bid invalidBid = givenBid(3); + final BidderCall httpCall = givenHttpCall(givenBidResponse(invalidBid)); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()).hasSize(1) + .containsExactly(badServerResponse("Unable to fetch mediaType in multi-format: impId")); + } + + private static BidRequest givenBidRequest(UnaryOperator... impCustomizers) { + final List imps = Arrays.stream(impCustomizers) + .map(BoldwinRapidBidderTest::givenImp) + .toList(); + return BidRequest.builder().imp(imps).build(); + } + + private static Imp givenImp(UnaryOperator impCustomizer) { + return impCustomizer.apply(Imp.builder().id("impId")).build(); + } + + private static ObjectNode givenImpExt(String pid, String tid) { + return mapper.valueToTree(ExtPrebid.of(null, ExtImpBoldwinRapid.of(pid, tid))); + } + + private static Bid givenBid(Integer mtype) { + return Bid.builder().id("bidId").impid("impId").price(BigDecimal.ONE).mtype(mtype).build(); + } + + private static String givenBidResponse(Bid... bids) throws JsonProcessingException { + return mapper.writeValueAsString(BidResponse.builder() + .cur("USD") + .seatbid(singletonList(SeatBid.builder().bid(List.of(bids)).build())) + .build()); + } + + private static BidderCall givenHttpCall(String body) { + return BidderCall.succeededHttp( + HttpRequest.builder().build(), + HttpResponse.of(200, null, body), + null); + } +} diff --git a/src/test/java/org/prebid/server/bidder/nativery/NativeryBidderTest.java b/src/test/java/org/prebid/server/bidder/nativery/NativeryBidderTest.java new file mode 100644 index 00000000000..ffc0a8a1d9f --- /dev/null +++ b/src/test/java/org/prebid/server/bidder/nativery/NativeryBidderTest.java @@ -0,0 +1,529 @@ +package org.prebid.server.bidder.nativery; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.JsonNode; +import com.fasterxml.jackson.databind.node.TextNode; +import com.iab.openrtb.request.BidRequest; +import com.iab.openrtb.request.Imp; +import com.iab.openrtb.response.Bid; +import com.iab.openrtb.response.BidResponse; +import com.iab.openrtb.response.SeatBid; +import org.junit.jupiter.api.Test; +import org.prebid.server.VertxTest; +import org.prebid.server.auction.model.Endpoint; +import org.prebid.server.bidder.model.BidderBid; +import org.prebid.server.bidder.model.BidderCall; +import org.prebid.server.bidder.model.BidderError; +import org.prebid.server.bidder.model.HttpRequest; +import org.prebid.server.bidder.model.HttpResponse; +import org.prebid.server.bidder.model.Result; +import org.prebid.server.proto.openrtb.ext.ExtPrebid; +import org.prebid.server.proto.openrtb.ext.request.ExtRequest; +import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebid; +import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebidServer; +import org.prebid.server.proto.openrtb.ext.request.nativery.ExtImpNativery; +import org.prebid.server.proto.openrtb.ext.response.BidType; +import org.prebid.server.proto.openrtb.ext.response.ExtBidPrebid; + +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.function.UnaryOperator; + +import static java.util.Arrays.asList; +import static java.util.Collections.singletonList; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException; +import static org.prebid.server.proto.openrtb.ext.response.BidType.audio; +import static org.prebid.server.proto.openrtb.ext.response.BidType.banner; +import static org.prebid.server.util.HttpUtil.ACCEPT_HEADER; +import static org.prebid.server.util.HttpUtil.APPLICATION_JSON_CONTENT_TYPE; +import static org.prebid.server.util.HttpUtil.CONTENT_TYPE_HEADER; +import static org.springframework.util.MimeTypeUtils.APPLICATION_JSON_VALUE; + +public class NativeryBidderTest extends VertxTest { + + private static final String ENDPOINT_URL = "https://test.com/test"; + private static final String DEFAULT_CURRENCY = "EUR"; + + private final NativeryBidder target = new NativeryBidder(ENDPOINT_URL, jacksonMapper); + + @Test + public void creationShouldFailOnInvalidEndpointUrl() { + assertThatIllegalArgumentException().isThrownBy(() -> new NativeryBidder("invalid_url", jacksonMapper)); + } + + @Test + public void makeHttpRequestsShouldMakeOneRequestPerImp() { + // given + final BidRequest bidRequest = BidRequest.builder() + .imp(asList( + givenImp(UnaryOperator.identity()), + givenImp(imp -> imp.id("321").ext(mapper.valueToTree(ExtPrebid + .of(null, ExtImpNativery.of("widget2"))))))) + .build(); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(2) + .extracting(HttpRequest::getPayload) + .extracting(BidRequest::getImp) + .extracting(List::size) + .containsOnly(1); + assertThat(result.getValue()) + .extracting(HttpRequest::getPayload) + .flatExtracting(BidRequest::getImp) + .extracting(Imp::getId) + .containsExactlyInAnyOrder("123", "321"); + assertThat(result.getValue()).hasSize(2) + .extracting(HttpRequest::getImpIds) + .containsExactly(Set.of("123"), Set.of("321")); + } + + @Test + public void makeHttpRequestsShouldUseCorrectUri() { + // given + final BidRequest bidRequest = givenBidRequest(UnaryOperator.identity()); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .extracting(HttpRequest::getUri) + .containsExactly(ENDPOINT_URL); + } + + @Test + public void makeHttpRequestsShouldSetExtWithWidgetId() { + // given + final BidRequest bidRequest = givenBidRequest(UnaryOperator.identity()); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .extracting(HttpRequest::getPayload) + .extracting(BidRequest::getExt) + .extracting(ext -> ext.getProperty("nativery").path("widgetId").asText()) + .containsOnly("widget1"); + } + + @Test + public void makeHttpRequestsShouldPreserveOriginalExtFields() { + // given + final ExtRequest extRequest = ExtRequest.empty(); + extRequest.addProperty("accountId", TextNode.valueOf("acc-123")); + final BidRequest bidRequest = givenBidRequest( + requestBuilder -> requestBuilder.ext(extRequest), + UnaryOperator.identity()); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + + final ExtRequest resultingExt = result.getValue().get(0).getPayload().getExt(); + + assertThat(resultingExt.getProperty("accountId").asText()).isEqualTo("acc-123"); + assertThat(resultingExt.getProperty("nativery").path("widgetId").asText()).isEqualTo("widget1"); + } + + @Test + public void makeHttpRequestsShouldSetExtWithAmpTrue() { + // given + final ExtRequestPrebidServer server = ExtRequestPrebidServer.of( + null, null, null, Endpoint.openrtb2_amp.value()); + final ExtRequestPrebid prebid = ExtRequestPrebid.builder() + .server(server) + .build(); + + final ExtRequest extRequest = ExtRequest.of(prebid); + + final BidRequest bidRequest = givenBidRequest( + requestBuilder -> requestBuilder.ext(extRequest), + UnaryOperator.identity()); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .extracting(HttpRequest::getPayload) + .extracting(BidRequest::getExt) + .extracting(ext -> ext.getProperty("nativery").path("isAmp").asBoolean()) + .containsOnly(true); + } + + @Test + public void makeHttpRequestsShouldReturnErrorIfImpExtCannotBeParsed() { + // given + final BidRequest bidRequest = givenBidRequest(impBuilder -> + impBuilder.ext(mapper.createObjectNode().set("bidder", mapper.createArrayNode()))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()) + .hasSize(1) + .allSatisfy(error -> { + assertThat(error.getMessage()) + .startsWith("Failed to deserialize Nativery extension:"); + assertThat(error.getType()).isEqualTo(BidderError.Type.bad_input); + }); + assertThat(result.getValue()).isEmpty(); + } + + @Test + public void makeHttpRequestsShouldReturnExpectedHeaders() { + // given + final BidRequest bidRequest = givenBidRequest(UnaryOperator.identity()); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getValue()).hasSize(1).first() + .extracting(HttpRequest::getHeaders) + .satisfies(headers -> assertThat(headers.get(CONTENT_TYPE_HEADER)) + .isEqualTo(APPLICATION_JSON_CONTENT_TYPE)) + .satisfies(headers -> assertThat(headers.get(ACCEPT_HEADER)) + .isEqualTo(APPLICATION_JSON_VALUE)); + assertThat(result.getErrors()).isEmpty(); + } + + @Test + public void makeBidsShouldReturnEmptyListIfBidResponseIsNull() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall(mapper.writeValueAsString(null)); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).isEmpty(); + } + + @Test + public void makeBidsShouldReturnErrorIfResponseBodyCouldNotBeParsed() { + // given + final BidderCall httpCall = givenHttpCall("invalid"); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()).hasSize(1) + .allSatisfy(error -> { + assertThat(error.getMessage()).startsWith("Failed to decode:"); + assertThat(error.getType()).isEqualTo(BidderError.Type.bad_server_response); + }); + } + + @Test + public void makeBidsShouldReturnEmptyListIfBidResponseSeatBidIsNull() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + mapper.writeValueAsString(BidResponse.builder().build())); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).isEmpty(); + } + + @Test + public void makeBidsShouldReturnBannerBid() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + givenBidResponse(bidBuilder -> bidBuilder + .impid("123") + .ext(mapper.valueToTree(Map.of( + "nativery", Map.of("bid_ad_media_type", "banner")))))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1); + + final BidderBid bidderBid = result.getValue().get(0); + assertThat(bidderBid.getType()).isEqualTo(BidType.banner); + assertThat(bidderBid.getBidCurrency()).isEqualTo(DEFAULT_CURRENCY); + + final Bid bid = bidderBid.getBid(); + assertThat(bid.getImpid()).isEqualTo("123"); + + final JsonNode prebidMeta = bid.getExt().path("prebid").path("meta"); + assertThat(prebidMeta.path("mediaType").asText()).isEqualTo("banner"); + assertThat(prebidMeta.path("advertiserDomains").isArray()).isTrue(); + assertThat(prebidMeta.path("advertiserDomains").size()).isEqualTo(0); + } + + @Test + public void makeBidsShouldReturnBannerBidForDisplayType() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + givenBidResponse(bidBuilder -> bidBuilder + .impid("123") + .ext(mapper.valueToTree(Map.of( + "nativery", Map.of("bid_ad_media_type", "display")))))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1); + + final BidderBid bidderBid = result.getValue().get(0); + assertThat(bidderBid.getType()).isEqualTo(BidType.banner); + assertThat(bidderBid.getBidCurrency()).isEqualTo(DEFAULT_CURRENCY); + + final Bid bid = bidderBid.getBid(); + assertThat(bid.getImpid()).isEqualTo("123"); + + final JsonNode prebidMeta = bid.getExt().path("prebid").path("meta"); + assertThat(prebidMeta.path("mediaType").asText()).isEqualTo("banner"); + assertThat(prebidMeta.path("advertiserDomains").isArray()).isTrue(); + assertThat(prebidMeta.path("advertiserDomains").size()).isEqualTo(0); + } + + @Test + public void makeBidsShouldReturnBannerBidForRichMediaType() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + givenBidResponse(bidBuilder -> bidBuilder + .impid("123") + .ext(mapper.valueToTree(Map.of("nativery", Map.of("bid_ad_media_type", "rich_media")))))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1); + + final BidderBid bidderBid = result.getValue().get(0); + assertThat(bidderBid.getType()).isEqualTo(banner); + assertThat(bidderBid.getBidCurrency()).isEqualTo(DEFAULT_CURRENCY); + + final Bid bid = bidderBid.getBid(); + assertThat(bid.getImpid()).isEqualTo("123"); + + final JsonNode prebidMeta = bid.getExt().path("prebid").path("meta"); + assertThat(prebidMeta.path("mediaType").asText()).isEqualTo("banner"); + assertThat(prebidMeta.path("advertiserDomains").isArray()).isTrue(); + assertThat(prebidMeta.path("advertiserDomains").size()).isEqualTo(0); + } + + @Test + public void makeBidsShouldReturnVideoBid() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + givenBidResponse(bidBuilder -> bidBuilder + .impid("123") + .ext(mapper.valueToTree(Map.of( + "nativery", Map.of("bid_ad_media_type", "video")))))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1); + + final BidderBid bidderBid = result.getValue().get(0); + assertThat(bidderBid.getType()).isEqualTo(BidType.video); + assertThat(bidderBid.getBidCurrency()).isEqualTo(DEFAULT_CURRENCY); + + final Bid bid = bidderBid.getBid(); + assertThat(bid.getImpid()).isEqualTo("123"); + + final JsonNode prebidMeta = bid.getExt().path("prebid").path("meta"); + assertThat(prebidMeta.path("mediaType").asText()).isEqualTo("video"); + assertThat(prebidMeta.path("advertiserDomains").isArray()).isTrue(); + assertThat(prebidMeta.path("advertiserDomains").size()).isEqualTo(0); + } + + @Test + public void makeBidsShouldReturnNativeBid() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + givenBidResponse(bidBuilder -> bidBuilder + .impid("123") + .ext(mapper.valueToTree(Map.of( + "nativery", Map.of("bid_ad_media_type", "native")))))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1); + + final BidderBid bidderBid = result.getValue().get(0); + assertThat(bidderBid.getType()).isEqualTo(BidType.xNative); + assertThat(bidderBid.getBidCurrency()).isEqualTo(DEFAULT_CURRENCY); + + final Bid bid = bidderBid.getBid(); + assertThat(bid.getImpid()).isEqualTo("123"); + + final JsonNode prebidMeta = bid.getExt().path("prebid").path("meta"); + assertThat(prebidMeta.path("mediaType").asText()).isEqualTo("native"); + assertThat(prebidMeta.path("advertiserDomains").isArray()).isTrue(); + assertThat(prebidMeta.path("advertiserDomains").size()).isEqualTo(0); + + assertThat(bid.getExt().has("nativery")).isFalse(); + } + + @Test + public void makeBidsShouldHandleUnsupportedBidType() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + givenBidResponse(b -> b + .ext(mapper.valueToTree(Map.of( + "prebid", ExtBidPrebid.builder().type(audio).build(), + "nativery", Map.of("bid_ad_media_type", "audio") + ))) + .impid("123")) + ); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()) + .hasSize(1) + .allSatisfy(error -> { + assertThat(error.getMessage()) + .isEqualTo("unrecognized bid_ad_media_type in response from nativery: audio"); + assertThat(error.getType()).isEqualTo(BidderError.Type.bad_input); + }); + } + + @Test + public void makeBidsShouldAddMetadataFromNativeryExt() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + givenBidResponse(bidBuilder -> bidBuilder + .impid("123") + .ext(mapper.valueToTree(Map.of( + "nativery", Map.of( + "bid_ad_media_type", "native", + "bid_adv_domains", List.of("domain.com"))))))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1); + + final BidderBid bidderBid = result.getValue().get(0); + assertThat(bidderBid.getType()).isEqualTo(BidType.xNative); + assertThat(bidderBid.getBidCurrency()).isEqualTo(DEFAULT_CURRENCY); + + final Bid bid = bidderBid.getBid(); + assertThat(bid.getImpid()).isEqualTo("123"); + + final JsonNode prebidMeta = bid.getExt().path("prebid").path("meta"); + assertThat(prebidMeta.path("mediaType").asText()).isEqualTo("native"); + assertThat(prebidMeta.path("advertiserDomains").isArray()).isTrue(); + assertThat(prebidMeta.path("advertiserDomains").get(0).asText()).isEqualTo("domain.com"); + + assertThat(bid.getExt().has("nativery")).isFalse(); + } + + @Test + public void makeBidsShouldReturnErrorForInvalidMediaType() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + givenBidResponse(bidBuilder -> bidBuilder + .id("123") + .ext(mapper.valueToTree(Map.of("nativery", Map.of("bid_ad_media_type", "invalid")))))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()) + .hasSize(1) + .allSatisfy(error -> { + assertThat(error.getMessage()).startsWith("unrecognized bid_ad_media_type"); + assertThat(error.getType()).isEqualTo(BidderError.Type.bad_input); + }); + } + + @Test + public void makeBidsShouldReturnErrorForMissingNativeryExt() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + givenBidResponse(bidBuilder -> bidBuilder.id("123").ext(mapper.createObjectNode()))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()) + .hasSize(1) + .allSatisfy(error -> { + assertThat(error.getMessage()).isEqualTo("missing bid.ext.nativery"); + assertThat(error.getType()).isEqualTo(BidderError.Type.bad_input); + }); + } + + private static BidRequest givenBidRequest( + UnaryOperator requestCustomizer, + UnaryOperator impCustomizer) { + + return requestCustomizer.apply(BidRequest.builder() + .imp(singletonList(givenImp(impCustomizer)))) + .build(); + } + + private static BidRequest givenBidRequest(UnaryOperator impCustomizer) { + return givenBidRequest(UnaryOperator.identity(), impCustomizer); + } + + private static Imp givenImp(UnaryOperator impCustomizer) { + return impCustomizer.apply(Imp.builder() + .id("123") + .ext(mapper.valueToTree(ExtPrebid.of(null, ExtImpNativery.of("widget1"))))) + .build(); + } + + private static String givenBidResponse(UnaryOperator bidCustomizer) throws JsonProcessingException { + final BidResponse bidResponse = BidResponse.builder() + .cur(DEFAULT_CURRENCY) + .seatbid(singletonList(SeatBid.builder().bid(singletonList(bidCustomizer.apply(Bid.builder()).build())) + .build())) + .build(); + return mapper.writeValueAsString(bidResponse); + } + + private static BidderCall givenHttpCall(String body) { + return BidderCall.succeededHttp( + HttpRequest.builder().payload(null).build(), + HttpResponse.of(200, null, body), + null); + } +} + diff --git a/src/test/java/org/prebid/server/bidder/sparteo/SparteoBidderTest.java b/src/test/java/org/prebid/server/bidder/sparteo/SparteoBidderTest.java index 2920f94adbd..e741c5e29c6 100644 --- a/src/test/java/org/prebid/server/bidder/sparteo/SparteoBidderTest.java +++ b/src/test/java/org/prebid/server/bidder/sparteo/SparteoBidderTest.java @@ -4,6 +4,7 @@ import com.fasterxml.jackson.databind.JsonNode; import com.fasterxml.jackson.databind.node.NullNode; import com.fasterxml.jackson.databind.node.ObjectNode; +import com.iab.openrtb.request.App; import com.iab.openrtb.request.BidRequest; import com.iab.openrtb.request.Imp; import com.iab.openrtb.request.Publisher; @@ -20,7 +21,6 @@ import org.prebid.server.bidder.model.HttpRequest; import org.prebid.server.bidder.model.HttpResponse; import org.prebid.server.bidder.model.Result; -import org.prebid.server.proto.openrtb.ext.ExtPrebid; import org.prebid.server.proto.openrtb.ext.request.ExtPublisher; import org.prebid.server.proto.openrtb.ext.response.BidType; @@ -44,62 +44,13 @@ public class SparteoBidderTest extends VertxTest { @Test public void creationShouldFailOnInvalidEndpointUrl() { - // when and then - assertThatIllegalArgumentException() - .isThrownBy(() -> new SparteoBidder("invalid_url", jacksonMapper)) - .withMessage("URL supplied is not valid: invalid_url"); - } - - @Test - public void makeHttpRequestsShouldReturnErrorWhenImpExtIsInvalid() { // given - final BidRequest bidRequest = givenBidRequest( - givenImp(imp -> imp.ext(mapper.valueToTree(ExtPrebid.of(null, "invalid"))))); - - // when - final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); - - // then - assertThat(result.getErrors()).hasSize(1) - .allSatisfy(error -> assertThat(error.getMessage()) - .startsWith("ignoring imp id=impId, error processing ext: invalid imp.ext")); - } - - @Test - public void makeHttpRequestsShouldReturnErrorWhenAllImpsAreInvalid() { - // given - final BidRequest bidRequest = givenBidRequest( - givenImp(imp -> imp.id("imp1").ext(mapper.valueToTree(ExtPrebid.of(null, "invalid"))))); - - // when - final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); - - // then - assertThat(result.getErrors()).hasSize(1); - } - - @Test - public void makeHttpRequestsShouldReturnPartialResultWhenSomeImpsAreInvalid() { - // given - final ObjectNode validExt = mapper.createObjectNode(); - validExt.set("bidder", mapper.createObjectNode().put("key", "value")); - - final BidRequest bidRequest = givenBidRequest( - givenImp(imp -> imp.id("imp1").ext(mapper.valueToTree(ExtPrebid.of(null, "invalid")))), - givenImp(imp -> imp.id("imp2").ext(validExt))); - - // when - final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); + final String invalidUrl = "invalid_url"; - // then - assertThat(result.getErrors()).hasSize(1) - .allSatisfy(error -> assertThat(error.getMessage()).startsWith("ignoring imp id=imp1")); - assertThat(result.getValue()) - .extracting(HttpRequest::getPayload) - .flatExtracting(BidRequest::getImp) - .extracting(Imp::getExt) - .extracting((JsonNode ext) -> ext.at("/sparteo/params/key").asText()) - .containsExactly("", "value"); + // when and then + assertThatIllegalArgumentException() + .isThrownBy(() -> new SparteoBidder(invalidUrl, jacksonMapper)) + .withMessage("URL supplied is not valid: " + invalidUrl); } @Test @@ -118,10 +69,11 @@ public void makeHttpRequestsShouldSetNetworkIdOnSitePublisherExtWhenPresentInImp final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); // then - assertThat(result.getErrors()).isEmpty(); + assertMissingSiteDomainWarning(result); assertThat(result.getValue()) .extracting(HttpRequest::getMethod, HttpRequest::getUri) - .containsExactly(tuple(HttpMethod.POST, ENDPOINT_URL)); + .containsExactly(tuple(HttpMethod.POST, + "https://test.sparteo.com/endpoint?network_id=testNetworkId&site_domain=unknown")); assertThat(result.getValue()) .extracting(HttpRequest::getPayload) @@ -138,7 +90,7 @@ public void makeHttpRequestsShouldSetNetworkIdOnSitePublisherExtWhenPresentInImp .extracting(BidRequest::getSite) .extracting(Site::getPublisher) .extracting(Publisher::getExt) - .extracting(ext -> ((ExtPublisher) ext).getProperties().get("params").get("networkId").asText()) + .extracting(ext -> ext.getProperties().get("params").get("networkId").asText()) .containsExactly("testNetworkId"); } @@ -159,21 +111,25 @@ public void makeHttpRequestsShouldUseFirstNetworkIdWhenMultipleImpsDefineIt() { final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); // then - assertThat(result.getErrors()).isEmpty(); + assertMissingSiteDomainWarning(result); assertThat(result.getValue()) .extracting(HttpRequest::getPayload) .extracting(BidRequest::getSite) .extracting(Site::getPublisher) .extracting(Publisher::getExt) - .extracting(ext -> ((ExtPublisher) ext).getProperties().get("params").get("networkId").asText()) + .extracting(ext -> ext.getProperties().get("params").get("networkId").asText()) .containsExactly("id1"); } @Test - public void makeHttpRequestsShouldOverwriteSparteoParamsWithBidderParamsOnConflict() { + public void makeHttpRequestsShouldMergeSparteoParamsWithBidderParamsOnConflict() { // given + final ObjectNode bidderNode = mapper.createObjectNode(); + bidderNode.put("conflictingParam", "bidderValue"); + bidderNode.put("networkId", "id1"); + final ObjectNode impExt = mapper.createObjectNode(); - impExt.set("bidder", mapper.createObjectNode().put("conflictingParam", "bidderValue")); + impExt.set("bidder", bidderNode); final ObjectNode sparteoNode = impExt.putObject("sparteo"); sparteoNode.putObject("params").put("conflictingParam", "sparteoValue"); @@ -190,6 +146,12 @@ public void makeHttpRequestsShouldOverwriteSparteoParamsWithBidderParamsOnConfli .extracting(Imp::getExt) .extracting((JsonNode ext) -> ext.at("/sparteo/params/conflictingParam").asText()) .containsExactly("bidderValue"); + assertThat(result.getValue()) + .extracting(HttpRequest::getPayload) + .flatExtracting(BidRequest::getImp) + .extracting(Imp::getExt) + .extracting((JsonNode ext) -> ext.at("/sparteo/params/networkId").asText()) + .containsExactly("id1"); } @Test @@ -198,7 +160,8 @@ public void makeHttpRequestsShouldHandleRequestWithoutSiteOrPublisher() { final ObjectNode impExt = mapper.createObjectNode(); impExt.set("bidder", mapper.createObjectNode().put("networkId", "testNetworkId")); - final BidRequest bidRequestNoSite = givenBidRequest(request -> request.site(null), + final BidRequest bidRequestNoSite = givenBidRequest( + request -> request.site(null), givenImp(imp -> imp.ext(impExt))); final BidRequest bidRequestNoPublisher = givenBidRequest( @@ -211,18 +174,19 @@ public void makeHttpRequestsShouldHandleRequestWithoutSiteOrPublisher() { sparteoBidder.makeHttpRequests(bidRequestNoPublisher); // then - assertThat(resultNoSite.getErrors()).isEmpty(); assertThat(resultNoSite.getValue()) .extracting(HttpRequest::getPayload) .extracting(BidRequest::getSite) .containsNull(); - assertThat(resultNoPublisher.getErrors()).isEmpty(); + assertThat(resultNoSite.getErrors()).isEmpty(); assertThat(resultNoPublisher.getValue()) .extracting(HttpRequest::getPayload) .extracting(BidRequest::getSite) .extracting(Site::getPublisher) - .containsNull(); + .extracting(Publisher::getExt) + .extracting(ext -> ext.getProperties().get("params").get("networkId").asText()) + .containsExactly("testNetworkId"); } @Test @@ -244,13 +208,13 @@ public void makeHttpRequestsShouldMergeNetworkIdIntoExistingPublisherExtParams() final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); // then - assertThat(result.getErrors()).isEmpty(); + assertMissingSiteDomainWarning(result); assertThat(result.getValue()) .extracting(HttpRequest::getPayload) .extracting(BidRequest::getSite) .extracting(Site::getPublisher) .extracting(Publisher::getExt) - .extracting(ext -> ((ExtPublisher) ext).getProperties().get("params")) + .extracting(ext -> ext.getProperties().get("params")) .allSatisfy(params -> { assertThat(params.get("networkId").asText()).isEqualTo("testNetworkId"); assertThat(params.get("existingParam").asText()).isEqualTo("existingValue"); @@ -259,7 +223,7 @@ public void makeHttpRequestsShouldMergeNetworkIdIntoExistingPublisherExtParams() @Test public void makeHttpRequestsShouldAddParamsToPublisherExtWhenExtExistsWithoutParams() - throws JsonProcessingException { + throws JsonProcessingException { // given final ObjectNode impExt = mapper.createObjectNode(); impExt.set("bidder", mapper.createObjectNode().put("networkId", "testNetworkId")); @@ -277,13 +241,13 @@ public void makeHttpRequestsShouldAddParamsToPublisherExtWhenExtExistsWithoutPar final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); // then - assertThat(result.getErrors()).isEmpty(); + assertMissingSiteDomainWarning(result); assertThat(result.getValue()) .extracting(HttpRequest::getPayload) .extracting(BidRequest::getSite) .extracting(Site::getPublisher) .extracting(Publisher::getExt) - .extracting(ext -> ((ExtPublisher) ext).getProperties()) + .extracting(ext -> ext.getProperties()) .allSatisfy(properties -> { assertThat(properties.get("params").get("networkId").asText()).isEqualTo("testNetworkId"); assertThat(properties.get("otherField").asText()).isEqualTo("otherValue"); @@ -291,38 +255,55 @@ public void makeHttpRequestsShouldAddParamsToPublisherExtWhenExtExistsWithoutPar } @Test - public void makeHttpRequestsShouldCreateEmptyParamsWhenBidderExtIsEmpty() { + public void makeHttpRequestsShouldReturnEmptyResultWhenRequestHasNoImps() { + // given + final BidRequest bidRequest = givenBidRequest(request -> request.imp(Collections.emptyList())); + + // when + final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).isEmpty(); + } + + @Test + public void makeHttpRequestsShouldAppendSiteDomainAndNetworkIdAsQueryParams() { // given final ObjectNode impExt = mapper.createObjectNode(); - impExt.set("bidder", mapper.createObjectNode()); - impExt.putObject("sparteo"); + impExt.set("bidder", mapper.createObjectNode().put("networkId", "testNetworkId")); - final BidRequest bidRequest = givenBidRequest(givenImp(imp -> imp.ext(impExt))); + final BidRequest bidRequest = givenBidRequest( + r -> r.site(Site.builder() + .domain("dev.sparteo.com") + .publisher(Publisher.builder().build()) + .build()), + givenImp(i -> i.ext(impExt))); // when final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); // then assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1); assertThat(result.getValue()) - .extracting(HttpRequest::getPayload) - .flatExtracting(BidRequest::getImp) - .extracting(Imp::getExt) - .allSatisfy(ext -> { - assertThat(ext.at("/sparteo")).isInstanceOf(ObjectNode.class); - assertThat(ext.at("/sparteo/params")).isInstanceOf(ObjectNode.class); - assertThat(ext.at("/sparteo/params").size()).isZero(); - }); + .extracting(HttpRequest::getUri) + .containsExactly("https://test.sparteo.com/endpoint?network_id=testNetworkId&site_domain=dev.sparteo.com"); } @Test - public void makeHttpRequestsShouldNotAddParamsWhenNetworkIdIsMissing() { + public void makeHttpRequestsShouldAppendSitePageDomainAndNetworkIdAsQueryParams() { // given final ObjectNode impExt = mapper.createObjectNode(); - impExt.set("bidder", mapper.createObjectNode().put("otherParam", "value")); + impExt.set("bidder", mapper.createObjectNode().put("networkId", "testNetworkId")); + final BidRequest bidRequest = givenBidRequest( - request -> request.site(Site.builder().publisher(Publisher.builder().id("pub1").build()).build()), - givenImp(imp -> imp.ext(impExt))); + r -> r.site(Site.builder() + .domain(null) + .page("https://www.dev.sparteo.com:3000/p") + .publisher(Publisher.builder().build()) + .build()), + givenImp(i -> i.ext(impExt))); // when final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); @@ -330,30 +311,45 @@ public void makeHttpRequestsShouldNotAddParamsWhenNetworkIdIsMissing() { // then assertThat(result.getErrors()).isEmpty(); assertThat(result.getValue()) - .extracting(HttpRequest::getPayload) - .extracting(BidRequest::getSite) - .extracting(Site::getPublisher) - .allSatisfy(publisher -> { - final ExtPublisher publisherExt = (ExtPublisher) publisher.getExt(); - if (publisherExt == null || publisherExt.getProperties() == null) { - assertThat(publisherExt).isNull(); - } else { - assertThat(publisherExt.getProperties()).doesNotContainKey("params"); - } - }); + .extracting(HttpRequest::getUri) + .containsExactly("https://test.sparteo.com/endpoint?network_id=testNetworkId&site_domain=dev.sparteo.com"); } @Test - public void makeHttpRequestsShouldNotAddNetworkIdWhenItIsNullInExt() { + public void makeHttpRequestsShouldUseSiteDomainWhenPublisherDomainIsMissing() { // given final ObjectNode impExt = mapper.createObjectNode(); - final ObjectNode bidderNode = mapper.createObjectNode(); - bidderNode.putNull("networkId"); - impExt.set("bidder", bidderNode); + impExt.set("bidder", mapper.createObjectNode().put("networkId", "testNetworkId")); final BidRequest bidRequest = givenBidRequest( - request -> request.site(Site.builder().publisher(Publisher.builder().id("pub1").build()).build()), - givenImp(imp -> imp.ext(impExt))); + r -> r.site(Site.builder() + .domain("dev.sparteo.com") + .publisher(Publisher.builder().build()) + .build()), + givenImp(i -> i.ext(impExt))); + + // when + final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1) + .extracting(HttpRequest::getUri) + .containsExactly("https://test.sparteo.com/endpoint?network_id=testNetworkId&site_domain=dev.sparteo.com"); + } + + @Test + public void makeHttpRequestsShouldPreferSiteDomainOverPublisherDomain() { + // given + final ObjectNode impExt = mapper.createObjectNode(); + impExt.set("bidder", mapper.createObjectNode().put("networkId", "networkId")); + + final BidRequest bidRequest = givenBidRequest( + r -> r.site(Site.builder() + .domain("site.sparteo.com") + .publisher(Publisher.builder().domain("dev.sparteo.com").build()) + .build()), + givenImp(i -> i.ext(impExt))); // when final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); @@ -361,34 +357,110 @@ public void makeHttpRequestsShouldNotAddNetworkIdWhenItIsNullInExt() { // then assertThat(result.getErrors()).isEmpty(); assertThat(result.getValue()) - .extracting(HttpRequest::getPayload) - .extracting(BidRequest::getSite) - .extracting(Site::getPublisher) - .allSatisfy(publisher -> { - final ExtPublisher publisherExt = (ExtPublisher) publisher.getExt(); - if (publisherExt != null && publisherExt.getProperties() != null - && publisherExt.getProperties().containsKey("params")) { - assertThat(publisherExt.getProperties().get("params")).isInstanceOf(ObjectNode.class); - assertThat(((ObjectNode) - publisherExt.getProperties().get("params")).has("networkId")).isFalse(); - } - }); + .extracting(HttpRequest::getUri) + .containsExactly("https://test.sparteo.com/endpoint?network_id=networkId&site_domain=site.sparteo.com"); } @Test - public void makeHttpRequestsShouldNotModifyPublisherExtWhenNetworkIdIsMissing() throws JsonProcessingException { + public void makeHttpRequestsShouldUseAppDomainWhenNoSite() { // given final ObjectNode impExt = mapper.createObjectNode(); - impExt.set("bidder", mapper.createObjectNode().put("someOtherParam", "someValue")); + impExt.set("bidder", mapper.createObjectNode().put("networkId", "networkId")); - final ObjectNode publisherExtJson = mapper.createObjectNode(); - publisherExtJson.put("existing", "value"); - final ExtPublisher originalPublisherExt = mapper.convertValue(publisherExtJson, ExtPublisher.class); + final BidRequest bidRequest = givenBidRequest( + r -> r + .site(null) + .app(App.builder() + .domain("com.sparteo.app") + .publisher(Publisher.builder().id("p1").build()) + .build()), + givenImp(i -> i.ext(impExt))); + + // when + final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); + + // then + assertMissingBundleWarning(result); + assertThat(result.getValue()) + .extracting(HttpRequest::getUri) + .containsExactly("https://test.sparteo.com/endpoint?network_id=networkId&app_domain=com.sparteo.app&bundle=unknown"); + } + + @Test + public void makeHttpRequestsShouldSetNetworkIdOnAppPublisherExtWhenNoSite() { + // given + final ObjectNode impExt = mapper.createObjectNode(); + impExt.set("bidder", mapper.createObjectNode().put("networkId", "networkId")); final BidRequest bidRequest = givenBidRequest( - request -> request.site(Site.builder().publisher( - Publisher.builder().ext(originalPublisherExt).build()).build()), - givenImp(imp -> imp.ext(impExt))); + r -> r + .site(null) + .app(App.builder() + .domain("com.sparteo.app") + .publisher(Publisher.builder().build()) + .build()), + givenImp(i -> i.ext(impExt))); + + // when + final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); + + // then + assertMissingBundleWarning(result); + final BidRequest out = result.getValue().get(0).getPayload(); + assertThat(out.getApp()).isNotNull(); + assertThat(out.getApp().getPublisher()).isNotNull(); + + final ExtPublisher ext = out.getApp().getPublisher().getExt(); + assertThat(ext).isNotNull(); + assertThat(ext.getProperties()).containsKey("params"); + assertThat(ext.getProperties().get("params").get("networkId").asText()).isEqualTo("networkId"); + } + + @Test + public void makeHttpRequestsShouldCreateAppPublisherWhenMissingAndSetNetworkId() { + // given + final ObjectNode impExt = mapper.createObjectNode(); + impExt.set("bidder", mapper.createObjectNode().put("networkId", "networkId")); + + final BidRequest bidRequest = givenBidRequest( + r -> r + .site(null) + .app(App.builder() + .domain("com.sparteo.app") + .publisher(null) + .build()), + givenImp(i -> i.ext(impExt))); + + // when + final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); + + // then + assertMissingBundleWarning(result); + final BidRequest out = result.getValue().get(0).getPayload(); + assertThat(out.getApp()).isNotNull(); + assertThat(out.getApp().getPublisher()).isNotNull(); + + final ExtPublisher ext = out.getApp().getPublisher().getExt(); + assertThat(ext).isNotNull(); + assertThat(ext.getProperties()).containsKey("params"); + assertThat(ext.getProperties().get("params").get("networkId").asText()).isEqualTo("networkId"); + } + + @Test + public void makeHttpRequestsShouldAppendBundleWhenAppBundlePresent() { + // given + final ObjectNode impExt = mapper.createObjectNode(); + impExt.set("bidder", mapper.createObjectNode().put("networkId", "networkId")); + + final BidRequest bidRequest = givenBidRequest( + r -> r + .site(null) + .app(App.builder() + .domain("dev.sparteo.com") + .bundle("com.sparteo.app") + .publisher(Publisher.builder().id("p1").build()) + .build()), + givenImp(i -> i.ext(impExt))); // when final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); @@ -396,25 +468,21 @@ public void makeHttpRequestsShouldNotModifyPublisherExtWhenNetworkIdIsMissing() // then assertThat(result.getErrors()).isEmpty(); assertThat(result.getValue()) - .extracting(HttpRequest::getPayload) - .extracting(BidRequest::getSite) - .extracting(Site::getPublisher) - .extracting(Publisher::getExt) - .extracting(ext -> ((ExtPublisher) ext).getProperties()) - .allSatisfy(properties -> { - assertThat(properties.get("existing").asText()).isEqualTo("value"); - assertThat(properties).doesNotContainKey("params"); - }); + .extracting(HttpRequest::getUri) + .containsExactly("https://test.sparteo.com/endpoint?network_id=networkId&app_domain=dev.sparteo.com&bundle=com.sparteo.app"); } @Test - public void makeHttpRequestsShouldOverwriteInvalidSparteoExtWhenBidderExtIsValid() { + public void makeHttpRequestsShouldNotAppendBundleWhenNoAppBundle() { // given final ObjectNode impExt = mapper.createObjectNode(); - impExt.set("bidder", mapper.createObjectNode().put("param", "value")); - impExt.put("sparteo", "this_is_a_string"); + impExt.set("bidder", mapper.createObjectNode().put("networkId", "networkId")); - final BidRequest bidRequest = givenBidRequest(givenImp(imp -> imp.ext(impExt))); + final BidRequest bidRequest = givenBidRequest( + r -> r + .site(Site.builder().domain("dev.sparteo.com").publisher(Publisher.builder().build()).build()) + .app(null), + givenImp(i -> i.ext(impExt))); // when final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); @@ -422,26 +490,109 @@ public void makeHttpRequestsShouldOverwriteInvalidSparteoExtWhenBidderExtIsValid // then assertThat(result.getErrors()).isEmpty(); assertThat(result.getValue()) - .extracting(HttpRequest::getPayload) - .flatExtracting(BidRequest::getImp) - .extracting(Imp::getExt) - .allSatisfy(ext -> { - assertThat(ext.at("/sparteo")).isInstanceOf(ObjectNode.class); - assertThat(ext.at("/sparteo/params/param").asText()).isEqualTo("value"); - }); + .extracting(HttpRequest::getUri) + .containsExactly("https://test.sparteo.com/endpoint?network_id=networkId&site_domain=dev.sparteo.com"); } @Test - public void makeHttpRequestsShouldReturnEmptyResultWhenRequestHasNoImps() { + public void makeHttpRequestsShouldAppendUnknownBundleWhenAppPresentButBundleMissing() { // given - final BidRequest bidRequest = givenBidRequest(request -> request.imp(Collections.emptyList())); + final ObjectNode impExt = mapper.createObjectNode(); + impExt.set("bidder", mapper.createObjectNode().put("networkId", "networkId")); + + final BidRequest bidRequest = givenBidRequest( + r -> r + .site(null) + .app(App.builder() + .domain("dev.sparteo.com") + .publisher(Publisher.builder().id("p1").build()) + .build()), + givenImp(i -> i.ext(impExt))); + + // when + final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); + + // then + assertMissingBundleWarning(result); + assertThat(result.getValue()) + .extracting(HttpRequest::getUri) + .containsExactly("https://test.sparteo.com/endpoint?network_id=networkId&app_domain=dev.sparteo.com&bundle=unknown"); + } + + @Test + public void makeHttpRequestsShouldAppendUnknownBundleWhenAppBundleIsNull() { + testAppendUnknownBundle(null); + } + + @Test + public void makeHttpRequestsShouldAppendUnknownBundleWhenAppBundleIsEmpty() { + testAppendUnknownBundle(""); + } + + @Test + public void makeHttpRequestsShouldAppendUnknownBundleWhenAppBundleIsBlank() { + testAppendUnknownBundle(" "); + } + + @Test + public void makeHttpRequestsShouldAppendUnknownBundleWhenAppBundleIsLiteralNull() { + testAppendUnknownBundle("null"); + } + + @Test + public void makeHttpRequestsShouldAppendUnknownBundleWhenAppBundleIsLiteralNullIgnoreCase() { + testAppendUnknownBundle("NuLl"); + } + + private void testAppendUnknownBundle(String rawBundle) { + // given + final ObjectNode impExt = mapper.createObjectNode(); + impExt.set("bidder", mapper.createObjectNode().put("networkId", "networkId")); + + final BidRequest bidRequest = givenBidRequest( + r -> r + .site(null) + .app(App.builder() + .domain("dev.sparteo.com") + .bundle(rawBundle) + .publisher(Publisher.builder().id("p1").build()) + .build()), + givenImp(i -> i.ext(impExt))); + + // when + final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); + + // then + assertMissingBundleWarning(result); + assertThat(result.getValue()) + .extracting(HttpRequest::getUri) + .containsExactly("https://test.sparteo.com/endpoint?network_id=networkId&app_domain=dev.sparteo.com&bundle=unknown"); + } + + @Test + public void makeHttpRequestsShouldWarnAndSetUnknownAppDomainWhenAppDomainMissing() { + // given + final ObjectNode impExt = mapper.createObjectNode(); + impExt.set("bidder", mapper.createObjectNode().put("networkId", "nid")); + + final BidRequest bidRequest = givenBidRequest( + r -> r.site(null) + .app(App.builder() + .domain(null) + .bundle("com.example.bundle") + .publisher(Publisher.builder().build()) + .build()), + givenImp(i -> i.ext(impExt))); // when final Result>> result = sparteoBidder.makeHttpRequests(bidRequest); // then assertThat(result.getErrors()).isEmpty(); - assertThat(result.getValue()).isEmpty(); + assertThat(result.getValue()) + .extracting(HttpRequest::getUri) + .containsExactly( + "https://test.sparteo.com/endpoint?network_id=nid&app_domain=unknown&bundle=com.example.bundle"); } @Test @@ -522,12 +673,10 @@ public void makeBidsShouldReturnEmptyResultWhenBidResponseIsNull() throws JsonPr } @Test - public void makeBidsShouldReturnEmptyResultWhenBidResponseHasNoSeatBids() - throws JsonProcessingException { + public void makeBidsShouldReturnEmptyResultWhenBidResponseHasNoSeatBids() throws JsonProcessingException { // given final BidResponse bidResponse = BidResponse.builder().seatbid(Collections.emptyList()).build(); - final BidderCall httpCall = - givenHttpCall(givenBidRequest(), bidResponse); + final BidderCall httpCall = givenHttpCall(givenBidRequest(), bidResponse); // when final Result> result = sparteoBidder.makeBids(httpCall, givenBidRequest()); @@ -543,8 +692,7 @@ public void makeBidsShouldReturnBannerBidWhenMediaTypeIsBanner() throws JsonProc final Bid bid = givenBid(builder -> builder.impid("imp1").price(BigDecimal.valueOf(1.23)).adm("adm-banner"), BidType.banner.getName()); final BidResponse bidResponse = givenBidResponse(bid, "EUR"); - final BidderCall httpCall = - givenHttpCall(givenBidRequest(), bidResponse); + final BidderCall httpCall = givenHttpCall(givenBidRequest(), bidResponse); // when final Result> result = sparteoBidder.makeBids(httpCall, givenBidRequest()); @@ -559,11 +707,10 @@ public void makeBidsShouldReturnBannerBidWhenMediaTypeIsBanner() throws JsonProc public void makeBidsShouldReturnVideoBidWhenMediaTypeIsVideo() throws JsonProcessingException { // given final Bid bid = givenBid(builder -> - builder.impid("imp2").price(BigDecimal.valueOf(2.34)).adm("adm-video"), + builder.impid("imp2").price(BigDecimal.valueOf(2.34)).adm("adm-video"), BidType.video.getName()); final BidResponse bidResponse = givenBidResponse(bid, "EUR"); - final BidderCall httpCall = - givenHttpCall(givenBidRequest(), bidResponse); + final BidderCall httpCall = givenHttpCall(givenBidRequest(), bidResponse); // when final Result> result = sparteoBidder.makeBids(httpCall, givenBidRequest()); @@ -578,11 +725,10 @@ public void makeBidsShouldReturnVideoBidWhenMediaTypeIsVideo() throws JsonProces public void makeBidsShouldReturnNativeBidWhenMediaTypeIsNative() throws JsonProcessingException { // given final Bid bid = givenBid(builder -> - builder.impid("imp3").price(BigDecimal.valueOf(3.45)).adm("adm-native"), + builder.impid("imp3").price(BigDecimal.valueOf(3.45)).adm("adm-native"), BidType.xNative.getName()); final BidResponse bidResponse = givenBidResponse(bid, "EUR"); - final BidderCall httpCall = - givenHttpCall(givenBidRequest(), bidResponse); + final BidderCall httpCall = givenHttpCall(givenBidRequest(), bidResponse); // when final Result> result = sparteoBidder.makeBids(httpCall, givenBidRequest()); @@ -603,8 +749,7 @@ public void makeBidsShouldReturnErrorForUnsupportedMediaTypeAndProcessOthers() t builder.impid("impBanner").price(BigDecimal.valueOf(2.0)), BidType.banner.getName()); final BidResponse bidResponse = givenBidResponse(List.of(audioBid, bannerBid), "EUR"); - final BidderCall httpCall = - givenHttpCall(givenBidRequest(), bidResponse); + final BidderCall httpCall = givenHttpCall(givenBidRequest(), bidResponse); // when final Result> result = sparteoBidder.makeBids(httpCall, givenBidRequest()); @@ -624,8 +769,7 @@ public void makeBidsShouldReturnErrorWhenBidExtIsNull() throws JsonProcessingExc // given final Bid bid = givenBid(builder -> builder.impid("imp1").ext(null), null); final BidResponse bidResponse = givenBidResponse(bid, "USD"); - final BidderCall httpCall = - givenHttpCall(givenBidRequest(), bidResponse); + final BidderCall httpCall = givenHttpCall(givenBidRequest(), bidResponse); // when final Result> result = sparteoBidder.makeBids(httpCall, givenBidRequest()); @@ -642,8 +786,7 @@ public void makeBidsShouldReturnErrorWhenPrebidIsMissingInBidExt() throws JsonPr // given final Bid bid = givenBid(builder -> builder.impid("imp1").ext(mapper.createObjectNode()), null); final BidResponse bidResponse = givenBidResponse(bid, "USD"); - final BidderCall httpCall = - givenHttpCall(givenBidRequest(), bidResponse); + final BidderCall httpCall = givenHttpCall(givenBidRequest(), bidResponse); // when final Result> result = sparteoBidder.makeBids(httpCall, givenBidRequest()); @@ -660,8 +803,7 @@ public void makeBidsShouldReturnErrorWhenPrebidTypeIsMissingInBidExt() throws Js // given final Bid bid = givenBid(builder -> builder.impid("imp1").ext(createBidExtWithEmptyPrebid()), null); final BidResponse bidResponse = givenBidResponse(bid, "USD"); - final BidderCall httpCall = - givenHttpCall(givenBidRequest(), bidResponse); + final BidderCall httpCall = givenHttpCall(givenBidRequest(), bidResponse); // when final Result> result = sparteoBidder.makeBids(httpCall, givenBidRequest()); @@ -680,8 +822,7 @@ public void makeBidsShouldReturnErrorWhenPrebidCannotBeParsed() throws JsonProce malformedExt.putArray("prebid"); final Bid bid = givenBid(builder -> builder.impid("imp1").ext(malformedExt), null); final BidResponse bidResponse = givenBidResponse(bid, "USD"); - final BidderCall httpCall = - givenHttpCall(givenBidRequest(), bidResponse); + final BidderCall httpCall = givenHttpCall(givenBidRequest(), bidResponse); // when final Result> result = sparteoBidder.makeBids(httpCall, givenBidRequest()); @@ -698,8 +839,7 @@ public void makeBidsShouldReturnErrorWhenPrebidTypeIsUnsupported() throws JsonPr // given final Bid bid = givenBid(builder -> builder.impid("imp1"), "unknown-type"); final BidResponse bidResponse = givenBidResponse(bid, "USD"); - final BidderCall httpCall = - givenHttpCall(givenBidRequest(), bidResponse); + final BidderCall httpCall = givenHttpCall(givenBidRequest(), bidResponse); // when final Result> result = sparteoBidder.makeBids(httpCall, givenBidRequest()); @@ -715,15 +855,14 @@ public void makeBidsShouldReturnErrorWhenPrebidTypeIsUnsupported() throws JsonPr public void makeBidsShouldProcessValidBidsWhenSeatBidContainsNulls() throws JsonProcessingException { // given final Bid validBid = givenBid(builder -> - builder.impid("validImp").price(BigDecimal.ONE), + builder.impid("validImp").price(BigDecimal.ONE), BidType.banner.getName()); final List bids = new ArrayList<>(); bids.add(null); bids.add(validBid); final BidResponse bidResponse = givenBidResponse(bids, "USD"); - final BidderCall httpCall = - givenHttpCall(givenBidRequest(), bidResponse); + final BidderCall httpCall = givenHttpCall(givenBidRequest(), bidResponse); // when final Result> result = sparteoBidder.makeBids(httpCall, givenBidRequest()); @@ -739,21 +878,20 @@ public void makeBidsShouldProcessValidBidsWhenSeatBidContainsNulls() throws Json public void makeBidsShouldCorrectlyProcessMultipleBidsAndSeatBids() throws JsonProcessingException { // given final Bid bid1 = givenBid(builder -> - builder.impid("imp1").price(BigDecimal.valueOf(1.0)), + builder.impid("imp1").price(BigDecimal.valueOf(1.0)), BidType.banner.getName()); final Bid bid2 = givenBid(builder -> - builder.impid("imp2").price(BigDecimal.valueOf(2.0)), + builder.impid("imp2").price(BigDecimal.valueOf(2.0)), BidType.video.getName()); final Bid bid3 = givenBid(builder -> - builder.impid("imp3").price(BigDecimal.valueOf(3.0)), + builder.impid("imp3").price(BigDecimal.valueOf(3.0)), BidType.xNative.getName()); final SeatBid seatBid1 = SeatBid.builder().bid(asList(bid1, bid2)).build(); final SeatBid seatBid2 = SeatBid.builder().bid(singletonList(bid3)).build(); final BidResponse bidResponse = BidResponse.builder().cur("USD").seatbid(asList(seatBid1, seatBid2)).build(); - final BidderCall httpCall = - givenHttpCall(givenBidRequest(), bidResponse); + final BidderCall httpCall = givenHttpCall(givenBidRequest(), bidResponse); // when final Result> result = sparteoBidder.makeBids(httpCall, givenBidRequest()); @@ -777,8 +915,7 @@ public void makeBidsShouldReturnErrorWhenPrebidExtIsNullNode() throws JsonProces final Bid bid = givenBid(builder -> builder.impid("imp1").ext(bidExtWithNullPrebid), null); final BidResponse bidResponse = givenBidResponse(bid, "USD"); - final BidderCall httpCall = - givenHttpCall(givenBidRequest(), bidResponse); + final BidderCall httpCall = givenHttpCall(givenBidRequest(), bidResponse); // when final Result> result = sparteoBidder.makeBids(httpCall, givenBidRequest()); @@ -794,10 +931,10 @@ public void makeBidsShouldReturnErrorWhenPrebidExtIsNullNode() throws JsonProces public void makeBidsShouldProcessValidSeatBidsWhenResponseContainsNulls() throws JsonProcessingException { // given final Bid validBid1 = givenBid(builder -> - builder.impid("validImp1").price(BigDecimal.TEN), + builder.impid("validImp1").price(BigDecimal.TEN), BidType.banner.getName()); final Bid validBid2 = givenBid(builder -> - builder.impid("validImp2").price(BigDecimal.ONE), + builder.impid("validImp2").price(BigDecimal.ONE), BidType.banner.getName()); final SeatBid validSeatBid1 = SeatBid.builder().bid(singletonList(validBid1)).build(); @@ -809,8 +946,7 @@ public void makeBidsShouldProcessValidSeatBidsWhenResponseContainsNulls() throws seatBidsWithNull.add(validSeatBid2); final BidResponse bidResponse = BidResponse.builder().cur("USD").seatbid(seatBidsWithNull).build(); - final BidderCall httpCall = - givenHttpCall(givenBidRequest(), bidResponse); + final BidderCall httpCall = givenHttpCall(givenBidRequest(), bidResponse); // when final Result> result = sparteoBidder.makeBids(httpCall, givenBidRequest()); @@ -829,8 +965,7 @@ public void makeBidsShouldReturnEmptyResultWhenSeatBidHasNullBidList() throws Js final SeatBid seatBidWithNullBids = SeatBid.builder().bid(null).build(); final BidResponse bidResponse = BidResponse.builder().cur("USD").seatbid(singletonList(seatBidWithNullBids)).build(); - final BidderCall httpCall = - givenHttpCall(givenBidRequest(), bidResponse); + final BidderCall httpCall = givenHttpCall(givenBidRequest(), bidResponse); // when final Result> result = sparteoBidder.makeBids(httpCall, givenBidRequest()); @@ -846,8 +981,7 @@ public void makeBidsShouldReturnEmptyResultWhenSeatBidHasEmptyBidList() throws J final SeatBid seatBidWithEmptyBids = SeatBid.builder().bid(Collections.emptyList()).build(); final BidResponse bidResponse = BidResponse.builder().cur("USD").seatbid(singletonList(seatBidWithEmptyBids)).build(); - final BidderCall httpCall = - givenHttpCall(givenBidRequest(), bidResponse); + final BidderCall httpCall = givenHttpCall(givenBidRequest(), bidResponse); // when final Result> result = sparteoBidder.makeBids(httpCall, givenBidRequest()); @@ -872,11 +1006,9 @@ private Imp givenImp(UnaryOperator impCustomizer) { private Bid givenBid(UnaryOperator bidCustomizer, String mediaType) { final Bid.BidBuilder builder = Bid.builder(); bidCustomizer.apply(builder); - if (builder.build().getExt() == null && mediaType != null) { builder.ext(createBidExtWithType(mediaType)); } - return builder.build(); } @@ -916,4 +1048,24 @@ private ObjectNode createBidExtWithEmptyPrebid() { bidExt.set("prebid", mapper.createObjectNode()); return bidExt; } + + private static void assertMissingSiteDomainWarning(Result result) { + assertThat(result.getErrors()) + .hasSize(1) + .allSatisfy(err -> { + assertThat(err.getType()).isEqualTo(BidderError.Type.bad_input); + assertThat(err.getMessage()) + .contains("Domain not found. Missing the site.domain or the site.page field"); + }); + } + + private static void assertMissingBundleWarning(Result result) { + assertThat(result.getErrors()) + .hasSize(1) + .allSatisfy(err -> { + assertThat(err.getType()).isEqualTo(BidderError.Type.bad_input); + assertThat(err.getMessage()) + .contains("Bundle not found. Missing the app.bundle field."); + }); + } } diff --git a/src/test/java/org/prebid/server/bidder/sparteo/SparteoUtilTest.java b/src/test/java/org/prebid/server/bidder/sparteo/SparteoUtilTest.java new file mode 100644 index 00000000000..d735c0d7e89 --- /dev/null +++ b/src/test/java/org/prebid/server/bidder/sparteo/SparteoUtilTest.java @@ -0,0 +1,49 @@ +package org.prebid.server.bidder.sparteo; + +import org.junit.jupiter.api.Test; +import org.prebid.server.VertxTest; +import org.prebid.server.bidder.sparteo.util.SparteoUtil; + +import static org.assertj.core.api.Assertions.assertThat; + +public class SparteoUtilTest extends VertxTest { + + @Test + public void normalizeHostnameShouldReturnBaseDomain() { + final String base = "dev.sparteo.com"; + + assertThat(SparteoUtil.normalizeHostname(base)).isEqualTo(base); + + assertThat(SparteoUtil.normalizeHostname("DeV.SpArTeO.CoM")).isEqualTo(base); + assertThat(SparteoUtil.normalizeHostname(" " + base + " ")).isEqualTo(base); + + assertThat(SparteoUtil.normalizeHostname("www." + base)).isEqualTo(base); + assertThat(SparteoUtil.normalizeHostname("WWW." + base)).isEqualTo(base); + + assertThat(SparteoUtil.normalizeHostname(base + ".")).isEqualTo(base); + assertThat(SparteoUtil.normalizeHostname(base + "..")).isEqualTo(base + "."); + + assertThat(SparteoUtil.normalizeHostname("null")).isEqualTo(""); + assertThat(SparteoUtil.normalizeHostname("NuLl")).isEqualTo(""); + + assertThat(SparteoUtil.normalizeHostname("")).isEqualTo(""); + assertThat(SparteoUtil.normalizeHostname(" ")).isEqualTo(""); + + assertThat(SparteoUtil.normalizeHostname("www2." + base)).isEqualTo("www2." + base); + + assertThat(SparteoUtil.normalizeHostname("www." + base + ":8080")).isEqualTo(base); + assertThat(SparteoUtil.normalizeHostname("DEV.SPARTEO.COM:443")).isEqualTo(base); + assertThat(SparteoUtil.normalizeHostname(base + ".:8443")).isEqualTo(base); + + assertThat(SparteoUtil.normalizeHostname(base + "/some/path?x=1")).isEqualTo(base); + assertThat(SparteoUtil.normalizeHostname("www." + base + "/p")).isEqualTo(base); + + assertThat(SparteoUtil.normalizeHostname(base + ":8080/p?q=1")).isEqualTo(base); + assertThat(SparteoUtil.normalizeHostname("www." + base + ":3000/some/path")).isEqualTo(base); + + assertThat(SparteoUtil.normalizeHostname("https://www." + base + "/x")).isEqualTo(base); + assertThat(SparteoUtil.normalizeHostname("http://WWW." + base + ":8080/abc")).isEqualTo(base); + + assertThat(SparteoUtil.normalizeHostname(" https://www." + base + ":3000/x ")).isEqualTo(base); + } +} diff --git a/src/test/java/org/prebid/server/it/BoldwinRapidTest.java b/src/test/java/org/prebid/server/it/BoldwinRapidTest.java new file mode 100644 index 00000000000..e78c34da7ab --- /dev/null +++ b/src/test/java/org/prebid/server/it/BoldwinRapidTest.java @@ -0,0 +1,35 @@ +package org.prebid.server.it; + +import io.restassured.response.Response; +import org.json.JSONException; +import org.junit.jupiter.api.Test; +import org.prebid.server.model.Endpoint; + +import java.io.IOException; + +import static com.github.tomakehurst.wiremock.client.WireMock.aResponse; +import static com.github.tomakehurst.wiremock.client.WireMock.equalToJson; +import static com.github.tomakehurst.wiremock.client.WireMock.post; +import static com.github.tomakehurst.wiremock.client.WireMock.urlPathEqualTo; +import static java.util.Collections.singletonList; + +public class BoldwinRapidTest extends IntegrationTest { + + @Test + public void openrtb2AuctionShouldRespondWithBidsFromBoldwinRapid() throws IOException, JSONException { + // given + WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/boldwinrapid-exchange")) + .withRequestBody(equalToJson( + jsonFrom("openrtb2/boldwinrapid/test-boldwinrapid-bid-request.json"))) + .willReturn(aResponse().withBody( + jsonFrom("openrtb2/boldwinrapid/test-boldwinrapid-bid-response.json")))); + + // when + final Response response = responseFor("openrtb2/boldwinrapid/test-auction-boldwinrapid-request.json", + Endpoint.openrtb2_auction); + + // then + assertJsonEquals("openrtb2/boldwinrapid/test-auction-boldwinrapid-response.json", response, + singletonList("boldwin_rapid")); + } +} diff --git a/src/test/java/org/prebid/server/it/NativeryTest.java b/src/test/java/org/prebid/server/it/NativeryTest.java new file mode 100644 index 00000000000..b4df3c59702 --- /dev/null +++ b/src/test/java/org/prebid/server/it/NativeryTest.java @@ -0,0 +1,32 @@ +package org.prebid.server.it; + +import io.restassured.response.Response; +import org.json.JSONException; +import org.junit.jupiter.api.Test; +import org.prebid.server.model.Endpoint; + +import java.io.IOException; + +import static com.github.tomakehurst.wiremock.client.WireMock.aResponse; +import static com.github.tomakehurst.wiremock.client.WireMock.equalToJson; +import static com.github.tomakehurst.wiremock.client.WireMock.post; +import static com.github.tomakehurst.wiremock.client.WireMock.urlPathEqualTo; +import static java.util.Collections.singletonList; + +public class NativeryTest extends IntegrationTest { + + @Test + public void openrtb2AuctionShouldRespondWithBidsFromNativery() throws IOException, JSONException { + // given + WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/nativery-exchange")) + .withRequestBody(equalToJson(jsonFrom("openrtb2/nativery/test-nativery-bid-request.json"))) + .willReturn(aResponse().withBody(jsonFrom("openrtb2/nativery/test-nativery-bid-response.json")))); + + // when + final Response response = responseFor("openrtb2/nativery/test-auction-nativery-request.json", + Endpoint.openrtb2_auction); + + // then + assertJsonEquals("openrtb2/nativery/test-auction-nativery-response.json", response, singletonList("nativery")); + } +} diff --git a/src/test/java/org/prebid/server/it/SparteoTest.java b/src/test/java/org/prebid/server/it/SparteoTest.java index f169a486e50..713cf35fee1 100644 --- a/src/test/java/org/prebid/server/it/SparteoTest.java +++ b/src/test/java/org/prebid/server/it/SparteoTest.java @@ -5,6 +5,7 @@ import org.prebid.server.model.Endpoint; import static com.github.tomakehurst.wiremock.client.WireMock.aResponse; +import static com.github.tomakehurst.wiremock.client.WireMock.equalTo; import static com.github.tomakehurst.wiremock.client.WireMock.equalToJson; import static com.github.tomakehurst.wiremock.client.WireMock.post; import static com.github.tomakehurst.wiremock.client.WireMock.urlPathEqualTo; @@ -15,6 +16,8 @@ public class SparteoTest extends IntegrationTest { @Test public void openrtb2AuctionShouldRespondWithBidsFromSparteoBanner() throws Exception { WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/sparteo-exchange")) + .withQueryParam("network_id", equalTo("networkId")) + .withQueryParam("site_domain", equalTo("dev.sparteo.com")) .withRequestBody(equalToJson( jsonFrom("openrtb2/sparteo/test-sparteo-bid-request.json"))) .willReturn(aResponse().withBody( diff --git a/src/test/resources/org/prebid/server/it/openrtb2/boldwinrapid/test-auction-boldwinrapid-request.json b/src/test/resources/org/prebid/server/it/openrtb2/boldwinrapid/test-auction-boldwinrapid-request.json new file mode 100644 index 00000000000..cc99841ed2e --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/boldwinrapid/test-auction-boldwinrapid-request.json @@ -0,0 +1,27 @@ +{ + "id": "request_id", + "imp": [ + { + "id": "imp_id", + "video": { + "mimes": [ + "video/mp4" + ], + "w": 800, + "h": 600 + }, + "ext": { + "boldwin_rapid": { + "tid": "tid", + "pid": "pid" + } + } + } + ], + "tmax": 5000, + "regs": { + "ext": { + "gdpr": 0 + } + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/boldwinrapid/test-auction-boldwinrapid-response.json b/src/test/resources/org/prebid/server/it/openrtb2/boldwinrapid/test-auction-boldwinrapid-response.json new file mode 100644 index 00000000000..12f5faf24a2 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/boldwinrapid/test-auction-boldwinrapid-response.json @@ -0,0 +1,41 @@ +{ + "id": "request_id", + "seatbid": [ + { + "bid": [ + { + "id": "bid_id", + "impid": "imp_id", + "exp": 1500, + "price": 1.25, + "adm": "adm001", + "crid": "crid", + "w": 800, + "h": 600, + "ext": { + "prebid": { + "type": "video", + "meta": { + "adaptercode": "boldwin_rapid" + } + }, + "origbidcpm": 1.25 + }, + "mtype": 2 + } + ], + "seat": "boldwin_rapid", + "group": 0 + } + ], + "cur": "USD", + "ext": { + "responsetimemillis": { + "boldwin_rapid": "{{ boldwin_rapid.response_time_ms }}" + }, + "prebid": { + "auctiontimestamp": 0 + }, + "tmaxrequest": 5000 + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/boldwinrapid/test-boldwinrapid-bid-request.json b/src/test/resources/org/prebid/server/it/openrtb2/boldwinrapid/test-boldwinrapid-bid-request.json new file mode 100644 index 00000000000..b806f784e43 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/boldwinrapid/test-boldwinrapid-bid-request.json @@ -0,0 +1,60 @@ +{ + "id": "request_id", + "imp": [ + { + "id": "imp_id", + "secure": 1, + "video": { + "mimes": [ + "video/mp4" + ], + "w": 800, + "h": 600 + }, + "ext": { + "tid": "${json-unit.any-string}", + "bidder": { + "tid": "tid", + "pid": "pid" + } + } + } + ], + "source": { + "tid": "${json-unit.any-string}" + }, + "site": { + "domain": "www.example.com", + "page": "http://www.example.com", + "publisher": { + "domain": "example.com" + }, + "ext": { + "amp": 0 + } + }, + "device": { + "ua": "userAgent", + "ip": "193.168.244.1" + }, + "at": 1, + "tmax": "${json-unit.any-number}", + "cur": [ + "USD" + ], + "regs": { + "ext": { + "gdpr": 0 + } + }, + "ext": { + "prebid": { + "server": { + "externalurl": "http://localhost:8080", + "gvlid": 1, + "datacenter": "local", + "endpoint": "/openrtb2/auction" + } + } + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/boldwinrapid/test-boldwinrapid-bid-response.json b/src/test/resources/org/prebid/server/it/openrtb2/boldwinrapid/test-boldwinrapid-bid-response.json new file mode 100644 index 00000000000..b00165a1652 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/boldwinrapid/test-boldwinrapid-bid-response.json @@ -0,0 +1,20 @@ +{ + "id": "request_id", + "seatbid": [ + { + "bid": [ + { + "id": "bid_id", + "impid": "imp_id", + "price": 1.25, + "crid": "crid", + "adm": "adm001", + "h": 600, + "w": 800, + "mtype": 2 + } + ] + } + ], + "bidid": "bid001" +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/nativery/test-auction-nativery-request.json b/src/test/resources/org/prebid/server/it/openrtb2/nativery/test-auction-nativery-request.json new file mode 100644 index 00000000000..46fa1b2e2e8 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/nativery/test-auction-nativery-request.json @@ -0,0 +1,54 @@ +{ + "id": "request_id", + "imp": [ + { + "id": "imp_id", + "banner": { + "w": 300, + "h": 250 + }, + "ext": { + "nativery": { + "widgetId": "1" + } + } + } + ], + "site": { + "domain": "www.example.com", + "page": "http://www.example.com", + "publisher": { + "domain": "example.com" + }, + "ext": { + "amp": 0 + } + }, + "device": { + "ua": "userAgent", + "ip": "193.168.244.1" + }, + "at": 1, + "tmax": 5000, + "cur": [ + "USD" + ], + "source": { + "tid": "${json-unit.any-string}" + }, + "regs": { + "ext": { + "gdpr": 0 + } + }, + "ext": { + "prebid": { + "server": { + "externalurl": "http://localhost:8080", + "gvlid": 1, + "datacenter": "local", + "endpoint": "/openrtb2/auction" + } + } + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/nativery/test-auction-nativery-response.json b/src/test/resources/org/prebid/server/it/openrtb2/nativery/test-auction-nativery-response.json new file mode 100644 index 00000000000..97b4616fe92 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/nativery/test-auction-nativery-response.json @@ -0,0 +1,43 @@ +{ + "id": "request_id", + "seatbid": [ + { + "bid": [ + { + "id": "bid_id", + "impid": "imp_id", + "exp": 300, + "price": 3.33, + "adm": "
ad
", + "adomain": ["example.com"], + "crid": "creativeId", + "mtype": 1, + "ext": { + "origbidcpm": 3.33, + "origbidcur": "USD", + "prebid": { + "type": "banner", + "meta": { + "adaptercode": "nativery", + "mediaType": "banner", + "advertiserDomains": ["example.com"] + } + } + } + } + ], + "seat": "nativery", + "group": 0 + } + ], + "cur": "USD", + "ext": { + "responsetimemillis": { + "nativery": "{{ nativery.response_time_ms }}" + }, + "prebid": { + "auctiontimestamp": 0 + }, + "tmaxrequest": 5000 + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/nativery/test-nativery-bid-request.json b/src/test/resources/org/prebid/server/it/openrtb2/nativery/test-nativery-bid-request.json new file mode 100644 index 00000000000..1a5e555fc90 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/nativery/test-nativery-bid-request.json @@ -0,0 +1,61 @@ +{ + "id": "request_id", + "imp": [ + { + "id": "imp_id", + "banner": { + "w": 300, + "h": 250 + }, + "secure": 1, + "ext": { + "tid": "${json-unit.any-string}", + "bidder": { + "widgetId": "1" + } + } + } + ], + "site": { + "domain": "www.example.com", + "page": "http://www.example.com", + "publisher": { + "domain": "example.com" + }, + "ext": { + "amp": 0 + } + }, + "device": { + "ua": "userAgent", + "ip": "193.168.244.1" + }, + "at": 1, + "tmax": "${json-unit.any-number}", + "cur": [ + "USD" + ], + "source": { + "tid": "${json-unit.any-string}" + }, + "regs": { + "gdpr": 0 + }, + "ext": { + "prebid": { + "channel": { + "name": "web" + }, + "server": { + "externalurl": "http://localhost:8080", + "gvlid": 1, + "datacenter": "local", + "endpoint": "/openrtb2/auction" + } + }, + "nativery": { + "isAmp": false, + "widgetId": "1" + } + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/nativery/test-nativery-bid-response.json b/src/test/resources/org/prebid/server/it/openrtb2/nativery/test-nativery-bid-response.json new file mode 100644 index 00000000000..1b2e894477e --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/nativery/test-nativery-bid-response.json @@ -0,0 +1,29 @@ +{ + "id": "request_id", + "seatbid": [ + { + "bid": [ + { + "id": "bid_id", + "impid": "imp_id", + "price": 3.33, + "adm": "
ad
", + "adomain": [ + "example.com" + ], + "crid": "creativeId", + "mtype": 1, + "ext": { + "nativery": { + "bid_ad_media_type": "display", + "bid_adv_domains": [ + "example.com" + ] + } + } + } + ] + } + ], + "cur": "USD" +} diff --git a/src/test/resources/org/prebid/server/it/test-application.properties b/src/test/resources/org/prebid/server/it/test-application.properties index 9a0ce38e4ad..1a073dcda06 100644 --- a/src/test/resources/org/prebid/server/it/test-application.properties +++ b/src/test/resources/org/prebid/server/it/test-application.properties @@ -185,6 +185,8 @@ adapters.bmtm.enabled=true adapters.bmtm.endpoint=http://localhost:8090/bmtm-exchange adapters.boldwin.enabled=true adapters.boldwin.endpoint=http://localhost:8090/boldwin-exchange +adapters.boldwin_rapid.enabled=true +adapters.boldwin_rapid.endpoint=http://localhost:8090/boldwinrapid-exchange adapters.brave.enabled=true adapters.brave.endpoint=http://localhost:8090/brave-exchange adapters.bwx.enabled=true @@ -404,6 +406,8 @@ adapters.mobkoi.enabled=true adapters.mobkoi.endpoint=http://localhost:8090/mobkoi-exchange adapters.motorik.enabled=true adapters.motorik.endpoint=http://localhost:8090/motorik-exchange?k={{AccountID}}&name={{SourceId}} +adapters.nativery.enabled=true +adapters.nativery.endpoint=http://localhost:8090/nativery-exchange adapters.nextmillennium.enabled=true adapters.nextmillennium.endpoint=http://localhost:8090/nextmillennium-exchange adapters.nextmillennium.extra-info.nmmFlags=1