No way to suppress logs

[Properko]

Expected Behaviour

Providing a log object to the constructor should ensure I have control over all the log output.

Actual Behaviour

Extra log messages are logged from other adobe dependencies, e.g. https://github.com/adobe/node-httptransfer/blob/master/lib/randomfileaccess.js#L160

Platform and Version

"@adobe/aem-upload": "2.0.3"

Sample Code that illustrates the problem

import AemUploader from "@adobe/aem-upload";
const binaryUploader = new AemUploader.DirectBinaryUpload({
  log: {
    debug: (...theArguments) => undefined,
    info: (...theArguments) => undefined,
    warn: (...theArguments) =>
      console.info.apply(null, theArguments),
    error: (...theArguments) =>
      console.warn.apply(null, theArguments),
  }
});
binaryUploader.uploadFiles(...)

Logs taken while reproducing problem

Server accepts ranges for this transfer asset: true
1 transfer parts created (multipart target)
Transferred content range: [object Object]
Source has protocol 'file'
Getting file handle for reading file ...

[mfrisbey]

Please note that these messages are coming frome node-httptransfer. Please submit an issue there for support.

[ManasMaji]

Hi @mfrisbey , @pheenomenon : Since this issue was addressed in node-httptransfer, can a new version of node-httptransfer be released and updated in aem-upload?

[Properko]

At the moment it's possible to use below in your package.json, but agreed it would be nice to get a proper release.

"overrides": {
    "@adobe/httptransfer": "https://github.com/Properko/node-httptransfer.git#avoid-console-log",
}

or

"overrides": {
    "@adobe/httptransfer": "https://github.com/adobe/node-httptransfer.git#master",
}

[mfrisbey]

There is now a proper release of node-httptransfer, so the package.json version can be changed to 5.0.0

[bhellema]

In the scenario where our module https://www.npmjs.com/package/@adobe/aem-import-helper leverage the aem-upload module, and in our package.json we specify the override

  "overrides": {
    "@adobe/aem-upload": {
      "@adobe/httptransfer": "5.0.0"
    }
  }

This does not work when users npm install -g @adobe/aem-import-helper. The override does not seem to take affect until (major hack) you cd to the node_modules folder in the global location for aem-import-helper and then run npm install, we can not ask users to do this.

@Properko have you found a way around this?

[Properko]

Basically this needs to be reopened, so aem-upload lib maintainers can pull in the latest @adobe/httptransfer

[github-actions]

🎉 This issue has been resolved in version 2.0.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀