From c5cbadd2569a8843ef55d73c75f6f9a1c702b20c Mon Sep 17 00:00:00 2001 From: Sam Hewitt Date: Tue, 17 Jun 2025 15:27:49 -0400 Subject: [PATCH 1/2] fix: synchronous impl of Env.sync it more closely aligns with mdb_env_sync and is how it is handled in lmdb-java too --- src/env.cpp | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/env.cpp b/src/env.cpp index 1f6246008..fa47bf8f0 100644 --- a/src/env.cpp +++ b/src/env.cpp @@ -616,15 +616,11 @@ NAN_METHOD(EnvWrap::sync) { return Nan::ThrowError("The environment is already closed."); } - Nan::Callback* callback = new Nan::Callback( - v8::Local::Cast(info[0]) - ); - - SyncWorker* worker = new SyncWorker( - ew->env, callback - ); + int rc = mdb_env_sync(ew->env, 1); // 1 = force + if (rc != 0) { + return Nan::ThrowError(mdb_strerror(rc)); + } - Nan::AsyncQueueWorker(worker); return; } From ded8cfd4b47920471725f32813151957dedc519d Mon Sep 17 00:00:00 2001 From: Sam Hewitt Date: Tue, 17 Jun 2025 15:28:45 -0400 Subject: [PATCH 2/2] fix: include integer types in patch --- src/kevel-patch.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/kevel-patch.h b/src/kevel-patch.h index 8fcd09493..ad7d19b0b 100644 --- a/src/kevel-patch.h +++ b/src/kevel-patch.h @@ -1,6 +1,8 @@ #ifndef KEVEL_PATCH_H #define KEVEL_PATCH_H -typedef uint64_t mdb_size_t; +#include + +typedef uint64_t mdb_size_t; #endif // KEVEL_PATCH_H