Does not work with external keyboards

[cherdarchuk]

Only seems to work with the integrated macbook keyboard and not my external (non-apple) keyboards (I don't have an apple keyboard to test it with).
AI suggests fix may be changing line 481 of AppDelegate.m to

eventTap = CGEventTapCreate(kCGHIDEventTap,

But I don't have xcode to test or any experience with Objective-C to know whether that even makes sense.

[cherdarchuk]

To be clear it is the use of the CMD key in combination with the volume controls that does not work from an external keyboard

[alberti42]

I have never thought about non Apple keyboards. but yeah, they must exist ;-)

Surprisingly no one ever mentioned this bug/missing feature until today.

Are there standardized volume buttons on Windows keyboards? I need to check. I may have one such keyboard to experiment.

[alberti42]

It is the right place to check. Essentially any key you press on your keyboard receives a bunch of codes. My app checks quickly if any pressed key matches one of the volume keys.

The only thing to figure out is: what are the codes of your keys? In principle we can map any keys to the volume key.

But then I would have to think about how to configure. I guess we could add a customization dialog to enter custom volume keys.

[cherdarchuk]

I just got myself a Nuphy Node 100 which has all the apple media keys. To be clear the volume up and down keys work just fine on their own (it adjusts spotify volume as I'd hoped). It is the CMD+volume key combination that doesn't work. I find it useful as sometimes want to change system volume not Spotify volume. Things I have tested

works great
Volume up on macbook
Volume up on Nuphy
CMD on macbook + Volume up on macbook

ignores CMD key and does the same as if I'd only pushed volume up
CMD on Nuphy + Volume up on Nuphy
CMD on Nuphy + Volume up on macbook
CMD on macbook + Volume up on Nuphy
CMD on windows keyboard + Volume up on macbook

[alberti42]

Interesting. I am sure we can get this to work. We only need to check what internal flags it generates when you press these keys.

[cherdarchuk]

Let me know if I can help in any way