-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Description
Hi there, thank you very much for this powerful, simple and impressively compact library! Just a minor issue, we get compile warnings under clang 14:
/xxx/libs/cpp/threadpool/threadpool.hpp:177:28: warning: explicitly defaulted move assignment operator is implicitly deleted [-Wdefaulted-function-deleted]
DispatchGroup& operator = (DispatchGroup&& DP) = default;
^
/xxx/libs/cpp/threadpool/threadpool.hpp:240:31: note: move assignment operator of 'DispatchGroup' is implicitly deleted because field '_closed' has a deleted move assignment operator
std::atomic<bool> _closed;
^
/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/atomic:73:13: note: 'operator=' has been explicitly marked deleted here
atomic& operator=(const atomic&) = delete;
So to my understanding we could simply remove the move operator from the default assignment:
- DispatchGroup& operator = (DispatchGroup&& DP) = default;
------
+ DispatchGroup& operator = default;
Best wishes
Metadata
Metadata
Assignees
Labels
No labels