From df0512dee40a68a5fb70b8d19f1ee0e96c75d5e4 Mon Sep 17 00:00:00 2001 From: tom Date: Thu, 3 Dec 2015 12:11:02 -0800 Subject: [PATCH 1/4] fill height on initial load --- src/fill-height.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/fill-height.js b/src/fill-height.js index ecac276..c1c2174 100644 --- a/src/fill-height.js +++ b/src/fill-height.js @@ -17,6 +17,8 @@ angular.element($window).on('resize', debounce(onWindowResize, scope.debounceWait || 250)); } + angular.element($window).on('load', debounce(onWindowResize, scope.debounceWait || 250)); + onWindowResize(); // returns a fn that will trigger 'time' amount after it stops getting called. From 62cbd13539a4e80740bfe20f54dd483c0d3e235e Mon Sep 17 00:00:00 2001 From: tom Date: Thu, 3 Dec 2015 14:05:47 -0800 Subject: [PATCH 2/4] cleaner initial conditions --- src/fill-height.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/fill-height.js b/src/fill-height.js index c1c2174..4face32 100644 --- a/src/fill-height.js +++ b/src/fill-height.js @@ -17,10 +17,8 @@ angular.element($window).on('resize', debounce(onWindowResize, scope.debounceWait || 250)); } - angular.element($window).on('load', debounce(onWindowResize, scope.debounceWait || 250)); - - onWindowResize(); - + angular.element($window).on('ready', onWindowResize); + // returns a fn that will trigger 'time' amount after it stops getting called. function debounce(fn, time) { var timeout; @@ -61,7 +59,7 @@ - footerElementHeight - additionalPadding; - console.log(elementHeight); + //console.info(elementHeight); element.css('height', elementHeight + 'px'); } From 86e8c203c7d4ac97d3530d684c6f60d0a0aa30eb Mon Sep 17 00:00:00 2001 From: tom Date: Thu, 3 Dec 2015 14:17:25 -0800 Subject: [PATCH 3/4] load error fix --- src/fill-height.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/fill-height.js b/src/fill-height.js index 4face32..e32bfb7 100644 --- a/src/fill-height.js +++ b/src/fill-height.js @@ -17,7 +17,7 @@ angular.element($window).on('resize', debounce(onWindowResize, scope.debounceWait || 250)); } - angular.element($window).on('ready', onWindowResize); + angular.element($window).on('load', onWindowResize); // returns a fn that will trigger 'time' amount after it stops getting called. function debounce(fn, time) { From 8f32fd1e0540be5544a1f0571453112a0c3fa1a8 Mon Sep 17 00:00:00 2001 From: tom Date: Thu, 24 Dec 2015 12:56:52 -0800 Subject: [PATCH 4/4] rename function to work with debounce. run once on document load properly. --- src/fill-height.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/fill-height.js b/src/fill-height.js index e32bfb7..12e37f7 100644 --- a/src/fill-height.js +++ b/src/fill-height.js @@ -10,14 +10,15 @@ }, link: function (scope, element, attrs) { if (scope.debounceWait === 0) { - angular.element($window).on('resize', windowResize); + angular.element($window).on('resize', onWindowResize); } else { // allow debounce wait time to be passed in. // if not passed in, default to a reasonable 250ms angular.element($window).on('resize', debounce(onWindowResize, scope.debounceWait || 250)); } - angular.element($window).on('load', onWindowResize); + //call once the DOM is ready + $timeout(onWindowResize); // returns a fn that will trigger 'time' amount after it stops getting called. function debounce(fn, time) {