[CALCITE-7136] Add Support for Druid Double Types#82
Merged
F21 merged 1 commit intoapache:mainfrom Aug 25, 2025
Merged
Conversation
mihaibudiu
reviewed
Aug 15, 2025
mihaibudiu
left a comment
There was a problem hiding this comment.
Is there a test you can write to show that this works?
Member
|
The driver supports Phoenix, HSQLDB and "Generic", with the code to map the columns for each type of database here:
We do have tests against HSQLDB and Phoenix:
However, we don't have tests for the generic mapping as there is no "generic" database to test against. If we test against a specific database, then we should have a mapping for that database, rather than use generic. I am happy to accept the PR as it currently stands, but the commit message needs to be updated to the format: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the std golang sql package,
Scanfunctionality will quietly fail and the zero value will be used.During the prepare phase of the sql request the correct types are returned.
xxx_hidden_ColumnClassName ="java.lang.Double"
xxx_hidden_Name ="DOUBLE"
xxx_hidden_Rep =Rep_NUMBER (22)
Special handling already exists for things such as floats and reals. Adding a doubles case solves the issue.