Skip to content

[Build] branch-1.5 build fail on macOS due to breaking change introduced by glog #11763

@xumingming

Description

@xumingming

Problem description

When I build branch-1.5 on macOS with the following command:

./dev/buildbundle-veloxbe.sh --spark_version=3.3 --run_setup_script=ON --build_arrow=ON

It fails with the following error:

<glog/logging.h> was not included correctly. See the document in the comment of logging.h for detail.

The root cause is clear(facebookincubator/velox#16165), and it is already solved by velox.

But if I manually apply the fix to the velox_ep under gluten directory, it would be overwritten automatically by the get_velox.sh build script, so I propose to add a new switch: --skip_get_velox to skip the get velox step, it will make it easier to handle this kind of build issues.

System information

N/A

CMake log

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions