No bookmarks serialization when closing/opening buffers

[solendil]

How to reproduce:

• Open a buffer from project
• Set a bookmark
• Close buffer, open it again
• The bookmark is gone

After looking at the code: it seems the serialization mechanism is based on TextEditor.id; but this value now changes when a buffer is closed/reopened. The serialization should be linked to a more permanent attribute of buffers. Long name, maybe? Though it poses a problem with untitled buffers and problems with renaming/moving/etc...

[solendil]

After a talk with lee-dohm on Slack, it seems serialization only works when closing/reopening atom.
Serialization is not supposed to work when closing/opening a buffer. There's even an old closed bug about the subject (#20). However I feel it would be an improvement, and I propose to flag this issue as an enhancement

[lpireyn]

Any news on this issue?

The bookmarks package is basically useless if bookmarks are not properly stored when a buffer is closed.

[amilner42]

It seems at minimum this would be a really nice to have this as a checkbox to be an option. May I ask why is this issue closed?

[sb810]

Bump. There's an alternative package persistent-bookmarks on Atom but it doesn't come close to the 'official' in terms of support and features. A shame, since I work remotely this is a huge dealbreaker :(