From 4e160e30362c322a5b7aed8c2b3aee8a3ac49b59 Mon Sep 17 00:00:00 2001 From: Jericho Tolentino <68654047+jericht@users.noreply.github.com> Date: Tue, 10 Mar 2026 18:58:41 +0000 Subject: [PATCH] chore: make virtualenv<21 pin conditional on Python < 3.10 Use PEP 508 environment markers to only pin virtualenv<21 for Python versions less than 3.10, as virtualenv 21+ dropped Python 3.8 support. This allows Python 3.10+ to use the latest virtualenv while maintaining compatibility with Python 3.8 and 3.9. Signed-off-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com> --- .github/workflows/reusable_prerelease.yml | 2 +- .github/workflows/reusable_publish.yml | 4 ++-- .github/workflows/reusable_publish_v2.yml | 4 ++-- .github/workflows/reusable_python_build.yml | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/reusable_prerelease.yml b/.github/workflows/reusable_prerelease.yml index 679a967..5ab7e58 100644 --- a/.github/workflows/reusable_prerelease.yml +++ b/.github/workflows/reusable_prerelease.yml @@ -25,7 +25,7 @@ jobs: - name: Build run: | - pip install --upgrade hatch "virtualenv<21" + pip install --upgrade hatch 'virtualenv<21; python_version < "3.10"' hatch -v build # A precommit hook into the GitHub Action workflow. diff --git a/.github/workflows/reusable_publish.yml b/.github/workflows/reusable_publish.yml index 862c8d7..a7cce57 100644 --- a/.github/workflows/reusable_publish.yml +++ b/.github/workflows/reusable_publish.yml @@ -102,7 +102,7 @@ jobs: # Tag must be made before building so the generated _version.py files have the correct version - name: Build run: | - pip install --upgrade hatch "virtualenv<21" + pip install --upgrade hatch 'virtualenv<21; python_version < "3.10"' hatch -v build # A precommit hook into the GitHub Action workflow. @@ -210,7 +210,7 @@ jobs: - name: Install dependencies run: | - pip install --upgrade hatch "virtualenv<21" + pip install --upgrade hatch 'virtualenv<21; python_version < "3.10"' pip install --upgrade twine - name: Build diff --git a/.github/workflows/reusable_publish_v2.yml b/.github/workflows/reusable_publish_v2.yml index 4e2ec67..a05a0d8 100644 --- a/.github/workflows/reusable_publish_v2.yml +++ b/.github/workflows/reusable_publish_v2.yml @@ -103,7 +103,7 @@ jobs: - name: Build run: | - pip install --upgrade hatch "virtualenv<21" + pip install --upgrade hatch 'virtualenv<21; python_version < "3.10"' hatch -v build # A precommit hook into the GitHub Action workflow. @@ -308,7 +308,7 @@ jobs: - name: Install dependencies run: | - pip install --upgrade hatch "virtualenv<21" + pip install --upgrade hatch 'virtualenv<21; python_version < "3.10"' pip install --upgrade twine - name: Download diff --git a/.github/workflows/reusable_python_build.yml b/.github/workflows/reusable_python_build.yml index 26ba4c6..3657034 100644 --- a/.github/workflows/reusable_python_build.yml +++ b/.github/workflows/reusable_python_build.yml @@ -65,7 +65,7 @@ jobs: - name: Install Hatch run: | - pip install --upgrade hatch "virtualenv<21" + pip install --upgrade hatch 'virtualenv<21; python_version < "3.10"' - name: Run Linting run: hatch -v run lint