From cc7ca5b8e4e9256db168e25c26c05f6afc5c07c7 Mon Sep 17 00:00:00 2001 From: ankit-amazon <125257518+ankit-amazon@users.noreply.github.com> Date: Tue, 9 May 2023 18:44:18 +0530 Subject: [PATCH 1/2] Improve compliant and noncompliant examples for python/missing-seed-in-pytorch-random-number-generator Addressed review comments --- ...sing_seed_in_pytorch_random_number_generator.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/python/detectors/missing_seed_in_pytorch_random_number_generator/missing_seed_in_pytorch_random_number_generator.py b/src/python/detectors/missing_seed_in_pytorch_random_number_generator/missing_seed_in_pytorch_random_number_generator.py index 56e5ab3..8b9763f 100644 --- a/src/python/detectors/missing_seed_in_pytorch_random_number_generator/missing_seed_in_pytorch_random_number_generator.py +++ b/src/python/detectors/missing_seed_in_pytorch_random_number_generator/missing_seed_in_pytorch_random_number_generator.py @@ -13,9 +13,15 @@ def missing_seed_in_pytorch_random_number_generator_noncompliant(): # {fact rule=missing-seed-in-pytorch-random-number-generator@v1.0 defects=0} def missing_seed_in_pytorch_random_number_generator_compliant(): import torch - seed = 42 + import numpy as np + import random + # Compliant: seed has been set. - torch.manual_seed(seed) - tensor_2 = torch.rand(2) - print(tensor_2) + np.random.seed(10) + torch.manual_seed(5) + random.seed(10) + + x = np.random.randint(3,2) + y = torch.svd_lowrank(x, q=2) + z = random.randrange(1,8) # {/fact} From 47834f38aee79a2dbfe783c853f341b10fa251b3 Mon Sep 17 00:00:00 2001 From: ankit-amazon <125257518+ankit-amazon@users.noreply.github.com> Date: Tue, 9 May 2023 19:08:45 +0530 Subject: [PATCH 2/2] Update missing_seed_in_pytorch_random_number_generator.py --- .../missing_seed_in_pytorch_random_number_generator.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/python/detectors/missing_seed_in_pytorch_random_number_generator/missing_seed_in_pytorch_random_number_generator.py b/src/python/detectors/missing_seed_in_pytorch_random_number_generator/missing_seed_in_pytorch_random_number_generator.py index 8b9763f..052cb7c 100644 --- a/src/python/detectors/missing_seed_in_pytorch_random_number_generator/missing_seed_in_pytorch_random_number_generator.py +++ b/src/python/detectors/missing_seed_in_pytorch_random_number_generator/missing_seed_in_pytorch_random_number_generator.py @@ -21,7 +21,7 @@ def missing_seed_in_pytorch_random_number_generator_compliant(): torch.manual_seed(5) random.seed(10) - x = np.random.randint(3,2) + x = np.random.randint(3, 2) y = torch.svd_lowrank(x, q=2) - z = random.randrange(1,8) + z = random.randrange(1, 8) # {/fact}