Bazel run `android_application` fails on `java` location

[pswaminathan]

$ bazel run //:myapp
INFO: Analyzed target //:myapp (1253 packages loaded, 63336 targets configured).
...
INFO: Found 1 target...
Target //src/main/kotlin/com/ergatta/airborne:aab up-to-date:
  bazel-bin/src/main/kotlin/com/ergatta/airborne/aab.sh
  bazel-bin/src/main/kotlin/com/ergatta/airborne/aab_unsigned.aab
INFO: Elapsed time: 206.665s, Critical Path: 85.06s
INFO: 3741 processes: 2689 action cache hit, 3180 remote cache hit, 2 internal, 522 darwin-sandbox, 37 worker.
INFO: Build completed successfully, 3741 total actions

/private/var/tmp/_bazel_p/38fbac32ce3b415b3947148100343188/execroot/_main/bazel-out/darwin_arm64-opt-ST-ea83daaeb883/bin/src/main/kotlin/com/ergatta/airborne/aab.sh: line 40: external/rules_java++toolchains+remotejdk17_macos_aarch64/bin/java: No such file or directory

Relevant (maybe) .bazelrc lines, taken from Aspect's bazelrc presets:

# What version of Java are the source files in this repo?
# See https://bazel.build/docs/user-manual#java-language-version
common --java_language_version=17

# The Java language version used to build tools that are executed during a build
# See https://bazel.build/docs/user-manual#tool-java-language-version
common --tool_java_language_version=17

# The version of JVM to use to execute the code and run the tests.
# NB: The default value is local_jdk which is non-hermetic.
# See https://bazel.build/docs/user-manual#java-runtime-version
common --java_runtime_version=remotejdk_17

# The version of JVM used to execute tools that are needed during a build.
# See https://bazel.build/docs/user-manual#tool-java-runtime-version
common --tool_java_runtime_version=remotejdk_17

# Repository rules, such as rules_jvm_external: put Bazel's JDK on the path.
# Avoids non-hermeticity from dependency on a JAVA_HOME pointing at a system JDK
# see https://github.com/bazelbuild/rules_jvm_external/issues/445
common --repo_env=JAVA_HOME=../bazel_tools/jdk

[ted-xie]

I took a crack at this and ran out of time; I may pick it up again later. Basically the issue is that when the android_application rule constructs the shell runner, it uses the path to the JDK's java binary for the rule's java toolchain. Inside of the Google monorepo this is just a path to a file like //path/to/jdk/java, but since the JDK is loaded "externally" for most Bazel apps, the path name has to be relative to bazel-bin.

So I fixed that part easily, but ran into other issues with bundletool. Maybe my SDK version is too old.

[ted-xie]

My WIP branch is here https://github.com/ted-xie/rules_android/tree/android_application_runner