Returns the same result for [] and {}

[jcward]

Not sure if this is desired behavior or not, but I'd assume that empty array [] and empty hash {} should be different.

Crimp.stringify([]) -> []Array
Crimp.stringify({}) -> []Array

[samfrench]

Hi @jcward, not too sure about this one. I agree if stringify'ing a hash then returning 'Array' is misleading, but I don't think this is main point of this. Stringify is used to just turn any object into a string. When you use sort on a hash you get an array back anyway, but that is another point.

Are you currently using stringify and need 'Hash' returned? If you need the type then I'd use {}.class which would be accurate.

I would make the stringify method private to allow the signature method only, but people might be consuming the stringify method now. If there is a need to specify Hash when using an original Hash then this can be looked at, but there is a reason why turning the Hash into an Array is implemented.

[jcward]

I'm just using stringify because it's easier to see what's happening under the hood than signature's hex output. Their equivalence is interchangeable (having the same string == having the same signature).

The jist of this issue is that Crimp considers [] the exact same as {} -- maybe that's the intent. Also, [{}] is the same as [[]], and {:foo=>[]} as {:foo=>{}}.

This issue is more about letting people know what they're getting with Crimp. Feel free to close as "as-designed".

For me, I expected a unique signature per any object I input. I wouldn't think [] == {} so I was surprised.