From 85273070f29985efd62a236138a7d7bf574514e1 Mon Sep 17 00:00:00 2001 From: Tobias Pfeiffer Date: Tue, 21 Oct 2025 21:38:03 +0200 Subject: [PATCH 1/4] Use fully released elixir 1.19 in CI --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 8014f52b..058476fa 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -42,7 +42,7 @@ jobs: otp_version: '27.3' type_check: true lint: true - - elixir_version: '1.19.0-rc.2' + - elixir_version: '1.19' otp_version: '28.1' steps: From b7ac9f034521a0b71e474c4b27dac09c1bec1fa7 Mon Sep 17 00:00:00 2001 From: Tobias Pfeiffer Date: Tue, 21 Oct 2025 21:43:02 +0200 Subject: [PATCH 2/4] Exclude tests from duplicated code check Sometimes tests are a bit repeated, and usually that is fine. --- .credo.exs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.credo.exs b/.credo.exs index 00894662..a5379f5c 100644 --- a/.credo.exs +++ b/.credo.exs @@ -71,7 +71,7 @@ # or the `schema` macro in Ecto schemas to trigger DuplicatedCode, just # set the `excluded_macros` parameter to `[:schema, :setup, :test]`. # - {Credo.Check.Design.DuplicatedCode, excluded_macros: []}, + {Credo.Check.Design.DuplicatedCode, excluded_macros: [], files: %{excluded: "test/**/*_test.exs"}}, # You can also customize the exit_status of each check. # If you don't want TODO comments to cause `mix credo` to fail, just # set this value to 0 (zero). From 9ca9ecd9c0f4e73934845c64787c8b3be9b019ef Mon Sep 17 00:00:00 2001 From: Tobias Pfeiffer Date: Tue, 21 Oct 2025 21:46:45 +0200 Subject: [PATCH 3/4] Also ignore formatters from duplicated code for now, fixing them is... a longer road to walk --- .credo.exs | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/.credo.exs b/.credo.exs index a5379f5c..d27f0a4d 100644 --- a/.credo.exs +++ b/.credo.exs @@ -71,7 +71,19 @@ # or the `schema` macro in Ecto schemas to trigger DuplicatedCode, just # set the `excluded_macros` parameter to `[:schema, :setup, :test]`. # - {Credo.Check.Design.DuplicatedCode, excluded_macros: [], files: %{excluded: "test/**/*_test.exs"}}, + { + Credo.Check.Design.DuplicatedCode, + excluded_macros: [], + files: %{ + excluded: [ + # Tests may have a bit of duplication, it's fine + "test/**/*_test.exs", + # Ah the formatters... we may want to make them nicer one of these days or use a library. + # But.. not now. + "lib/benchee/formatters/console/*.ex" + ] + } + }, # You can also customize the exit_status of each check. # If you don't want TODO comments to cause `mix credo` to fail, just # set this value to 0 (zero). From 48fa94b9891c415c56e9893e60792c2deb63e60d Mon Sep 17 00:00:00 2001 From: Tobias Pfeiffer Date: Tue, 21 Oct 2025 21:47:25 +0200 Subject: [PATCH 4/4] run type checks and lints on newest elixir & erlang --- .github/workflows/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 058476fa..ffe905d9 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -40,10 +40,10 @@ jobs: otp_version: '27.3' - elixir_version: '1.18' otp_version: '27.3' - type_check: true - lint: true - elixir_version: '1.19' otp_version: '28.1' + type_check: true + lint: true steps: - name: Checkout