Skip to content

Remove the use of inline-errors.js + convert JS to vanilla #10

@PubliAlex

Description

@PubliAlex

Hello,

First, thank you to take the lead to maintain the excellent magic form plugin for the october community.

As one of your plugin goal is to make it compatible with october cms 3, you should make some changes about javascript.

Remove inline-errors.js file
This is the role of the theme, and not a plugin to handle form errors, even if converted to vanilla js, the used classes are heavily opiniated to an old version of bootstrap, it should be removed.

Concert others scripts to vanilla js
As jquery is not needed anymore with october 3, you should convert all other JS to vanilla JS.

Best regards,

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions