error when using indexes

[keenahn]

const Foo = Temporal(sequelize.define('foo', {
  amount: {
    type: Sequelize.INTEGER,
    validate: { min: 0 },
    allowNull: false
  },
}, {
  indexes: [
    { fields: [ 'amount' ] },
  ],
}), sequelize)

This causes an error in postgres as it will say
Unhandled rejection SequelizeDatabaseError: relation "foo_amount" already exists

since it will try to create an index of the same name on the fooHistories table

[CanRau]

Same here, any workaround?
Changing this line to

historyOptions.indexes = indexes
  .filter(function(index) {
    return !index.unique && index.type != 'UNIQUE'
  })
  .map(function(index) {
    return Object.assign({}, index, { name: `${index.name}_temporal` })
  })

would work for me.
Any downsides to this?
I could prepare a PR if that'd help.

[ddolcimascolo]

Hi guys, sorry I left this issue behind...
The fix proposed above would work, but I'd rather suffix the index name by History to maintain consistency with the table names...

On a side note, I'm wondering if we should keep indices altogether. The history table is not supposed to be queried a lot, maybe simply not copying indices is easier.. WDYT?

In any case I'll be happy to merge a PR!

David

[CanRau]

Yea that was my first thought, dropping indices, not sure how exactly I personally plan on using them actually, the project is still POC so don't have any preferences at the moment. Edit: So, when dropping indices, how would one query the history efficiently?

[ddolcimascolo]

Querying the history table is not something you're doing that often, or are you?
Anyway, I'm fine keeping the indices on the history table.

[CanRau]

Sorry for being late 🙏As mentioned in my PR (#21) I dropped Sequelize altogether so if you decide what you prefer I could push a PR to close that issue 😉

[mey-rbc]

Is this PR getting released? Definitely in need