Skip to content

[1.1.9] Misuse of semver #63

@antoinerousseau

Description

@antoinerousseau

This library was bumped from 1.1.8 to 1.1.9 which is a patch release (see semver), i.e. it should only fix bugs and the interface should not change.

Unfortunately, some method signatures changed which is a breaking change, such as params for initialize() and start() going from one object to 3 scalar params:

Image. Image

Besides, the documentation is not updated to reflect the change to initialize:
https://github.com/bridgefy/bridgefy-react-native/blob/main/README.md#initialization

Also, BridgefyEvents enum changed its values from camelCase to UPPER_CASE, e.g. BridgefyEvents.bridgefyDidStart => BridgefyEvents.BRIDGEFY_DID_START, and the doc still advises to use a NativeEventEmitter while it seems the new module is a TurboModule and the lib has methods like addEventListener() so it should be:

bridgefy.addEventListener(BridgefyEvents.BRIDGEFY_DID_START, callback);

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions