From 0f42f08acee3fbfb1b0bb0c5c9464fd1e0b72fd0 Mon Sep 17 00:00:00 2001 From: Byron Lin Date: Mon, 26 Apr 2021 17:17:39 -0700 Subject: [PATCH 1/3] Add code coverage badge --- .github/workflows/maven.yml | 2 +- README.md | 1 + pom.xml | 9 +++++++++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml index 458c11a..7738232 100644 --- a/.github/workflows/maven.yml +++ b/.github/workflows/maven.yml @@ -30,4 +30,4 @@ jobs: aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} aws-region: us-east-1 - name: Build with Maven - run: mvn -B package --file pom.xml -D region=us-east-1 -D ledgerSuffix=${{ matrix.java}}-${{ matrix.os }} + run: mvn -B package jacoco:report coveralls:report --file pom.xml -D region=us-east-1 -D ledgerSuffix=${{ matrix.java }}-${{ matrix.os }} -D coveralls.repoToken=${{ coveralls.repoToken }} diff --git a/README.md b/README.md index 363e4cb..f64bd02 100644 --- a/README.md +++ b/README.md @@ -7,6 +7,7 @@ control over transactions to group multiple executions within a transaction. [![Maven Central](https://maven-badges.herokuapp.com/maven-central/software.amazon.qldb/amazon-qldb-driver-java/badge.svg)](https://maven-badges.herokuapp.com/maven-central/software.amazon.qldb/amazon-qldb-driver-java) [![Javadoc](https://javadoc.io/badge2/software.amazon.qldb/amazon-qldb-driver-java/javadoc.svg)](https://javadoc.io/doc/software.amazon.qldb/amazon-qldb-driver-java) +[![Coverage Status](https://coveralls.io/repos/github/byronlin13/amazon-qldb-driver-java/badge.svg?branch=master)](https://coveralls.io/github/byronlin13/amazon-qldb-driver-java?branch=master) Version 1.x is still supported. diff --git a/pom.xml b/pom.xml index c989111..7603d24 100644 --- a/pom.xml +++ b/pom.xml @@ -70,6 +70,7 @@ 1.0.0 1.8.0 0.8.5 + placeholderToken 1.8 5.0.0-M4 5.6.2 @@ -231,6 +232,14 @@ + + org.eluder.coveralls + coveralls-maven-plugin + 4.3.0 + + ${coveralls.repoToken} + + org.apache.maven.plugins maven-checkstyle-plugin From 45b2dd4b0e72f2fb5812863f978dd057b115dfd3 Mon Sep 17 00:00:00 2001 From: Byron Lin Date: Mon, 26 Apr 2021 17:21:59 -0700 Subject: [PATCH 2/3] Correct secret variable name --- .github/workflows/maven.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml index 7738232..c2f5149 100644 --- a/.github/workflows/maven.yml +++ b/.github/workflows/maven.yml @@ -30,4 +30,4 @@ jobs: aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} aws-region: us-east-1 - name: Build with Maven - run: mvn -B package jacoco:report coveralls:report --file pom.xml -D region=us-east-1 -D ledgerSuffix=${{ matrix.java }}-${{ matrix.os }} -D coveralls.repoToken=${{ coveralls.repoToken }} + run: mvn -B package jacoco:report coveralls:report --file pom.xml -D region=us-east-1 -D ledgerSuffix=${{ matrix.java }}-${{ matrix.os }} -D coveralls.repoToken=${{ secrets.COVERALLS_REPOTOKEN }} From ef606935a03a3283cc9dd8284364e201f46c954a Mon Sep 17 00:00:00 2001 From: Byron Lin Date: Mon, 26 Apr 2021 17:38:41 -0700 Subject: [PATCH 3/3] Add dependency to fix coverall --- pom.xml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/pom.xml b/pom.xml index 7603d24..c13e4e0 100644 --- a/pom.xml +++ b/pom.xml @@ -71,6 +71,7 @@ 1.8.0 0.8.5 placeholderToken + 2.2.3 1.8 5.0.0-M4 5.6.2 @@ -236,6 +237,13 @@ org.eluder.coveralls coveralls-maven-plugin 4.3.0 + + + javax.xml.bind + jaxb-api + ${jaxb-api.version} + + ${coveralls.repoToken}