ddf test suite expansion

[SFJohnson24]

codelist_terms is not working with ddf after #1419 but the test suite did not catch this.
It seems like the DDF rules have been expanded a fair bit--it would be worthwhile to look at the rule coverage and diversify the test suite to cover more operators/operations (codelist_terms but potentially others) with DDF and update the positive/negative test suite data. Some JSONATA rules may also be a good idea to add since that coverage is lacking.

[ASL-rmarshall]

I plan to update the USDM test suite to:

• Include a more representative set of rules, including at least one example of each of the following:

  • Controlled terminology checks (both DDF and SDTM terminology)
  • JSONata rules
  • XHTML validation rules
  • JSON Schema Check rules

  As the test suite uses published rules, the updates for USDM will need to wait until we have published examples of the above rules

• Use the v4 combined clean/dirty files that Berber has been creating.

[BSnoeijerCD]

@SFJohnson24 @alexfurmenkov @ASL-rmarshall
Final clean and dirty test files attaches including indications of the errors to be produced. At the moment there are still 3 rules that do not produce the expected output as we are fixing them. But we expect that to have final by tomorrow.
At the moment the dirty file produces all the expected errors (except of the three mentioned) as I tested this afternoon.

CDISC_Pilot_Study_v4_FIXED.json

USDM_CORE_Rules_NegativeFileIssues.xlsx

[BSnoeijerCD]

@ASL-rmarshall @alexfurmenkov @SFJohnson24

Removed dirty file from previous comment and added here again because I missed 1 dot preventing a check from giving output.

CDISC_Pilot_Study_v4_Dirty.json

[alexfurmenkov]

@BSnoeijerCD thanks! @ASL-rmarshall can you please provide the rules?

[ASL-rmarshall]

@BSnoeijerCD Could you provide a list of the rules that report issues for the Dirty file (and don't for the FIXED file)?

[BSnoeijerCD]

@BSnoeijerCD Could you provide a list of the rules that report issues for the Dirty file (and don't for the FIXED file)?

@alexfurmenkov: it is included in the comment above: see USDM_CORE_Rules_NegativeFileIssues.xlsx

[alexfurmenkov]

@BSnoeijerCD Hi. The data you provided does not contain studyIdentifierScope.organizationType.code in the StudyVersion domain, compared to the older JSON file. This prevents the dataset from executing some rules. For example, rules CORE-000696 and CORE-000401 expect this field. The code fails because it is unable to execute the record_count operation based on all fields listed in the rule. At the end, since there is no "success" statuses in the rule run, the rule is marked as skipped by RuleValidationResult class.