Deprecate operators/operations/rule types that have preferred alternatives

[nhaydel]

• Determine strategy for deprecating operators/operations/rule types
• Create tickets for deprecating necessary operators/operations/rule types

[gerrycampion]

Some candidates for deprecation or replacement

Rule Types - Currently no rules are using these

• Not sure exactly how these would be used. They are using logic outside their rule builder:
  • Dataset Contents Check against Define XML and Library Metadata
  • Define Item Metadata Check
    - Value Level Metadata Check against Define XML
• We shouldn't currently have rules that only look at the define xml. Can probably be replaced by the current Rule Type: Dataset Metadata Check against Define XML. base_dataset_builder.get_define_xml_item_group_metadata/base_define_xml_reader.extract_domain_metadata and base_dataset_builder.get_define_metadata/base_define_xml_reader.read should probably be merged because they appear to be doing something very similar.
  • Define Item Group Metadata Check

Operations (#1619 did not make any alterations to operations)

• domain_is_custom (create library_ig_variable_attribute)
• domain_label (create library_ig_variable_attribute)
• expected_variables (create library_ig_filtered_variables)
• permissible_variables (create library_ig_filtered_variables)
• required_variables (create library_ig_filtered_variables)
• record_count (should come from extract_metadata)
• variable_permissibilities (create library_ig_variable_attribute)

Operators

• is_unique_set, present_on_multiple_rows_within
• is_ordered_by, is_ordered_set, target_is_sorted_by (subtle differences, could be combined)
• conformant_value_data_type, conformant_value_length, references_correct_codelist, uses_valid_codelist_terms (use rule type)

[nhaydel]

@gerrycampion can you describe what the alternatives would be for the rule types

[SFJohnson24]

#1619 does not completely address this ticket but it does address some of the Rule types and check operators. We should later address the operation deprecation @gerrycampion mentioned. Currently--there are rules written using these operations and this seems like a post-1.0 issue