Skip to content

Suggestion: when external dictionary cannot be read, CORE execution should not crash #983

@JozefAerts

Description

@JozefAerts

I observed that when the path to an external dictionary (e.g. MedDRA) is not correct, the core execution crashes with e.g.
Traceback (most recent call last):
File "core.py", line 877, in
File "click\core.py", line 1157, in call
File "click\core.py", line 1078, in main
File "click\core.py", line 1688, in invoke
File "click\core.py", line 1434, in invoke
File "click\core.py", line 783, in invoke
File "click\decorators.py", line 33, in new_func
File "core.py", line 315, in validate
File "scripts\run_validation.py", line 127, in run_validation
File "scripts\script_utils.py", line 150, in fill_cache_with_dictionaries
File "cdisc_rules_engine\models\dictionaries\get_dictionary_terms.py", line 16, in extract_dictionary_terms
File "cdisc_rules_engine\models\dictionaries\meddra\meddra_terms_factory.py", line 67, in install_terms
cdisc_rules_engine.exceptions.custom_exceptions.MissingDataError
[PYI-13240:ERROR] Failed to execute script 'core' due to unhandled exception!

I would propose that in such a case, this is "catched" (Python "Try-Except"?) and that a warning is written to the log file, and that rules that use the library are then automatically skipped.

Metadata

Metadata

Assignees

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions