What to do with Sonarqube "performance" rules

[MP-Aubay]

Hello,

As discussed in this PR, how do we handle performance rules already existing in Sonarqube ?

From EcoCode point of view, maybe all performance rules are not relevant, but in theory if you work on performance you should have a gain on the machine consumption.

For example the rule "Strings should not be concatenated using '+' in a loop" already exists, but we try to create the rule (in the linked PR), I think it is a bad idea to create our own code for this rule.

So what to do ?

• Do we list all relevant rules somewhere in EcoCode ?
• Do we duplicate rules in EcoCode ? (using existing code)
• Do we just avoid duplicating the rules ?
• Something else ?

The main purpose is to avoid unnecessary work, coding already existing rules.

Regards,
Mikaël

[glalloue]

Hi @MP-Aubay
Thanks for your comment.
That's a very interesting remark !
For the moment we don't have specific answer on this subject and we need to discuss about it.

If you want to join us and discuss on this subject to help us find a good answer you're welcome to join our slack.
i can send you an invitation to the email wrote on your github profile if you want.

i keep your question opened to write answer when we will be ready

[MP-Aubay]

Hi @glalloue,

I will be glad to join your slack :)

[glalloue]

See you soon ;)