WaterRower React project

[danydhondt]

Hi,
Thanks for building this library. It is exactly what I'm looking for.
I want to make a client in React.
What I did so far:

• Created a new React project with create-react-app
• Added your library using yarn add https://github.com/codefoster/waterrower.git
• Then, even without importing anything, just running the basic app, I get this error:
  ./node_modules/waterrower/lib/index.js Module not found: Can't resolve 'readline' in '/Volumes/Macintosh HD SSD/Documenten/WEB/Archemedia waterrower/waterrower/node_modules/waterrower/lib'

Any idea?
Thanks

[codefoster]

I think it has to do with the serial library. Try installing it explicitly.

…

________________________________ From: Dany Dhondt <notifications@github.com> Sent: Saturday, March 23, 2019 1:48:56 AM To: codefoster/waterrower Cc: Subscribed Subject: [codefoster/waterrower] Waterpower React project (#16) Hi, Thanks for building this library. It is exactly what I'm looking for. I want to make a client in React. What I did so far: * Created a new React project with create-react-app * Added your library using yarn add https://github.com/codefoster/waterrower.git * Then, even without importing anything, just running the basic app, I get this error: ./node_modules/waterrower/lib/index.js Module not found: Can't resolve 'readline' in '/Volumes/Macintosh HD SSD/Documenten/WEB/Archemedia waterrower/waterrower/node_modules/waterrower/lib' Any idea? Thanks — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcodefoster%2Fwaterrower%2Fissues%2F16&data=02%7C01%7C%7C0850fd7b2e2145c4bb3408d6af6c63f9%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636889277394329656&sdata=wSzOo6jgTkFxOHb7q8rR7Pqh1kB%2FNs3tCuiQdzvmw%2BQ%3D&reserved=0>, or mute the thread<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABbO_V1FIOr_vj11RFbwShVioKJcnP8gks5vZep4gaJpZM4cEzKO&data=02%7C01%7C%7C0850fd7b2e2145c4bb3408d6af6c63f9%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636889277394339655&sdata=ffGjxYvivw5ckhTzeAtBt%2FH9EOlBEx%2BGAGNTbdLCGBE%3D&reserved=0>.

[danydhondt]

did you mean serialor serialport?

[danydhondt]

I tried both but still get the same error unfortunately.
I've made a codesandbox but that gave me another error.

[danydhondt]

one step further: the missing package appeared to be readline. I added it manually and now the app compiles but still got other errors. I'll try to sort them.

[danydhondt]

Unhandled Rejection (TypeError): Error.captureStackTrace is not a function. (In 'Error.captureStackTrace(dummy)', 'Error.captureStackTrace' is undefined)
▼ 10 stack frames were expanded.
getFileName
node_modules/bindings/bindings.js:135
bindings
node_modules/bindings/bindings.js:59
./node_modules/@serialport/bindings/lib/linux.js
node_modules/@serialport/bindings/lib/linux.js:13
__webpack_require__
/Volumes/Macintosh HD SSD/Documenten/WEB/Archemedia waterrower/waterrower/webpack/bootstrap:786
fn
/Volumes/Macintosh HD SSD/Documenten/WEB/Archemedia waterrower/waterrower/webpack/bootstrap:149
(anonymous function)
node_modules/@serialport/bindings/lib/index.js:16
./node_modules/@serialport/bindings/lib/index.js
http://localhost:3000/static/js/1.chunk.js:1475:34
__webpack_require__
/Volumes/Macintosh HD SSD/Documenten/WEB/Archemedia waterrower/waterrower/webpack/bootstrap:786
fn
/Volumes/Macintosh HD SSD/Documenten/WEB/Archemedia waterrower/waterrower/webpack/bootstrap:149
./node_modules/serialport/lib/index.js
node_modules/serialport/lib/index.js:3
▲ 10 stack frames were expanded.
This screen is visible only in development. It will not appear if the app crashes in production.
Open your browser’s developer console to further inspect this error.

This is a difficult one. I guess it has to do with webpack.

I would like to get this library to run in React because then a great app could be build on top of your library.

[codefoster]

Sorry I let this slide. Can you tell me the latest status of your effort to port to React?