From abaadad590b66fbd89bd3f0bf60ea04d14da67d8 Mon Sep 17 00:00:00 2001 From: Sebastian Sosnowski Date: Tue, 6 Jan 2026 18:32:06 +0100 Subject: [PATCH 1/2] Add maxOfVector implementation --- homework/max-of-vector/maxOfVector.hpp | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/homework/max-of-vector/maxOfVector.hpp b/homework/max-of-vector/maxOfVector.hpp index f82fb2a1..61afecc8 100644 --- a/homework/max-of-vector/maxOfVector.hpp +++ b/homework/max-of-vector/maxOfVector.hpp @@ -1,8 +1,20 @@ #pragma once +#include #include #include int maxOfVector(const std::vector& vec) { - // TODO: Implement me :) - return {}; + // manual solution + // if (vec.empty()) { + // return {}; + // } + // int max_value{vec[0]}; + // for (const int& num : vec) { + // max_value = std::max(max_value, num); + // } + auto it_max = std::max_element(vec.begin(), vec.end()); + if (it_max == vec.end()) { + return 0; + } + return *it_max; } From cebfa5b589d3036cd141a0f3b7bac843affb4f4f Mon Sep 17 00:00:00 2001 From: Sebastian Sosnowski Date: Tue, 6 Jan 2026 18:32:36 +0100 Subject: [PATCH 2/2] Add testcase for empty vector --- homework/max-of-vector/test.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/homework/max-of-vector/test.cpp b/homework/max-of-vector/test.cpp index 3df9a620..4e39c891 100644 --- a/homework/max-of-vector/test.cpp +++ b/homework/max-of-vector/test.cpp @@ -17,6 +17,7 @@ INSTANTIATE_TEST_SUITE_P( MaxOfVectorTests, MaxOfVectorTestFixture, ::testing::Values( + std::make_tuple(std::vector{}, 0), std::make_tuple(std::vector{0}, 0), std::make_tuple(std::vector{0, -1}, 0), std::make_tuple(std::vector{0, 1}, 1),