update with --due seems to be off by one day

[adius]

When I run ghm milestone update 2017-W33 --due 2017-08-21 the due date on GitHub is displayed as 2017-08-20. Seems like a misunderstanding what the term due date means. (inclusive or exclusive) 🙈

[getvega]

Hmm I do not process the date at all - we just forward it to the Github API which parses it in UTC. https://developer.github.com/v3/issues/milestones/#update-a-milestone

So I think it's more of a timezone issue here we should read it using machine's timezone and forward it properly. Is it what happened to you @adius? (what's your timezone?)

[adius]

All my digital devices are set to UTC. Exactly to avoid any timezone issues =D

[adius]

I ran ghm milestone update 2017-W33 --due 2017-08-22 and the GitHub milestones API returns "due_on": "2017-08-21T07:00:00Z",

[adius]

Also running ghm milestone update 2017-W33 --due '2017-08-21T00:00:00.000' doesn't change it

[getvega]

@adius would you be interested in becoming a maintainer of this project?

[adius]

If you are OK with me changing the style guide to https://github.com/style-guides/JavaScript 😉