From 827a097d7da4a40355bf0d8101d7479641436c51 Mon Sep 17 00:00:00 2001 From: kpenfound Date: Mon, 15 Sep 2025 15:16:09 -0400 Subject: [PATCH 1/2] remove unnecessary engine-stop Signed-off-by: kpenfound --- README.md | 5 ++--- action.yml | 11 +---------- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/README.md b/README.md index ea2f8eb..c442591 100644 --- a/README.md +++ b/README.md @@ -11,7 +11,7 @@ module: github.com/shykes/daggerverse/hello call: hello --greeting Hola --name Jeremy cloud-token: ${{ secrets.DAGGER_CLOUD_TOKEN }} - version: "latest" # semver x.y.z + version: "latest" # semver vX.Y.Z ``` ### `dagger run` @@ -24,7 +24,7 @@ verb: run args: node build.js cloud-token: ${{ secrets.DAGGER_CLOUD_TOKEN }} - version: "latest" # semver x.y.z + version: "latest" # semver vX.Y.Z ``` ### Staying in sync with the `latest` version @@ -44,4 +44,3 @@ By setting the version to `latest`, this action will install the latest version | `module` | Dagger module to call. Local or Git | false | '' | | `args` | Arguments to pass to CLI | false | '' | | `call` | Arguments to pass to CLI (Alias for args) | false | '' | -| `engine-stop` | Whether to stop the Dagger Engine after this run | false | 'true' | diff --git a/action.yml b/action.yml index 03191cf..f3e29fb 100644 --- a/action.yml +++ b/action.yml @@ -33,9 +33,8 @@ inputs: required: false default: "" engine-stop: - description: "Whether to stop the Dagger Engine after this run" + description: "Deprecated" required: false - default: "true" call: description: "Function and arguments for dagger call" required: false @@ -107,11 +106,3 @@ runs: if [[ -n "$trace_url" ]]; then echo "traceURL=$trace_url" >> "$GITHUB_OUTPUT" fi - - - if: (inputs.call != '' || inputs.args != '') && inputs.engine-stop == 'true' - shell: bash - run: | - mapfile -t containers < <(docker ps --filter name="dagger-engine-*" -q) - if [[ "${#containers[@]}" -gt 0 ]]; then - docker stop -t 300 "${containers[@]}"; - fi From 05c71f3b926bfe8e19e8ab8ad5f1cedf78239cff Mon Sep 17 00:00:00 2001 From: kpenfound Date: Mon, 15 Sep 2025 16:03:17 -0400 Subject: [PATCH 2/2] add deprecationMessage Signed-off-by: kpenfound --- action.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/action.yml b/action.yml index f3e29fb..9b12085 100644 --- a/action.yml +++ b/action.yml @@ -34,6 +34,7 @@ inputs: default: "" engine-stop: description: "Deprecated" + deprecationMessage: "engine-stop is now a no-op and will be removed in a future release" required: false call: description: "Function and arguments for dagger call"