From 43bba93b2e30509a560c7baf282bcc5699719ceb Mon Sep 17 00:00:00 2001 From: Anders Holmgren Date: Thu, 19 Nov 2015 17:56:25 +1100 Subject: [PATCH 1/2] add value property --- lib/src/react/react_element.dart | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/lib/src/react/react_element.dart b/lib/src/react/react_element.dart index e8b9c80..78b1d7d 100644 --- a/lib/src/react/react_element.dart +++ b/lib/src/react/react_element.dart @@ -8,24 +8,27 @@ class ReactElement {} class Props { external bool get disabled; external String get className; + external String get value; external Function get onClick; external Function get onChange; - external factory Props({String className, bool disabled, Function onClick, - Function onChange}); + external factory Props({String className, bool disabled, String value, + Function onClick, Function onChange}); } -Props _props({String className, bool disabled, void onClick(EventHandler event), +Props _props({String className, bool disabled, String value, + void onClick(EventHandler event), void onChange(EventHandler event)}) { - return new Props(className: className, disabled: disabled, onClick: _wrapEventHandler(onClick), + return new Props(className: className, disabled: disabled, value: value, + onClick: _wrapEventHandler(onClick), onChange: allowInterop(onChange)); } ReactElement createElement(typeOrClass, [Map props, children]) { var interopProps = new Props(); if (props != null) { - interopProps = _props(className: props["className"], onClick: props["onClick"], - onChange: props["onChange"]); + interopProps = _props(className: props["className"], value: props["value"], + onClick: props["onClick"], onChange: props["onChange"]); } return internal.createElement(typeOrClass, interopProps, children); } From 37cbfffd89e8ba21cf9d61f2f5a72193be95b0af Mon Sep 17 00:00:00 2001 From: Anders Holmgren Date: Sat, 21 Nov 2015 11:15:35 +1100 Subject: [PATCH 2/2] Fix types for onClick and onChange. Thanks to the first dev release of 1.14 for catching this --- lib/src/react/react_element.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/src/react/react_element.dart b/lib/src/react/react_element.dart index 78b1d7d..2300fc5 100644 --- a/lib/src/react/react_element.dart +++ b/lib/src/react/react_element.dart @@ -17,8 +17,8 @@ class Props { } Props _props({String className, bool disabled, String value, - void onClick(EventHandler event), - void onChange(EventHandler event)}) { + EventHandler onClick, + EventHandler onChange}) { return new Props(className: className, disabled: disabled, value: value, onClick: _wrapEventHandler(onClick), onChange: allowInterop(onChange));