Issues in the expl3 code detected with explcheck

[Witiko]

Dear @dcpurton,

I am writing as a developer of expltools, which includes the static analysis tool explcheck for the expl3 programming language.

In February, we launched a public website that aggregates all issues detected in the current TeX Live distribution by explcheck. According to our report, scripture currently triggers 18 errors and 105 warnings.

I wanted to bring these issues to your attention in case you wanted to fix them or even use explcheck in your development process. Please, let me know if you wanted my feedback on any of these issues or provide your own feedback.

[dcpurton]

@Witiko , Thanks. I didn't know about this tool.

I have been meaning to tidy up some of my laziness, but this highlighted everything.

However, I notice that it is not always reliable.

For example at present it warns about an unused variable or constant when in fact the variable is used.

This particular variable is a global variable declared with \dim_new:N.

In another style file I tested it on this also happens. As does the inverse problem of a complaint about setting an undeclared variable. This happens occasionally for variables declared in \keys_define:nn. At least on one occasion even when the variable is initialised with initial:n in \keys_define:nn.

[Witiko]

As you say, key--values are currently not analyzed, which may lead to some false positive detections.