Issue while calling *.upsert() after *.end()

[volodymyrdn]

Hi there. I have a short story to test the library:

import { StoryFn } from "@storybook/react-vite";
import { createCallable } from "react-call";
export default {
    title: "Dialog",
}

interface Props { message: string }
type Response = boolean

const MyDialog = createCallable<Props, Response>(({ call, message }) => {
    return (
        <div>
            <p>{message}</p>
            <button onClick={() => call.end(true)}>Yes</button>
            <button onClick={() => call.end(false)}>No</button>
        </div>
    )
})

const Template: StoryFn = () => {
    return (
        <>
            <button onClick={() => MyDialog.upsert({ message: new Date().toLocaleString() })}>Upsert Dialog</button >
            <button onClick={() => MyDialog.end(false)}>End Dialog</button>
            <MyDialog.Root />
        </>
    )
}

export const Primary: StoryFn = Template.bind({})

1. When I click Upsert Dialog button for the first time, the dialog is inserted as expected.
2. When I click Upsert Dialog button for the second time, the dialog is updated as expexted.
3. When I click End Dialog button, the dialog disappears as expected.
4. When I click Upsert Dialog button for the third time, the dialog is not inserted.

What am I doing wrong? Thanks in advance.

[flt3150sk]

@volodymyrdn

Thanks for reporting this issue! I've submitted a PR to fix it: #72

The bug was caused by the $upsertPromise not being cleared when end() was called externally, preventing subsequent upsert() calls from creating new instances.

[desko27]

Thanks to both of you for the detailed report and the solution! 👌 I can't look at it today, but I'll review it this week to get the fix published as soon as possible.