diff --git a/.github/workflows/formats.yml b/.github/workflows/formats.yml index b34b6ca..0c20d66 100644 --- a/.github/workflows/formats.yml +++ b/.github/workflows/formats.yml @@ -30,8 +30,5 @@ jobs: - name: Coding Style Checks run: composer test:lint - - name: Refactor Checks - run: composer test:refactor - - name: Type Checks run: composer test:types diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 1b60bdc..da2a368 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -9,7 +9,7 @@ jobs: fail-fast: true matrix: os: [ubuntu-latest] - php: [8.1, 8.2] + php: [8.1, 8.2, 8.3, 8.4] stability: [prefer-lowest, prefer-stable] name: Tests php@${{ matrix.php }} - ${{ matrix.os }} - ${{ matrix.stability }} diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2c267fa..115fbde 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -49,12 +49,6 @@ Run all tests: composer test ``` -Check code quality: - -```bash -composer test:refactor -``` - Check types: ```bash @@ -82,4 +76,4 @@ If you want to check things work against a specific version of PHP, you may incl docker compose build --build-arg PHP=8.2 ``` -The default PHP version will always be the lowest version of PHP supported by jira-php. \ No newline at end of file +The default PHP version will always be the lowest version of PHP supported by jira-php. diff --git a/composer.json b/composer.json index 0044f3a..bad666a 100644 --- a/composer.json +++ b/composer.json @@ -22,13 +22,12 @@ }, "require-dev": { "laravel/pint": "^1.2.0", + "mockery/mockery": "^1.6", "nunomaduro/collision": "^7.0.0", "pestphp/pest": "^2.0.0", - "pestphp/pest-plugin-mock": "^2.0.0", "phpstan/extension-installer": "^1.2", "phpstan/phpstan": "^1.8.6", "phpstan/phpstan-strict-rules": "^1.4", - "rector/rector": "^0.15", "symfony/var-dumper": "^6.2.0" }, "autoload": { @@ -56,14 +55,11 @@ }, "scripts": { "lint": "pint --preset laravel -v --ansi", - "refactor": "rector --debug --ansi", "test:lint": "pint --preset laravel --test -v --ansi", - "test:refactor": "rector --dry-run --ansi", "test:types": "phpstan analyse --ansi", "test:unit": "pest --colors=always --min=100 --order-by=random --coverage", "test": [ "@test:lint", - "@test:refactor", "@test:types", "@test:unit" ] diff --git a/rector.php b/rector.php deleted file mode 100644 index 2f41a3e..0000000 --- a/rector.php +++ /dev/null @@ -1,35 +0,0 @@ -paths([ - __DIR__.'/src', - ]); - - $rectorConfig->sets([ - SetList::CODE_QUALITY, - SetList::CODING_STYLE, - SetList::DEAD_CODE, - SetList::NAMING, - SetList::PRIVATIZATION, - SetList::TYPE_DECLARATION, - SetList::EARLY_RETURN, - LevelSetList::UP_TO_PHP_81, - ]); - - $rectorConfig->skip([ - EncapsedStringsToSprintfRector::class, - WrapEncapsedVariableInCurlyBracesRector::class, - FinalizeClassesWithoutChildrenRector::class, - ChangeAndIfToEarlyReturnRector::class, - ]); -}; diff --git a/src/Jira.php b/src/Jira.php index c62db06..0ae961e 100644 --- a/src/Jira.php +++ b/src/Jira.php @@ -19,7 +19,7 @@ public static function client(string $username, string $password, string $host): $headers = Headers::withAuthorization(basicAuthentication: $basicAuthentication); - $client = new GuzzleClient(); + $client = new GuzzleClient; $httpTransporter = new HttpTransporter(client: $client, baseUri: $baseUri, headers: $headers);