From 4efa7bc7240323591a7252fbbd9d5d86b8263422 Mon Sep 17 00:00:00 2001 From: Jacquelyn Turcinovic Date: Wed, 7 Nov 2018 12:42:53 -0500 Subject: [PATCH 1/5] added JT --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index f2f126e..adff7f5 100644 --- a/README.md +++ b/README.md @@ -99,6 +99,7 @@ Type: type ## Contributors - Dileep Kishore +- Jacquelyn Turcinovic ## Credits From 43f3abe694fb3cf37ce58e5e660c945fc20ef867 Mon Sep 17 00:00:00 2001 From: Jacquelyn Turcinovic Date: Wed, 7 Nov 2018 12:44:15 -0500 Subject: [PATCH 2/5] added HF --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index adff7f5..323cef2 100644 --- a/README.md +++ b/README.md @@ -99,7 +99,7 @@ Type: type ## Contributors - Dileep Kishore -- Jacquelyn Turcinovic +- Howard Fan ## Credits From 95a257880ea2b902bf0649ccdeeb59634867021e Mon Sep 17 00:00:00 2001 From: Jacquelyn Turcinovic Date: Wed, 7 Nov 2018 13:14:05 -0500 Subject: [PATCH 3/5] raise ValueError for unsupported methods --- movie_recommender/movie_recommender.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/movie_recommender/movie_recommender.py b/movie_recommender/movie_recommender.py index 8e3bcaf..71f5527 100644 --- a/movie_recommender/movie_recommender.py +++ b/movie_recommender/movie_recommender.py @@ -70,5 +70,7 @@ def movie_recommender( recommender = KeywordSimilarity(metadata, credits, keywords) elif method == "UserSimilarity": recommender = UserSimilarity(metadata, ratings, links) + else: + raise ValueError('Method {} not supported'.format(method)) print("Returning recommendations") return recommender(movie, nhits=nhits) From 838e1b6f2383eb9ec721088b75f416e717c59b44 Mon Sep 17 00:00:00 2001 From: Jacquelyn Turcinovic Date: Wed, 7 Nov 2018 13:19:53 -0500 Subject: [PATCH 4/5] added recommender save --- movie_recommender/movie_recommender.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/movie_recommender/movie_recommender.py b/movie_recommender/movie_recommender.py index 71f5527..91752a9 100644 --- a/movie_recommender/movie_recommender.py +++ b/movie_recommender/movie_recommender.py @@ -16,6 +16,7 @@ from .plot_similarity import PlotSimilarity from .keyword_similarity import KeywordSimilarity from .user_similarity import UserSimilarity +from .utils import save, load, search def movie_recommender( @@ -72,5 +73,7 @@ def movie_recommender( recommender = UserSimilarity(metadata, ratings, links) else: raise ValueError('Method {} not supported'.format(method)) + print("Saving recommendations") + save(recommender) print("Returning recommendations") return recommender(movie, nhits=nhits) From 1f3c422fc24688db64d1c1519fc720df65b84fc0 Mon Sep 17 00:00:00 2001 From: Jacquelyn Turcinovic Date: Wed, 7 Nov 2018 13:36:24 -0500 Subject: [PATCH 5/5] ignore pickled file --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 1c56d37..a64612b 100644 --- a/.gitignore +++ b/.gitignore @@ -7,3 +7,6 @@ raw_data/ # Cache __pycache__ .mypy_cache + +# ignore pickled +pickled*