one-step approve and auto-merge label?

[MartinNowak]

Would save a couple of clicks if we could merge approve and adding the auto-merge label into a single link or so.
dlang/phobos#5382 (comment)

[wilzbach]

Hmm, sometimes you just want to approve and wait until others object or there's a second approval. So

• approval -> auto-merge doesn't work

Moreover, adding a label "auto-merge-approved" and letting the Dlang-Bot approve the PR seems a bit confusing as well (especially because we currently query GitHub for the author of the approval to get the "merged-on-behalf-of" commit message).

So imho this is a won't fix - approving and adding the label doesn't that much time compared to the review anyways...

[MartinNowak]

Maybe we could exploit some CSRF on github and redirect a single button to perform both ;).

[MartinNowak]

Would be better to simplify the workflow than popping up a warning about auto-merge/approval missing.
In fact I'd take auto-merge as an implicit approval, b/c only maintainers can set it.

You could turn it the other way round and take an approval by a maintainer as an OK to auto-merge within 5 minutes, setting the label right away, so that people can remove it if that was unintended.

[wilzbach]

You could turn it the other way round and take an approval by a maintainer as an OK to auto-merge within 5 minutes, setting the label right away, so that people can remove it if that was unintended.

That would be really annoying, because I often review/approve PRs and when they are complicated I wait for a few days if other reviewers raise concerns.Though of course that could be automated too, but it hasn't been a huge problem so far.

[CyberShadow]

@thewilsonator @RazvanN7 Any thoughts?

[thewilsonator]

no, i don't think its needed,

[Geod24]

I wouldn't mind if the bot would set the label whenever I approve with a specific message (e.g. "Ready to merge" or "Merge") but I think there are other high prio item to address first.