From b1fb149cedbb0f577aab5e8fd58807a2bf177485 Mon Sep 17 00:00:00 2001 From: JinShil Date: Mon, 10 Dec 2018 13:14:07 +0900 Subject: [PATCH] Fix Issue 19471 - Duplicate error messages when trying to use an inaccessible package symbol --- src/dmd/dscope.d | 2 -- test/fail_compilation/fail313.d | 9 ++++----- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/dmd/dscope.d b/src/dmd/dscope.d index 3f4c7b0be9b7..0dc034271864 100644 --- a/src/dmd/dscope.d +++ b/src/dmd/dscope.d @@ -511,8 +511,6 @@ struct Scope if (!s) s = searchScopes(flags | SearchImportsOnly | IgnoreSymbolVisibility); - if (s && !(flags & IgnoreErrors)) - .deprecation(loc, "`%s` is not visible from module `%s`", s.toPrettyChars(), _module.toChars()); version (LOGSEARCH) if (s) printMsg("-Scope.search() found imported private symbol", s); } } diff --git a/test/fail_compilation/fail313.d b/test/fail_compilation/fail313.d index 81e6addd9704..2a53d245dcfc 100644 --- a/test/fail_compilation/fail313.d +++ b/test/fail_compilation/fail313.d @@ -1,11 +1,10 @@ /* TEST_OUTPUT: --- -fail_compilation/fail313.d(17): Error: module `imports.b313` is not accessible here, perhaps add `static import imports.b313;` -fail_compilation/fail313.d(24): Deprecation: `imports.a313.core` is not visible from module `test313` -fail_compilation/fail313.d(24): Error: package `core.stdc` is not accessible here -fail_compilation/fail313.d(24): Error: module `core.stdc.stdio` is not accessible here, perhaps add `static import core.stdc.stdio;` -fail_compilation/fail313.d(29): Error: package `imports.pkg313` is not accessible here, perhaps add `static import imports.pkg313;` +fail_compilation/fail313.d(16): Error: module `imports.b313` is not accessible here, perhaps add `static import imports.b313;` +fail_compilation/fail313.d(23): Error: package `core.stdc` is not accessible here +fail_compilation/fail313.d(23): Error: module `core.stdc.stdio` is not accessible here, perhaps add `static import core.stdc.stdio;` +fail_compilation/fail313.d(28): Error: package `imports.pkg313` is not accessible here, perhaps add `static import imports.pkg313;` --- */ module test313;