From 3a1992ecb0572583d022c2d403e5a7b6a3ab2772 Mon Sep 17 00:00:00 2001
From: Damien Maillard <damien.maillard@dailymotion.com>
Date: Thu, 9 Apr 2020 18:00:34 +0200
Subject: [PATCH 1/2] Upgrade pull request size impact to 3.0.

- Enable gzip and brotli tracking.
- Split extras/** files tracking.
---
 .../size-impact/generate-size-snapshot.js     | 20 ++++++++++++++-----
 .../size-impact/report-size-impact.js         |  3 ++-
 package.json                                  |  2 +-
 3 files changed, 18 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/size-impact/generate-size-snapshot.js b/.github/workflows/size-impact/generate-size-snapshot.js
index 0c914e99d..965c9622d 100644
--- a/.github/workflows/size-impact/generate-size-snapshot.js
+++ b/.github/workflows/size-impact/generate-size-snapshot.js
@@ -1,12 +1,22 @@
-import { generateSnapshotFile } from "@jsenv/github-pull-request-filesize-impact";
+import {
+  generateSnapshotFile,
+  none,
+  gzip,
+  brotli,
+} from "@jsenv/github-pull-request-filesize-impact";
 
 generateSnapshotFile({
   projectDirectoryUrl: new URL("../../../", import.meta.url),
   snapshotFileRelativeUrl: process.argv[2],
-  directorySizeTrackingConfig: {
-    dist: {
-      "**/*": true,
-      "**/*.map": false,
+  trackingConfig: {
+    core: {
+      "./dist/*": true,
+      "./dist/*.map": false,
+    },
+    extras: {
+      "./dist/extras/**/*.js": true,
+      "./dist/extras/**/*.map": false,
     },
   },
+  transformations: { none, gzip, brotli },
 });
diff --git a/.github/workflows/size-impact/report-size-impact.js b/.github/workflows/size-impact/report-size-impact.js
index e4d4307b3..cfdbbcc50 100644
--- a/.github/workflows/size-impact/report-size-impact.js
+++ b/.github/workflows/size-impact/report-size-impact.js
@@ -4,5 +4,6 @@ reportSizeImpactIntoGithubPullRequest({
   projectDirectoryUrl: new URL("../../../", import.meta.url),
   baseSnapshotFileRelativeUrl: process.argv[2],
   headSnapshotFileRelativeUrl: process.argv[3],
-  generatedByLink: false,
+  commentSections: { fileByFileImpact: true },
+  generatedByLink: true,
 });
diff --git a/package.json b/package.json
index e6bcd5900..5352512d8 100644
--- a/package.json
+++ b/package.json
@@ -18,7 +18,7 @@
     "dist"
   ],
   "devDependencies": {
-    "@jsenv/github-pull-request-filesize-impact": "^2.6.0",
+    "@jsenv/github-pull-request-filesize-impact": "^3.0.2",
     "@rollup/plugin-json": "^4.0.2",
     "@rollup/plugin-node-resolve": "^7.1.1",
     "@rollup/plugin-replace": "^2.3.1",

From 09626fc42762cb5d77316368e73de607da8ab3b3 Mon Sep 17 00:00:00 2001
From: Damien Maillard <damien.maillard@dailymotion.com>
Date: Thu, 9 Apr 2020 18:07:31 +0200
Subject: [PATCH 2/2] Properly disable size-impact workflow for forks

---
 .github/workflows/size-impact.yml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/size-impact.yml b/.github/workflows/size-impact.yml
index 02b373989..b457e1056 100644
--- a/.github/workflows/size-impact.yml
+++ b/.github/workflows/size-impact.yml
@@ -4,7 +4,9 @@ on: pull_request
 
 jobs:
   size-impact:
-    if: github.event.pull_request.base.repository == github.event.pull_request.head.repository
+    # disable workflow for forks because of
+    # https://help.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token#permissions-for-the-github_token
+    if: github.event.pull_request.base.repo.full_name == github.event.pull_request.head.repo.full_name
     strategy:
       matrix:
         os: [ubuntu-latest]