From aedf41eda208cb3ea6c0d0d19754a0b483a4c427 Mon Sep 17 00:00:00 2001
From: Damien Maillard <damien.maillard@dailymotion.com>
Date: Thu, 9 Apr 2020 17:14:17 +0200
Subject: [PATCH 1/2] Upgrade pull request size impact to 3.0.

- Enable gzip and brotli tracking.
- Split extras/** files tracking.
---
 .../size-impact/generate-size-snapshot.js     | 21 ++++++++++++++-----
 .../size-impact/report-size-impact.js         |  4 +++-
 package.json                                  |  2 +-
 3 files changed, 20 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/size-impact/generate-size-snapshot.js b/.github/workflows/size-impact/generate-size-snapshot.js
index 0c914e99d..8aa1b93c1 100644
--- a/.github/workflows/size-impact/generate-size-snapshot.js
+++ b/.github/workflows/size-impact/generate-size-snapshot.js
@@ -1,12 +1,23 @@
-import { generateSnapshotFile } from "@jsenv/github-pull-request-filesize-impact";
+import {
+  generateSnapshotFile,
+  none,
+  gzip,
+  brotli,
+} from "@jsenv/github-pull-request-filesize-impact";
 
 generateSnapshotFile({
+  logLevel: "debug",
   projectDirectoryUrl: new URL("../../../", import.meta.url),
   snapshotFileRelativeUrl: process.argv[2],
-  directorySizeTrackingConfig: {
-    dist: {
-      "**/*": true,
-      "**/*.map": false,
+  trackingConfig: {
+    core: {
+      "./dist/*": true,
+      "./dist/*.map": false,
+    },
+    extras: {
+      "./dist/extras/**/*.js": true,
+      "./dist/extras/**/*.map": false,
     },
   },
+  transformations: { none, gzip, brotli },
 });
diff --git a/.github/workflows/size-impact/report-size-impact.js b/.github/workflows/size-impact/report-size-impact.js
index e4d4307b3..cc94025ff 100644
--- a/.github/workflows/size-impact/report-size-impact.js
+++ b/.github/workflows/size-impact/report-size-impact.js
@@ -1,8 +1,10 @@
 import { reportSizeImpactIntoGithubPullRequest } from "@jsenv/github-pull-request-filesize-impact";
 
 reportSizeImpactIntoGithubPullRequest({
+  logLevel: "debug",
   projectDirectoryUrl: new URL("../../../", import.meta.url),
   baseSnapshotFileRelativeUrl: process.argv[2],
   headSnapshotFileRelativeUrl: process.argv[3],
-  generatedByLink: false,
+  commentSections: { fileByFileImpact: true },
+  generatedByLink: true,
 });
diff --git a/package.json b/package.json
index e6bcd5900..5352512d8 100644
--- a/package.json
+++ b/package.json
@@ -18,7 +18,7 @@
     "dist"
   ],
   "devDependencies": {
-    "@jsenv/github-pull-request-filesize-impact": "^2.6.0",
+    "@jsenv/github-pull-request-filesize-impact": "^3.0.2",
     "@rollup/plugin-json": "^4.0.2",
     "@rollup/plugin-node-resolve": "^7.1.1",
     "@rollup/plugin-replace": "^2.3.1",

From 68c902148e04876df58164fd16b9f55b848e13f9 Mon Sep 17 00:00:00 2001
From: Damien Maillard <damien.maillard@dailymotion.com>
Date: Thu, 9 Apr 2020 17:18:05 +0200
Subject: [PATCH 2/2] Dumb change to test

---
 src/system-core.js | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/system-core.js b/src/system-core.js
index e41e23f4c..7b9f1aeeb 100644
--- a/src/system-core.js
+++ b/src/system-core.js
@@ -1,6 +1,6 @@
 /*
  * SystemJS Core
- * 
+ *
  * Provides
  * - System.import
  * - System.register support for
@@ -10,7 +10,7 @@
  * - Symbol.toStringTag support in Module objects
  * - Hookable System.createContext to customize import.meta
  * - System.onload(err, id, deps) handler for tracing / hot-reloading
- * 
+ *
  * Core comes with no System.prototype.resolve or
  * System.prototype.instantiate implementations
  */
@@ -79,9 +79,10 @@ function getOrCreateLoad (loader, id, firstParentUrl) {
 
   var importerSetters = [];
   var ns = Object.create(null);
+  var toStringTagValue = 'Module'
   if (toStringTag)
-    Object.defineProperty(ns, toStringTag, { value: 'Module' });
-  
+    Object.defineProperty(ns, toStringTag, { value: toStringTagValue });
+
   var instantiatePromise = Promise.resolve()
   .then(function () {
     return loader.instantiate(id, firstParentUrl);