Build fails on `main` 66a5fa2448398379dc21c18308e3b95d42d84015

[abhillman]

What happens?

aryehh@debian-nix ~/duckdb-sqlite (main)> make GEN=ninja release
Makefile:19: warning: overriding recipe for target 'test_release_internal'
extension-ci-tools/makefiles/duckdb_extension.Makefile:102: warning: ignoring old recipe for target 'test_release_internal'
Makefile:22: warning: overriding recipe for target 'test_debug_internal'
extension-ci-tools/makefiles/duckdb_extension.Makefile:104: warning: ignoring old recipe for target 'test_debug_internal'
Makefile:25: warning: overriding recipe for target 'test_reldebug_internal'
extension-ci-tools/makefiles/duckdb_extension.Makefile:106: warning: ignoring old recipe for target 'test_reldebug_internal'
mkdir -p build/release
cmake -G "Ninja" -DFORCE_COLORED_OUTPUT=1 -DEXTENSION_STATIC_BUILD=1 -DDUCKDB_EXTENSION_CONFIGS='/home/aryehh/duckdb-sqlite/extension_config.cmake'   -DOSX_BUILD_ARCH=   -DDUCKDB_EXPLICIT_PLATFORM='' -DCUSTOM_LINKER=  -DCMAKE_BUILD_TYPE=Release -S "./duckdb/" -B build/release
-- Found Python3: /usr/bin/python3 (found version "3.11.2") found components: Interpreter
-- The C compiler identification is GNU 12.2.0
-- The CXX compiler identification is GNU 12.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found Git: /usr/bin/git (found version "2.39.5")
-- git hash d707b4432b, version v1.1.4-dev4271, extension folder d707b4432b
-- Extensions will be deployed to: /home/aryehh/duckdb-sqlite/build/release/repository
-- Load extension 'sqlite_scanner' from '/home/aryehh/duckdb-sqlite' @ 66a5fa2
-- Load extension 'tpch' from '/home/aryehh/duckdb-sqlite/duckdb/extensions' @ d707b4432b
-- Load extension 'core_functions' from '/home/aryehh/duckdb-sqlite/duckdb/extensions' @ d707b4432b
-- Load extension 'parquet' from '/home/aryehh/duckdb-sqlite/duckdb/extensions' @ d707b4432b
-- Load extension 'jemalloc' from '/home/aryehh/duckdb-sqlite/duckdb/extensions' @ d707b4432b
CMake Warning at CMakeLists.txt:1314 (message):
  Extension 'sqlite_scanner' has a vcpkg.json, but build was not run with
  VCPKG.  If build fails, check out VCPKG build instructions in
  'duckdb/extension/README.md' or try manually installing the dependencies in
  /home/aryehh/duckdb-sqlitevcpkg.json


-- Extensions linked into DuckDB: [sqlite_scanner, tpch, core_functions, parquet, jemalloc]
-- Tests loaded for extensions: [sqlite_scanner]
-- Configuring done
-- Generating done
-- Build files have been written to: /home/aryehh/duckdb-sqlite/build/release
cmake --build build/release --config Release
[181/770] Building CXX object extension/sqlite_s.../sqlite_ext_storage.dir/sqlite_transaction.cpp.
FAILED: extension/sqlite_scanner/src/storage/CMakeFiles/sqlite_ext_storage.dir/sqlite_transaction.cpp.o
/usr/bin/c++ -DDUCKDB_BUILD_LIBRARY -DEXT_VERSION_SQLITE_SCANNER=\"66a5fa2\" -I/home/aryehh/duckdb-sqlite/duckdb/src/include -I/home/aryehh/duckdb-sqlite/duckdb/third_party/fsst -I/home/aryehh/duckdb-sqlite/duckdb/third_party/fmt/include -I/home/aryehh/duckdb-sqlite/duckdb/third_party/hyperloglog -I/home/aryehh/duckdb-sqlite/duckdb/third_party/fastpforlib -I/home/aryehh/duckdb-sqlite/duckdb/third_party/skiplist -I/home/aryehh/duckdb-sqlite/duckdb/third_party/fast_float -I/home/aryehh/duckdb-sqlite/duckdb/third_party/re2 -I/home/aryehh/duckdb-sqlite/duckdb/third_party/miniz -I/home/aryehh/duckdb-sqlite/duckdb/third_party/utf8proc/include -I/home/aryehh/duckdb-sqlite/duckdb/third_party/concurrentqueue -I/home/aryehh/duckdb-sqlite/duckdb/third_party/pcg -I/home/aryehh/duckdb-sqlite/duckdb/third_party/tdigest -I/home/aryehh/duckdb-sqlite/duckdb/third_party/mbedtls/include -I/home/aryehh/duckdb-sqlite/duckdb/third_party/jaro_winkler -I/home/aryehh/duckdb-sqlite/duckdb/third_party/yyjson/include -I/home/aryehh/duckdb-sqlite/duckdb/third_party/zstd/include -I/home/aryehh/duckdb-sqlite/src/sqlite -I/home/aryehh/duckdb-sqlite/src/include -O3 -DNDEBUG -ffunction-sections -fdata-sections -O3 -DNDEBUG   -fPIC -fdiagnostics-color=always -std=c++11 -MD -MT extension/sqlite_scanner/src/storage/CMakeFiles/sqlite_ext_storage.dir/sqlite_transaction.cpp.o -MF extension/sqlite_scanner/src/storage/CMakeFiles/sqlite_ext_storage.dir/sqlite_transaction.cpp.o.d -o extension/sqlite_scanner/src/storage/CMakeFiles/sqlite_ext_storage.dir/sqlite_transaction.cpp.o -c /home/aryehh/duckdb-sqlite/src/storage/sqlite_transaction.cpp
/home/aryehh/duckdb-sqlite/src/storage/sqlite_transaction.cpp: In member function ‘duckdb::optional_ptr<duckdb::CatalogEntry> duckdb::SQLiteTransaction::GetCatalogEntry(const std::string&)’:
/home/aryehh/duckdb-sqlite/src/storage/sqlite_transaction.cpp:140:67: error: no matching function for call to ‘duckdb::CreateViewInfo::FromCreateView(duckdb::ClientContext&, duckdb::SQLiteSchemaEntry&, std::string&)’
  140 |                         view_info = CreateViewInfo::FromCreateView(*context.lock(), sqlite_catalog.GetMainSchema(), sql);
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/aryehh/duckdb-sqlite/src/storage/sqlite_transaction.cpp:7:
/home/aryehh/duckdb-sqlite/duckdb/src/include/duckdb/parser/parsed_data/create_view_info.hpp:43:54note: candidate: ‘static duckdb::unique_ptr<duckdb::CreateViewInfo> duckdb::CreateViewInfo::FromCreateView(duckdb::ClientContext&, const std::string&)’
   43 |         DUCKDB_API static unique_ptr<CreateViewInfo> FromCreateView(ClientContext &context, const string &sql);
      |                                                      ^~~~~~~~~~~~~~
/home/aryehh/duckdb-sqlite/duckdb/src/include/duckdb/parser/parsed_data/create_view_info.hpp:43:54note:   candidate expects 2 arguments, 3 provided
/home/aryehh/duckdb-sqlite/src/storage/sqlite_transaction.cpp:146:67: error: no matching function for call to ‘duckdb::CreateViewInfo::FromCreateView(duckdb::ClientContext&, duckdb::SQLiteSchemaEntry&, std::__cxx11::basic_string<char>&)’
  146 |                         view_info = CreateViewInfo::FromCreateView(*context.lock(), sqlite_catalog.GetMainSchema(), view_def);
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/aryehh/duckdb-sqlite/duckdb/src/include/duckdb/parser/parsed_data/create_view_info.hpp:43:54note: candidate: ‘static duckdb::unique_ptr<duckdb::CreateViewInfo> duckdb::CreateViewInfo::FromCreateView(duckdb::ClientContext&, const std::string&)’
   43 |         DUCKDB_API static unique_ptr<CreateViewInfo> FromCreateView(ClientContext &context, const string &sql);
      |                                                      ^~~~~~~~~~~~~~
/home/aryehh/duckdb-sqlite/duckdb/src/include/duckdb/parser/parsed_data/create_view_info.hpp:43:54note:   candidate expects 2 arguments, 3 provided
[206/770] Building C object extension/sqlite_sca...src/sqlite/CMakeFiles/sqlite_lib.dir/sqlite3.c.
ninja: build stopped: subcommand failed.

To Reproduce

aryehh@debian-nix ~/duckdb-sqlite (main) [SIGINT]> uname -a
Linux debian-nix 6.1.0-32-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.129-1 (2025-03-06) x86_64 GNU/Linux

aryehh@debian-nix ~/duckdb-sqlite (main)> cmake --version
cmake version 3.25.1

CMake suite maintained and supported by Kitware (kitware.com/cmake).

aryehh@debian-nix ~> c++ --version
c++ (Debian 12.2.0-14) 12.2.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

OS:

debian

SQLite Version:

n/a

DuckDB Version:

n/a

DuckDB Client:

n/a

Full Name:

Aryeh Hillman

Affiliation:

self

Have you tried this on the latest main branch?

• I agree

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

• I agree

[abhillman]

Without GEN=ninja and rm -rf build/ before https://gist.github.com/abhillman/1a05328d1b0124f2b271422f0430d2f7

With Dockerfile https://gist.github.com/abhillman/afef32fc7d9b4fc39826467bf2fa0d2b

[carlopi]

Hi, I think this might be on me, local solution is probably change the content of duckdb subfolder to point to v1.2.1 duckdb release.

[c-herrewijn]

fixed by bumping duckdb to v1.2.2
PR: #149