Unable to build on Mac

[bjorn-nesby]

What happens?

When trying to compile this extension, I get the following error, followed by additional (and similar) errors:

[ 37%] Building CXX object extension/sqlite_scanner/src/storage/CMakeFiles/sqlite_ext_storage.dir/sqlite_catalog.cpp.o
In file included from /Users/bnn/Develop/duckdb-sqlite/src/storage/sqlite_catalog.cpp:1:
/Users/bnn/Develop/duckdb-sqlite/src/include/storage/sqlite_catalog.hpp:38:100: error: only virtual member functions can be marked 'override'
   38 |                                                    QueryErrorContext error_context = QueryErrorContext()) override;
      |                                                                                                           ^~~~~~~~
/Users/bnn/Develop/duckdb-sqlite/src/include/storage/sqlite_catalog.hpp:45:77: error: non-virtual member function marked 'override' hides virtual member function
   45 |                                                 unique_ptr<PhysicalOperator> plan) override;
      |                                                                                    ^
/Users/bnn/Develop/duckdb-sqlite/duckdb/src/include/duckdb/catalog/catalog.hpp:294:28: note: hidden overloaded virtual function 'duckdb::Catalog::PlanInsert' declared here: different number of parameters (4 vs 3)
  294 |         virtual PhysicalOperator &PlanInsert(ClientContext &context, PhysicalPlanGenerator &planner, LogicalInsert &op,
      |                                   ^
In file included from /Users/bnn/Develop/duckdb-sqlite/src/storage/sqlite_catalog.cpp:1:
/Users/bnn/Develop/duckdb-sqlite/src/include/storage/sqlite_catalog.hpp:47:84: error: non-virtual member function marked 'override' hides virtual member function
   47 |                                                        unique_ptr<PhysicalOperator> plan) override;
      |                                                                                           ^
/Users/bnn/Develop/duckdb-sqlite/duckdb/src/include/duckdb/catalog/catalog.hpp:292:28: note: hidden overloaded virtual function 'duckdb::Catalog::PlanCreateTableAs' declared here: different number of parameters (4 vs 3)
  292 |         virtual PhysicalOperator &PlanCreateTableAs(ClientContext &context, PhysicalPlanGenerator &planner,

I have tried to compile on the following platforms.

• MacOS 15.4 (M2) - AppleClang 15.0.0
• MacOS 11.7.10 (Intel) - AppleClang 13.0.0
• MacOS 15.5 (Intel) - AppleClang 17.0.0

To Reproduce

The steps I used:

1. git clone https://github.com/duckdb/duckdb-sqlite.git
2. cd duckdb-sqlite
3. git submodule update --init --recursive
4. make

OS:

MacOS 11.7.10, MacOS 15.4

SQLite Version:

3.38.1

DuckDB Version:

1.2.2

DuckDB Client:

N/A (compiling from source)

Full Name:

Bjørn Næsby Nielsen

Affiliation:

Sononym

Have you tried this on the latest main branch?

• I agree

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

• I agree

[Maxxen]

There have been breaking changes on the DuckDB main branch since the last commit to this repo (it needs to be updated with the patches in duckdb main repo), hence the error. Im guessing it will work if you pin the duckdb submodule to the v1.2.2 tag.

[bjorn-nesby]

Im guessing it will work if you pin the duckdb submodule to the v1.2.2 tag.

Thanks! I forgot that submodules might need this additional step.
Pinning to the tag indeed made it the problem go away.