-
Notifications
You must be signed in to change notification settings - Fork 9
Description
Not quite an issue - more like a heads up. I'd do a pull request but there's some legitimate compatibility reasons why these should be separate versions.
Bizhawk 2.9 upgraded the lua engine it looks like, thus the (bit.) functions throw errors about them being depreciated. It's generally not a problem - the scripts still work - but I was running into an issue with bit.bor() operating extremely slowly with some TAS dumps when the message was generated.
You can add this to the top to allow for compatibility to the older lua engine:
bit = (require "migration_helpers").EmuHawk_pre_2_9_bit();
But the errors thrown looked like they had the new convention listed right there, and it was fairly trivial to just convert it as well.
Here's links to fixed up versions that don't throw errors about depreciation:
https://github.com/Krayzar/Game-TAS-and-Monitor-Scripts/blob/main/bizhawk_a2600_dump_frames.lua
https://github.com/Krayzar/Game-TAS-and-Monitor-Scripts/blob/main/bizhawk_nes_dump_frames.lua
https://github.com/Krayzar/Game-TAS-and-Monitor-Scripts/blob/main/bizhawk_snes_dump_frames.lua