From 79eceabb332cd5c89c30be20111823e2dd51cb32 Mon Sep 17 00:00:00 2001 From: "Empting Eelco (ETAS-ECM/XPC-Fe2)" Date: Wed, 25 Feb 2026 08:42:26 +0100 Subject: [PATCH 1/3] Add fakechroot dep, remove continue on error --- .github/workflows/tests.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 459c851..224ebe1 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -46,6 +46,12 @@ jobs: ref: ${{ github.head_ref || github.event.pull_request.head.ref || github.ref }} repository: ${{ github.event.pull_request.head.repo.full_name || github.repository }} + - name: Install fakechroot + uses: eclipse-score/apt-install@main + with: + packages: fakechroot + cache: false + - name: Setup Bazel with shared caching uses: bazel-contrib/setup-bazel@0.18.0 with: @@ -58,7 +64,6 @@ jobs: run: | echo "Running: bazel ${{ inputs.bazel-target }}" bazel ${{ inputs.bazel-target }} - continue-on-error: true # Always continue to upload artifacts - name: Upload Bazel test artifacts if: ${{ inputs.upload-name != 'NO UPLOAD OF TEST RESULTS CONFIGURED' }} From 7187d479b7b16dd991456da548325cf270d6ef09 Mon Sep 17 00:00:00 2001 From: "Empting Eelco (ETAS-ECM/XPC-Fe2)" Date: Wed, 25 Feb 2026 11:28:45 +0100 Subject: [PATCH 2/3] Make package install optional --- .github/workflows/tests.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 224ebe1..edc0a3d 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -33,6 +33,11 @@ on: bazel-testlogs/**/*.xml bazel-testlogs/**/test.log type: string + packages: + description: "Custom packages to install before running tests" + required: false + default: "" + type: string jobs: unit-tests: @@ -46,10 +51,11 @@ jobs: ref: ${{ github.head_ref || github.event.pull_request.head.ref || github.ref }} repository: ${{ github.event.pull_request.head.repo.full_name || github.repository }} - - name: Install fakechroot + - name: Install dependencies + if: ${{ inputs.packages != '' }} uses: eclipse-score/apt-install@main with: - packages: fakechroot + packages: ${{ inputs.packages }} cache: false - name: Setup Bazel with shared caching From f10a6f444585b2121f73d3d1bc09fdc1e8ae00d6 Mon Sep 17 00:00:00 2001 From: "Empting Eelco (ETAS-ECM/XPC-Fe2)" Date: Wed, 25 Feb 2026 13:35:41 +0100 Subject: [PATCH 3/3] Always uplaod test logs --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index edc0a3d..ce0742c 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -72,7 +72,7 @@ jobs: bazel ${{ inputs.bazel-target }} - name: Upload Bazel test artifacts - if: ${{ inputs.upload-name != 'NO UPLOAD OF TEST RESULTS CONFIGURED' }} + if: ${{ always() && inputs.upload-name != 'NO UPLOAD OF TEST RESULTS CONFIGURED' }} uses: actions/upload-artifact@v6 with: name: ${{ inputs.upload-name }}