The best way to add options to all windows restored, not just the main window

[eengoron]

Hey Johnny --

In using your library, I'm running into an issue in restoring windows where webpreferences like preload scripts and nodeIntegration: false can only be added to the main window, and not windows that aren't considered main.

Is there a recommended way to add preload scripts to all windows, and not just the main window when windows are restored?

I was able to get around this by changing:

if ( state.main ) {
        // NOTE: It is possible we change default options during development, so event we restore
        //       a window, we should always apply default options for the main window.

        // clone the opts
        let opts2 = Object.assign({}, opts);
        opts2.show = false;

        win = new BrowserWindow(opts2);
        _mainwin = win;
      } else {
        win = new BrowserWindow({
          show: false
        });
      }

to

      if ( state.main ) {
        // NOTE: It is possible we change default options during development, so event we restore
        //       a window, we should always apply default options for the main window.

        // clone the opts
        win = new BrowserWindow(opts2);
        _mainwin = win;
      } else {
        win = new BrowserWindow(opts2);
      }

In a forked repo as a test, but I'd love to hear if there's a better way to do this. Is this a functionality you'd consider adding?

Let me know. Thanks!

Eric

[jwu]

Hi Eric,

This is a very good question. I think the key point to solve the problem is --- how can we get the options of the BrowserWindow when user call windowPlus.manage(win) to manage a window.

Because I don't provide any create method for window creation in window-plus, user can freely create BrowserWindow by their options, and then manage it later in their code. Since that I don't have the option for each window when user construct it. If we have that options we can restore it by using the same option user applied last time, and solve the problem perfectly.

(so far, I didn't find the way to get the options of an existing BrowserWindow)

[eengoron]

Hey Johnny --

Thanks for the response, and apologies for the delayed reply. I see what you're saying, but I believe my question was a bit confusing, so let me try to explain it one more time, just to make sure we're on the same page :).

Right now, electron-window-plus is built so that you can pass options to the restore method and have those opts be included when restoring a BrowserWindow: windowPlus.restore ([defaultUrl, opts])

I have a piece of code in my application that says:
if (windowPlus.restore(null, { webPreferences: { nodeIntegration: false, preload: path.resolve(path.join(__dirname, '../preload.js')) } })) so that when the _main window gets restored, it adds the webPreferences I need. That part works just fine.

But, the issue that I'm having is that: I need every window restored (even non-main ones) to have the same webPreferences as the _main window. Basically, I need those opts passed through in restore() to go to every window and not just the _main one.

The windowPlus.restore ([defaultUrl, opts]) method currently only allows you to add opts to a restored window if it is the _main window, so this would not be possible. Would you ever consider making a change so that you can specify opts for non-main windows as well?

I just need the webPreferences to match for all windows. Main or not.

Let me know if that makes it a little bit clearer. Thanks!