From 36b1ef70ce4777936d7f1c1602b936ab030c3b2b Mon Sep 17 00:00:00 2001 From: Sander Jochems Date: Fri, 15 Aug 2025 17:57:57 +0200 Subject: [PATCH 1/2] fix: Swap ModelSupportsVaneHorizontal and ModelSupportsVaneVertical --- src/pymelcloud/ata_device.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pymelcloud/ata_device.py b/src/pymelcloud/ata_device.py index b727048..3394171 100644 --- a/src/pymelcloud/ata_device.py +++ b/src/pymelcloud/ata_device.py @@ -321,7 +321,7 @@ def vane_horizontal_positions(self) -> Optional[List[str]]: if self._device_conf.get("HideVaneControls", False): return [] device = self._device_conf.get("Device", {}) - if not device.get("ModelSupportsVaneHorizontal", False): + if not device.get("ModelSupportsVaneVertical", False): return [] positions = [ @@ -351,7 +351,7 @@ def vane_vertical_positions(self) -> Optional[List[str]]: if self._device_conf.get("HideVaneControls", False): return [] device = self._device_conf.get("Device", {}) - if not device.get("ModelSupportsVaneVertical", False): + if not device.get("ModelSupportsVaneHorizontal", False): return [] positions = [ From 1a886c51293b29995459697216258cd344be8582 Mon Sep 17 00:00:00 2001 From: Sander Jochems Date: Tue, 19 Aug 2025 19:34:29 +0200 Subject: [PATCH 2/2] fix: Add comment detailing property swap --- src/pymelcloud/ata_device.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/pymelcloud/ata_device.py b/src/pymelcloud/ata_device.py index 3394171..dc51232 100644 --- a/src/pymelcloud/ata_device.py +++ b/src/pymelcloud/ata_device.py @@ -321,6 +321,7 @@ def vane_horizontal_positions(self) -> Optional[List[str]]: if self._device_conf.get("HideVaneControls", False): return [] device = self._device_conf.get("Device", {}) + # ModelSupportsVaneVertical and ModelSupportsVaneHorizontal are swapped in the API if not device.get("ModelSupportsVaneVertical", False): return [] @@ -351,6 +352,7 @@ def vane_vertical_positions(self) -> Optional[List[str]]: if self._device_conf.get("HideVaneControls", False): return [] device = self._device_conf.get("Device", {}) + # ModelSupportsVaneHorizontal and ModelSupportsVaneVertical are swapped in the API if not device.get("ModelSupportsVaneHorizontal", False): return []