-
Notifications
You must be signed in to change notification settings - Fork 309
Open
Description
fbjs assumes in various places yarn is installed but doesn't declare it as a dependency or call it out in the README. To name a few:
- Build scripts -
Lines 18 to 22 in af9fefa
"fbjs:build": "cd packages/fbjs && yarn && yarn run build", "fbjs:test": "cd packages/fbjs && yarn && yarn run test", "fbjs:flow": "cd packages/fbjs && yarn && yarn run flow", "preset:test": "cd packages/babel-preset-fbjs && yarn && yarn run test", "signedsource:test": "cd packages/signedsource && yarn && yarn run test" fbjsprepublish script -fbjs/packages/fbjs/package.json
Line 11 in af9fefa
"prepublish": "yarn run build", check-dependenciesGulp plugin -'yarn',
etc.
I believe it would be useful to call out fbjs depends on Facebook's omakase stack in the README at a minimum.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels