From 14976368c7953a915476b9ffec4a770e694b58e5 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Fri, 6 Mar 2026 00:34:57 +0000 Subject: [PATCH 1/2] fix: apply clippy suggestions across workspace - Auto-fix: simplify iterator in owhisper-client batch adapter - Suppress dead_code warnings for pub(crate) items in audio crate (async_ring, rt_ring) - Suppress too_many_arguments warnings in transcribe-proxy relay (builder, handler) Co-Authored-By: bot_apk --- crates/audio/src/async_ring.rs | 2 ++ crates/audio/src/rt_ring.rs | 2 ++ crates/owhisper-client/src/adapter/cactus/batch.rs | 5 ++--- crates/transcribe-proxy/src/relay/builder.rs | 1 + crates/transcribe-proxy/src/relay/handler.rs | 3 +++ 5 files changed, 10 insertions(+), 3 deletions(-) diff --git a/crates/audio/src/async_ring.rs b/crates/audio/src/async_ring.rs index 0bac56e6c9..f719a41bdf 100644 --- a/crates/audio/src/async_ring.rs +++ b/crates/audio/src/async_ring.rs @@ -7,6 +7,7 @@ use std::time::{Duration, Instant}; pub(crate) struct PollNextSample { pub(crate) poll: Poll>, + #[allow(dead_code)] pub(crate) did_pop_chunk: bool, } @@ -66,6 +67,7 @@ where self } + #[allow(dead_code)] pub(crate) fn has_buffered_samples(&self) -> bool { self.read_idx < self.read_len } diff --git a/crates/audio/src/rt_ring.rs b/crates/audio/src/rt_ring.rs index 36c626dc06..2bb91529bc 100644 --- a/crates/audio/src/rt_ring.rs +++ b/crates/audio/src/rt_ring.rs @@ -93,6 +93,7 @@ where } } +#[allow(dead_code)] pub(crate) fn convert_and_push_to_ringbuf( samples: &[T], scratch: &mut [f32], @@ -143,6 +144,7 @@ where } } +#[allow(dead_code)] pub(crate) fn push_f32_to_ringbuf

(data: &[f32], producer: &mut P) -> PushStats where P: Producer, diff --git a/crates/owhisper-client/src/adapter/cactus/batch.rs b/crates/owhisper-client/src/adapter/cactus/batch.rs index 3eedcca183..d22963d751 100644 --- a/crates/owhisper-client/src/adapter/cactus/batch.rs +++ b/crates/owhisper-client/src/adapter/cactus/batch.rs @@ -302,15 +302,14 @@ impl SseParserState { &mut self, response: StreamResponse, ) -> Option> { - if let StreamResponse::TranscriptResponse { channel, .. } = &response { - if channel + if let StreamResponse::TranscriptResponse { channel, .. } = &response + && channel .alternatives .first() .is_some_and(|a| !a.words.is_empty()) { self.saw_segment_words = true; } - } let segment_end = match &response { StreamResponse::TranscriptResponse { diff --git a/crates/transcribe-proxy/src/relay/builder.rs b/crates/transcribe-proxy/src/relay/builder.rs index f624e9d712..e84898361b 100644 --- a/crates/transcribe-proxy/src/relay/builder.rs +++ b/crates/transcribe-proxy/src/relay/builder.rs @@ -69,6 +69,7 @@ impl WebSocketProxyBuilder { } } + #[allow(clippy::too_many_arguments)] fn build_from( request: ClientRequestBuilder, control_message_types: HashSet<&'static str>, diff --git a/crates/transcribe-proxy/src/relay/handler.rs b/crates/transcribe-proxy/src/relay/handler.rs index 26915dabf1..091cb88ec6 100644 --- a/crates/transcribe-proxy/src/relay/handler.rs +++ b/crates/transcribe-proxy/src/relay/handler.rs @@ -35,6 +35,7 @@ pub struct WebSocketProxy { } impl WebSocketProxy { + #[allow(clippy::too_many_arguments)] pub(crate) fn new( upstream_request: ClientRequestBuilder, control_message_types: Option, @@ -117,6 +118,7 @@ impl WebSocketProxy { .into_response() } + #[allow(clippy::too_many_arguments)] async fn run_proxy_loop( client_socket: WebSocket, upstream_stream: WebSocketStream>, @@ -209,6 +211,7 @@ impl WebSocketProxy { false } + #[allow(clippy::too_many_arguments)] async fn run_client_to_upstream( mut client_receiver: ClientReceiver, mut upstream_sender: UpstreamSender, From a1d49f599afb3c7ff9bf2ee654b31fbf09c601bb Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Fri, 6 Mar 2026 00:40:25 +0000 Subject: [PATCH 2/2] fix: correct dprint formatting for let-chain in batch.rs Co-Authored-By: bot_apk --- crates/owhisper-client/src/adapter/cactus/batch.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/owhisper-client/src/adapter/cactus/batch.rs b/crates/owhisper-client/src/adapter/cactus/batch.rs index d22963d751..d3b1dd6f59 100644 --- a/crates/owhisper-client/src/adapter/cactus/batch.rs +++ b/crates/owhisper-client/src/adapter/cactus/batch.rs @@ -307,9 +307,9 @@ impl SseParserState { .alternatives .first() .is_some_and(|a| !a.words.is_empty()) - { - self.saw_segment_words = true; - } + { + self.saw_segment_words = true; + } let segment_end = match &response { StreamResponse::TranscriptResponse {